Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Thank you, Vyom Regards, Chris > On 29 Jun 2018, at 11:13 AM, vyom tewari wrote: > > looks good to me. > > Vyom > > On Friday 29 June 2018 06:22 AM, Chris Yin wrote: >> Hi, Vyom >> >> Sure, fixed the tag order as you suggested, thanks >> >> New changes: >> >> diff -r 1308189b0848 test/jdk/

Re: 8143850: retrofit ArrayDeque to implement List

Thanks, Alex. This has been on my todo list for a long time and I'm more overcommitted than ever. The difficult part is designing of the interface, but then there are many tests to write... I sort of liked ArrayDeque.asList() because at least then the API surface to be added is small. ArrayDequ

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

looks good to me. Vyom On Friday 29 June 2018 06:22 AM, Chris Yin wrote: Hi, Vyom Sure, fixed the tag order as you suggested, thanks New changes: diff -r 1308189b0848 test/jdk/com/sun/jndi/dns/Test6991580.java --- a/test/jdk/com/sun/jndi/dns/Test6991580.javaThu Jun 28 17:45:59 2018 -0700 +

Re: [PATCH] AbstractStringBuilder.append()

On Thu, Jun 28, 2018 at 11:59 AM, Isaac Levy wrote: > And can't remove append(StringBuffer) because of binary compatibility? > That seems right. --- Also, the JIT can optijmize away any instanceof checks after inining when it sees append(stringBuilder). And any optimizations here are far les

Re: RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

Hi Erik, Thank you for the quick review! Jiangli > On Jun 28, 2018, at 5:44 PM, Erik Joelsson wrote: > > Build changes look good. > > /Erik > > > On 2018-06-28 16:15, Jiangli Zhou wrote: >> This is a follow-up RFE of JDK-8201650 (Move iteration order randomization >> of unmodifiable Set an

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Hi, Vyom Sure, fixed the tag order as you suggested, thanks New changes: diff -r 1308189b0848 test/jdk/com/sun/jndi/dns/Test6991580.java --- a/test/jdk/com/sun/jndi/dns/Test6991580.javaThu Jun 28 17:45:59 2018 -0700 +++ b/test/jdk/com/sun/jndi/dns/Test6991580.javaFri Jun 29 08:4

Re: RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

Build changes look good. /Erik On 2018-06-28 16:15, Jiangli Zhou wrote: This is a follow-up RFE of JDK-8201650 (Move iteration order randomization of unmodifiable Set and Map to iterators), which was resolved to allow Set/Map objects being archived at CDS dump time (thanks Claes and Stuart M

Re: RFR(JDK12/JAXP/java.xml) 8190835: Subtraction with two javax.xml.datatype.Duration gives incorrect result

Looks OK joe. > On Jun 28, 2018, at 5:06 PM, Joe Wang wrote: > > Hi, > > Please review a quick fix for the first of JDK12/JAXP. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8190835 > webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8190835/webrev/ > > Thanks, > Joe

RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

This is a follow-up RFE of JDK-8201650 (Move iteration order randomization of unmodifiable Set and Map to iterators), which was resolved to allow Set/Map objects being archived at CDS dump time (thanks Claes and Stuart Marks). In the current RFE, it archives the set of system ModuleReference and

8143850: retrofit ArrayDeque to implement List

Hi, I did this awhile ago and I'd like to submit it. I believe it needs to be a new class because it changes the behavior of equals and hashcode. My implementation is based off of the java 8

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

- Mail original - > De: "Bernd Eckenfels" > À: "core-libs-dev" > Envoyé: Jeudi 28 Juin 2018 22:47:23 > Objet: Re: Draft JEP proposal: JDK-8200758: Packaging Tool > You can add-modules from the JDK (only), so if you „—add-modules > lang.base,JDK.jcmd,jdk.crypto.mscapi“ you get a super com

RFR(JDK12/JAXP/java.xml) 8190835: Subtraction with two javax.xml.datatype.Duration gives incorrect result

Hi, Please review a quick fix for the first of JDK12/JAXP. JBS: https://bugs.openjdk.java.net/browse/JDK-8190835 webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8190835/webrev/ Thanks, Joe

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

You can add-modules from the JDK (only), so if you „—add-modules lang.base,JDK.jcmd,jdk.crypto.mscapi“ you get a super compact JRE which still can start your app from the classpath. Gruss Bernd -- http://bernd.eckenfels.net Von: Remi Forax Gesendet: Donnerstag, 28. Juni 2018 22:05 An: Bernd Ec

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

no you can't, --add-modules requires the module to have a module-info, being an automatic module is not good enough. regards, Rémi - Mail original - > De: "Bernd Eckenfels" > À: "core-libs-dev" > Envoyé: Jeudi 28 Juin 2018 17:34:35 > Objet: Re: Draft JEP proposal: JDK-8200758: Packagin

Re: [PATCH] AbstractStringBuilder.append()

And can't remove append(StringBuffer) because of binary compatibility? Isaac On Thu, Jun 28, 2018 at 1:22 AM, Martin Buchholz wrote: > I'm fairly sure the append(StringBuilder) overloads were left out > intentionally. > > On Wed, Jun 27, 2018 at 8:57 PM, Isaac Levy wrote: >> >> AbstractStringB

Re: RFR: 8177275: IllegalArgumentException when MH would have too many parameters is not specified for several methods

+1 Paul. > On Jun 28, 2018, at 1:27 AM, Vivek Theeyarath > wrote: > > Hi All, > > Please review fix for > https://bugs.openjdk.java.net/browse/JDK-8177275 . The jtreg test runs fine > with the changes. > > > > http://cr.openjdk.java.net/~vtheeyarath/8177275/webrev.02/ > >

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

Hi Alan, On 28 June 2018 at 13:49, Alan Bateman wrote: > On 20/06/2018 11:08, Pengfei Li wrote: >> >> Hi >> >> I have tried the patch ( >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/052991.html ) >> on Ubuntu 18.04 machines (x86_64 & aarch64) with glibc=2.26.1 and build is >> O

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Comments inline. On 28/06/2018 17:20, Erik Gahlin wrote: It's sufficient if an event object escapes to another method (regardless if JFR is enabled or not). Some more feedback: Rename event jdk.CertChain to jdk.CertificateChain Rename event jdk.X509Cert to jdk.X509Certificate Rename field ce

Re: RFR: 8148188: Enhance the security libraries to record events of interest

It's sufficient if an event object escapes to another method (regardless if JFR is enabled or not). Some more feedback: Rename event jdk.CertChain to jdk.CertificateChain Rename event jdk.X509Cert to jdk.X509Certificate Rename field certChain to certificateChain. Rename field serialNum to seria

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

you can jlink without any/complete module info files by specifying the module names on the command line (--add-modules)as well. It produces a jre like Directory including Java launcher which allows additions on the classpath. -- https://Bernd.eckenfels.net From:

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Looks fine to me. Thanks! Xuelei On 6/28/2018 5:28 AM, Seán Coffey wrote: Thanks for reviewing Xuelei, I do acknowledge that the new TLS v1.3 code has greatly improved the logging output for related operations. I think the main drive with this enhancement is to use the new JFR API to captur

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Thanks for the update Erik. By default I'm proposing that the new JFR Events and Logger be disabled. As a result the event class shouldn't escape. If performance metrics highlight an issue, we should revisit. regards, Sean. On 27/06/2018 20:57, Erik Gahlin wrote: On 2018-06-27 21:14, Seán Co

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

Doesn’t jlink require a *fully* modularized application? I.e. no non-module dependencies. The packaging tool should work with all runnable Java applications, not just fully modularized ones. Modularization seems to be a bit of an effort and is one of the main reasons my application(s) are stil

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Thanks for reviewing Xuelei, I do acknowledge that the new TLS v1.3 code has greatly improved the logging output for related operations. I think the main drive with this enhancement is to use the new JFR API to capture interesting events. We can revisit the Logger requirements if there's a str

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

On 20/06/2018 11:08, Pengfei Li wrote: Hi I have tried the patch ( http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/052991.html ) on Ubuntu 18.04 machines (x86_64 & aarch64) with glibc=2.26.1 and build is OK. There's a small issue within the following code in src/java.base/unix/

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Hi Chris, change looks good to me. My NetBeans always complains about tag order if it is not correct, as you  adding the new tag i will suggest you to please fix the tag order as well. /*  * @test  * @bug 6991580 8080108 8133035  * @summary IPv6 Nameservers in resolv.conf throws NumberFormatE

RFR: 8202794: Native Unix code should use readdir rather than readdir_r

Hi Last month, Bernard proposed a patch to fix the OpenJDK build issue with recent versions of glibc. See http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/052991.html But this fix requires to be tested on all POSIX systems before getting integrated. As recently, more and more guys

RE: Draft JEP proposal: JDK-8200758: Packaging Tool

Hi Kevin Thanks for the helpful reply. If you don't mind, I add my feedback here below. My concern is about the options -BserviceHint and -singleton which make javapackager one of the best things since sliced bread. It seems like next to no one is really aware of these valuable

RFR: 8177275: IllegalArgumentException when MH would have too many parameters is not specified for several methods

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8177275 . The jtreg test runs fine with the changes. http://cr.openjdk.java.net/~vtheeyarath/8177275/webrev.02/ CSR : https://bugs.openjdk.java.net/browse/JDK-8205917 Regards Vivek