Re: RFR 8206123 : ArrayDeque created with default constructor can only hold 15 elements

On Tue, Jul 3, 2018 at 9:31 PM, Ivan Gerasimov wrote: > Hi Martin! > > Why did you exclude the case of zero initial capacity? > 96 int initialCapacity = rnd.nextInt(1, 20); > > Well spotted - I was just being lazy - ArrayDeque doesn't handle the case of zero specially. public void

Re: RFR 8206123 : ArrayDeque created with default constructor can only hold 15 elements

Hi Martin! Why did you exclude the case of zero initial capacity? 96 int initialCapacity = rnd.nextInt(1, 20); I think it may make sense to have "static final EMPTY_DEQUE = ArrayDeque(0);" somewhere, and we may want to make sure it doesn't allocate more memory than needed? It's per

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Thank you, Daniel Regards, Chris > On 3 Jul 2018, at 4:46 PM, Daniel Fuchs wrote: > > Hi Chris, > > Looks good to me as well. > > best regards, > > -- daniel > > On 29/06/2018 07:48, Chris Yin wrote: >> Thank you, Vyom >> Regards, >> Chris >>> On 29 Jun 2018, at 11:13 AM, vyom tewari wrote

Re: RFR(JDK12/JAXP/java.xml) 8204329: Java API doc for XMLStreamReader.next() needs to be clarified for the exception thrown when hasNext() method returns false

On 7/3/18, 1:31 AM, Daniel Fuchs wrote: On 02/07/2018 22:55, Joe Wang wrote: Thanks Roger, Lance! Pushed. Oh - well - I was wondering whether there should be a test for StreamReaderDelegate as well - but maybe there's already one? The APIs should have been consistent. Unfortunately thoug

Re: [12] RFR: 8206120: Add test cases for lenient Japanese era parsing

Hi Naoto, Looks fine,  Thanks for adding the test. Roger On 7/2/2018 1:52 PM, Naoto Sato wrote: Hello, Please review the changes to the following issue: https://bugs.openjdk.java.net/browse/JDK-8206120 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8206120/webrev.

Re: RFR 8206123 : ArrayDeque created with default constructor can only hold 15 elements

OK, this thread is officially upgraded to a RFR. http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/ArrayDeque-capacity/index.html On Tue, Jul 3, 2018 at 11:04 AM, Paul Sandoz wrote: > > > On Jul 3, 2018, at 10:42 AM, Martin Buchholz wrote: > > > On Tue, Jul 3, 2018 at 9:53 AM,

Re: RFR 8206123 : ArrayDeque created with default constructor can only hold 15 elements

> On Jul 3, 2018, at 10:42 AM, Martin Buchholz wrote: > > > On Tue, Jul 3, 2018 at 9:53 AM, Paul Sandoz > wrote: > Looks good. Where do you propose to place the test in the OpenJDK repo? > > > http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/

Re: RFR 8206123 : ArrayDeque created with default constructor can only hold 15 elements

On Tue, Jul 3, 2018 at 9:53 AM, Paul Sandoz wrote: > Looks good. Where do you propose to place the test in the OpenJDK repo? > http://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html I hadn't gotten around to a RFR - the test is slightly modified from my initial post.

Re: RFR 8206123 : ArrayDeque created with default constructor can only hold 15 elements

Looks good. Where do you propose to place the test in the OpenJDK repo? Paul. > On Jun 30, 2018, at 10:29 AM, Martin Buchholz wrote: > > Hi Ivan, > > Thanks for finding this bug - I'll take the blame. > > Forgive my pushiness - I'd like to do a friendly takeover of this. As > penance I ported

Re: [11] Review Request: 8204603: Short week days, NaN value and timezone name are inconsistent between CLDR and Java in zh_CN, zh_TW locales.

Looks good to me. Naoto On 7/3/18 2:58 AM, Rachna Goel wrote: Hi, Kindly review fix to JDK-8204603. Bug: https://bugs.openjdk.java.net/browse/JDK-8204603 Fix: http://cr.openjdk.java.net/~rgoel/JDK-8204603/webrev.04/ This is a regression caused by JDK-8179071, where locale data is getting i

[11] Review Request: 8204603: Short week days, NaN value and timezone name are inconsistent between CLDR and Java in zh_CN, zh_TW locales.

Hi, Kindly review fix to JDK-8204603. Bug: https://bugs.openjdk.java.net/browse/JDK-8204603 Fix: http://cr.openjdk.java.net/~rgoel/JDK-8204603/webrev.04/ This is a regression caused by JDK-8179071, where locale data is getting incorrectly retrieved (not following languageAliases of CLDR) for

Re: ClassLoader.getResources() only returns locations in a patch when using the module path and --patch-module

On 03/07/2018 09:28, Andy Wilkinson wrote: I recently raised a JDK issue [1] which, when triaged, was closed as not an issue. I think is incorrect and was advised by Dalibor Topic [2] to email this list so here I am. In a nutshell, it appears that when using the module path and --patch-module, a

Re: [JDK 11] RFR 8187069: The case auto failed with the "java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest" exception

Hi Chris, Looks good to me as well. best regards, -- daniel On 29/06/2018 07:48, Chris Yin wrote: Thank you, Vyom Regards, Chris On 29 Jun 2018, at 11:13 AM, vyom tewari wrote: looks good to me. Vyom On Friday 29 June 2018 06:22 AM, Chris Yin wrote: Hi, Vyom Sure, fixed the tag order

Re: RFR(JDK12/JAXP/java.xml) 8204329: Java API doc for XMLStreamReader.next() needs to be clarified for the exception thrown when hasNext() method returns false

On 02/07/2018 22:55, Joe Wang wrote: Thanks Roger, Lance!  Pushed. Oh - well - I was wondering whether there should be a test for StreamReaderDelegate as well - but maybe there's already one? https://docs.oracle.com/javase/10/docs/api/javax/xml/stream/util/StreamReaderDelegate.html best regar

ClassLoader.getResources() only returns locations in a patch when using the module path and --patch-module

I recently raised a JDK issue [1] which, when triaged, was closed as not an issue. I think is incorrect and was advised by Dalibor Topic [2] to email this list so here I am. In a nutshell, it appears that when using the module path and --patch-module, a call to ClassLoader.getResources() will only