Hi Ivan,
Changes looks good to me, nice cleanup.
Thanks,
Vyom
On Wednesday 11 July 2018 09:45 PM, Ivan Gerasimov wrote:
Hello!
File src/java.base/windows/native/libjava/io_util_md.c
In the function pathToNTPath(), memory is allocated with malloc()
within a block of macros WITH_UNICODE_STR
Since support for services/daemons was already in javapackager, why does this
have to be a stretch goal? Isn’t it mostly already done?
I would like to see this in the initial implementation. It is something I’m
currently using via javapackager.
I’m still trying to figure out the best strategy f
Hi,
Please review this fix for 11:
http://cr.openjdk.java.net/~psandoz/jdk/JDK-8207027-lookup-access-class-array-type/webrev/
The fix removes an old and now incorrect assert statement. This statement
causes MethodHandles.Lookup.accessClass to fail when system assertions are
enabled and an a
We will likely be able to deliver the .exe installer (with its
dependency on Inno Setup).
As for the service bundler, this will be a "nice to have" (a stretch
goal) for this version, but isn't on the list of committed features.
Alexsei might be able to comment further on how much work it would
Hi Naoto,
Looks fine,
Roger
On 7/11/2018 1:42 PM, naoto.s...@oracle.com wrote:
Hello,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8206980
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8206980/webrev.00/
CLDR time zone nam
- Mail original -
> De: "John Rose"
> À: "Peter Levart"
> Cc: "Remi Forax" , "core-libs-dev"
>
> Envoyé: Mercredi 11 Juillet 2018 21:07:37
> Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not
> support default methods
> On Jul 11, 2018, at 9:32 AM, Peter Levart
- Mail original -
> De: "Peter Levart"
> À: "Remi Forax"
> Cc: "Paul Sandoz" , "core-libs-dev"
>
> Envoyé: Mercredi 11 Juillet 2018 18:32:13
> Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not
> support default methods
> Sorry Paul for hijacking the thread, ju
On Jul 11, 2018, at 9:32 AM, Peter Levart wrote:
>
> Sorry Paul for hijacking the thread, just answering to Remi ...
>
> On 07/11/2018 05:31 PM, Remi Forax wrote:
>> - Mail original -
>>> De: "Peter Levart"
>>> À: "Paul Sandoz" , "core-libs-dev"
>>>
>>> Envoyé: Mercredi 11 Juillet 201
Hi Peter,
> On Jul 11, 2018, at 8:15 AM, Peter Levart wrote:
>
> Hi Paul,
>
> The patch looks ok.
Thanks.
> I hope IMPL_LOOKUP has access to all methods (even if located in
> package-private interfaces and/or in concealed packages of modules)?
>
I think it should be ok, because IMPL_LOOKU
Hi Joe,
The updates like fine
> On Jul 10, 2018, at 11:10 PM, Joe Wang wrote:
>
>
>
> On 7/10/18, 4:39 PM, Jonathan Gibbons wrote:
>>
>>
>>
>> On 7/10/18 4:27 PM, Joe Wang wrote:
>>> Hi,
>>>
>>> Please review a javadoc fix for a couple of incorrect references to the
>>> javax.xml.stream p
Hello,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8206980
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8206980/webrev.00/
CLDR time zone names in "en" bundle are expected to be pre-populated for
performance. This is not the
On 07/11/2018 08:52 AM, Alan Bateman wrote:
>
Happy to see this disabled as it has always been problematic. The patch
looks okay although you don't of couse need to set the initial values to
false.
OK, yeah, I'll omit that.
Thanks, Alan and Brian.
-Brent
+1
Brian
On Jul 11, 2018, at 8:52 AM, Alan Bateman wrote:
> Happy to see this disabled as it has always been problematic. The patch looks
> okay although you don't of couse need to set the initial values to false.
On Jul 10, 2018, at 2:02 PM, Brent Christian wrote:
> --- a/src/java.base/sha
Sorry Paul for hijacking the thread, just answering to Remi ...
On 07/11/2018 05:31 PM, Remi Forax wrote:
- Mail original -
De: "Peter Levart"
À: "Paul Sandoz" , "core-libs-dev"
Envoyé: Mercredi 11 Juillet 2018 17:15:09
Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance d
Hello!
File src/java.base/windows/native/libjava/io_util_md.c
In the function pathToNTPath(), memory is allocated with malloc() within
a block of macros WITH_UNICODE_STRING / END_UNICODE_STRING.
In an unlikely event of malloc() failure, the function returns, failing
to release the string arr
On 10/07/2018 22:02, Brent Christian wrote:
Hi,
Please review this change to disable the file canonicalization cache
by default.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8207005
From the bug report:
"The file canonicalization cache was added back in JDK 1.4.2 in order
to improve startu
- Mail original -
> De: "Peter Levart"
> À: "Paul Sandoz" , "core-libs-dev"
>
> Envoyé: Mercredi 11 Juillet 2018 17:15:09
> Objet: Re: RFR 8206955 MethodHandleProxies.asInterfaceInstance does not
> support default methods
> Hi Paul,
>
> The patch looks ok. I hope IMPL_LOOKUP has acces
Hi Paul,
The patch looks ok. I hope IMPL_LOOKUP has access to all methods (even
if located in package-private interfaces and/or in concealed packages of
modules)?
Just a thought... Would it be possible to implement this API in terms of
LambdaMetafactory ?
Regards, Peter
On 07/11/2018 12:
Hi All,
-- Summary:
When calling "ResourceBundle.getBundle(String, Locale, ClassLoader)" on
JDK8, the ClassLoader can get GC'd before we're finished with it.
This can result in us getting the wrong result back, like if we asked for
"Stuff" with the locale "fr, CA" and got back "Stuff_fr.class
On 10/07/2018 10:53, Baesken, Matthias wrote:
Hi Alan, thanks for commenting on this .
Jaikiran mentioned that printing just the jar file name and not file with
path might be okay :
I am not a reviewer and neither do I have enough knowledge about whether
jar/file _names_ are considered
20 matches
Mail list logo
