[12] RFR: 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters

Hi, Please review the fix for JDK-8193444 Bug: https://bugs.openjdk.java.net/browse/JDK-8193444 Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/ Cause: If a format pattern contains a sequence of over 256 non-ASCII unicode characters, the length field overflows as it is stored as

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

Please have a review to new webrev as below, some code refactoring on lib parts and enhanced DNSServer to handle retry request which will make the tests more stable, thanks http://cr.openjdk.java.net/~xyin/8198882/webrev.01/ Regards, Chris

Re: [11] RFR 8207027 Lookup.accessClass fails for an array type in the same package when assertions are enabled

+1 /Claes On 2018-07-12 02:01, Paul Sandoz wrote: Hi, Please review this fix for 11: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8207027-lookup-access-class-array-type/webrev/ The fix removes an old and now incorrect assert statement. This statement causes MethodHandles.Lookup.accessCla

Re: [11] RFR 8207027 Lookup.accessClass fails for an array type in the same package when assertions are enabled

Looks fine. Mandy On 7/11/18 5:01 PM, Paul Sandoz wrote: Hi, Please review this fix for 11: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8207027-lookup-access-class-array-type/webrev/ The fix removes an old and now incorrect assert statement. This statement causes MethodHandles.Lookup.access

Re: RFR 8207060 : Memory leak when malloc fails within WITH_UNICODE_STRING block

Thanks Vyom for reviewing! I think I only need an approval from an official jdk reviewer to commit. With kind regards, Ivan On 7/11/18 11:40 PM, vyom tewari wrote: Hi Ivan, Changes looks good to me, nice cleanup. Thanks, Vyom On Wednesday 11 July 2018 09:45 PM, Ivan Gerasimov wrote: He

Re: [12] RFR: 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters

Looks good to me. Naoto On 7/12/18 1:26 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8193444 Bug: https://bugs.openjdk.java.net/browse/JDK-8193444 Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/ Cause: If a format pattern contains a sequence of over 256 non-ASCII

[11] RFR: 8207152: Placeholder for Japanese new era should be two characters

Hello, Please review the changes to the following issue: https://bugs.openjdk.java.net/browse/JDK-8207152 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8207152/webrev.00/ The fix is to simply change the name from "新元号" to "元号". From the API standpoint, there is no restric

Re: RFR 8207060 : Memory leak when malloc fails within WITH_UNICODE_STRING block

Looks fine Ivan, Thanks, Roger On 7/12/2018 2:40 AM, vyom tewari wrote: Hi Ivan, Changes looks good to me, nice cleanup. Thanks, Vyom On Wednesday 11 July 2018 09:45 PM, Ivan Gerasimov wrote: Hello! File src/java.base/windows/native/libjava/io_util_md.c In the function pathToNTPath(),

Re: [12] RFR: 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters

+1 On 7/12/2018 1:28 PM, Naoto Sato wrote: Looks good to me. Naoto On 7/12/18 1:26 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8193444 Bug: https://bugs.openjdk.java.net/browse/JDK-8193444 Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/ Cause: If a format patte

Re: [11] RFR: 8207152: Placeholder for Japanese new era should be two characters

Looks fine Roger On 7/12/2018 1:51 PM, Naoto Sato wrote: Hello, Please review the changes to the following issue: https://bugs.openjdk.java.net/browse/JDK-8207152 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8207152/webrev.00/ The fix is to simply change the name from

Re: RFR 8207060 : Memory leak when malloc fails within WITH_UNICODE_STRING block

Thanks Vyom and Roger for reviewing! On 7/12/18 11:01 AM, Roger Riggs wrote: Looks fine Ivan, Thanks, Roger On 7/12/2018 2:40 AM, vyom tewari wrote: Hi Ivan, Changes looks good to me, nice cleanup. Thanks, Vyom On Wednesday 11 July 2018 09:45 PM, Ivan Gerasimov wrote: Hello! File src

Re: RFR(JDK12/JAXP/java.xml) 8194680: StartElement#getAttributes and getNamespaces refer to incorrect package

Thanks Lance, and Jon! -Joe On 7/11/18, 10:49 AM, Lance Andersen wrote: Hi Joe, The updates like fine On Jul 10, 2018, at 11:10 PM, Joe Wang > wrote: On 7/10/18, 4:39 PM, Jonathan Gibbons wrote: On 7/10/18 4:27 PM, Joe Wang wrote: Hi, Please review a ja

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

Hi Chris, Thanks for doing this overall looks good to me, few minor comments. 1->  DNSTestUtils.java, please start the server first and then set the "TEST_DNS_SERVER_THREAD". This will not make much difference but we will avoid setting "TEST_DNS_SERVER_THREAD" env variable if server fails to

Re: RFR 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/

Hi, Vyom Thank you for the review and comments, update webrev as below and comment inline webrev: http://cr.openjdk.java.net/~xyin/8198882/webrev.02/ > On 13 Jul 2018, at 1:46 PM, vyom tewari wrote: > > Hi Chris, > > Thanks for doing thi