8202794: Native Unix code should use readdir rather than readdir_r

2018-07-16 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8202794 Continues thread [1] with subject line updated to match the issue summary. Part of this general problem was addressed in [2]. The patch is in effect that proposed in thread [1] less the changes in [2]: http://cr.openjdk.java.net/~bpb/8202794/webr

Re: RFR 8207016 : [win] Avoid redundant native memory allocation in getFinalPath()

2018-07-16 Thread Ivan Gerasimov
Thank you Alan for review! On 7/16/18 5:05 AM, Alan Bateman wrote: On 11/07/2018 03:33, Ivan Gerasimov wrote: Hello! File src/java.base/windows/native/libjava/WinNTFileSystem_md.c The function getFinalPath() is wrapper for GetFinalPathNameByHandleW(), which is used to resolve the symlinks on

Re: RFR: JDK-8207243: Fix translation filtering to also support zh_HK and zh_TW

2018-07-16 Thread Tim Bell
Erik: The zh_HK translation is mostly generated by copying the zh_TW translation. Because of this, there are different types of rules defined for generating those and the recently added filtering mechanism won't work for it. This patch fixes that as well as adds those translations to the Oracle

RFR: JDK-8207243: Fix translation filtering to also support zh_HK and zh_TW

2018-07-16 Thread Erik Joelsson
The zh_HK translation is mostly generated by copying the zh_TW translation. Because of this, there are different types of rules defined for generating those and the recently added filtering mechanism won't work for it. This patch fixes that as well as adds those translations to the Oracle filte

Re: RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

2018-07-16 Thread Adam Farley8
Hi Folks, > Zhengyu Gu wrote on 06/06/2018 01:58:18: > From: Zhengyu Gu > To: "Thomas Stüfe" , Adam Farley8 > > Cc: "hotspot-...@openjdk.java.net developers" d...@openjdk.java.net>, core-libs-dev > Date: 06/06/2018 01:58 > Subject: Re: RFR Bug-pending: Enable Hotspot to Track Native Memory

Re: RFR (Unraised): JDK8 ResourceBundle vulnerable to GC

2018-07-16 Thread Peter Levart
On 07/16/2018 05:13 PM, Adam Farley8 wrote: As for the JDK9+ issue, I believe that has already been solved. See the line at the end of the Module-Module-String-Locale-Control getBundleImpl, where it says: Reference.reachabilityFence(module); You're right, Adam. I missed that. Regards, Pete

Re: RFR (Unraised): JDK8 ResourceBundle vulnerable to GC

2018-07-16 Thread Adam Farley8
> Alan Bateman wrote on 16/07/2018 15:00:16: > From: Alan Bateman > To: Peter Levart , Adam Farley8 > , core-libs-dev > Date: 16/07/2018 14:59 > Subject: Re: RFR (Unraised): JDK8 ResourceBundle vulnerable to GC > > On 16/07/2018 14:12, Peter Levart wrote: > > > > Checking the differences show

Re: RFR (Unraised): JDK8 ResourceBundle vulnerable to GC

2018-07-16 Thread Alan Bateman
On 16/07/2018 14:12, Peter Levart wrote: Checking the differences shows that instead of WeakReference, CacheKey uses two WeakReference instead in JDK 9+. One is the caller module and the other is the module of the bundle (unnamed module if ClassLoader is used to search for the bundle). The c

RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-07-16 Thread Baesken, Matthias
Hello, after latest comments from Alan and JaikiranI created a new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.2/ The jar file path is now printed in case jdk.includeInExceptions contains jarpath (this approach is "borrowed" from the enhanced socket e

Re: RFR (Unraised): JDK8 ResourceBundle vulnerable to GC

2018-07-16 Thread Peter Levart
Hi, On 07/16/2018 02:10 PM, Alan Bateman wrote: On 11/07/2018 14:27, Adam Farley8 wrote: Hi All, -- Summary: When calling "ResourceBundle.getBundle(String, Locale, ClassLoader)" on JDK8, the ClassLoader can get GC'd before we're finished with it. This can result in us getting the wrong resul

Re: RFR (Unraised): JDK8 ResourceBundle vulnerable to GC

2018-07-16 Thread Alan Bateman
On 11/07/2018 14:27, Adam Farley8 wrote: Hi All, -- Summary: When calling "ResourceBundle.getBundle(String, Locale, ClassLoader)" on JDK8, the ClassLoader can get GC'd before we're finished with it. This can result in us getting the wrong result back, like if we asked for "Stuff" with the loca

Re: RFR 8207016 : [win] Avoid redundant native memory allocation in getFinalPath()

2018-07-16 Thread Alan Bateman
On 11/07/2018 03:33, Ivan Gerasimov wrote: Hello! File src/java.base/windows/native/libjava/WinNTFileSystem_md.c The function getFinalPath() is wrapper for GetFinalPathNameByHandleW(), which is used to resolve the symlinks on Windows. If the resulting string begins with a prefix "\\?\" or "\