Re: Draft JEP proposal: JDK-8200758: Packaging Tool

2018-07-25 Thread Bernd Eckenfels
Hello, Will there be: - support for displaying and asking for acceptance of license text - asking for target directory (installing outside of programfiles) - starting optional post-Installation class - menu entries - user vs. System wide Installation (on windows) - the new launchers also be availa

Re: Draft JEP proposal: JDK-8200758: Packaging Tool

2018-07-25 Thread Kevin Rushforth
Thank you to all who provided feedback. I have updated the draft JEP [1], and I think I have incorporated most of the feedback I received. Specifically, I have reorganized and reworded a few things for clarity, added '.exe' and '.app in a .dmg' native package format to the list of features, and

Re: [11]RFR:JDK-8206965: java/util/TimeZone/Bug8149452.java failed on de_DE and ja_JP locale.

2018-07-25 Thread naoto . sato
Looks good. Naoto On 7/25/18 10:03 AM, Rachna Goel wrote: Hi, Kindly review fix for JDK-8206965. Bug: https://bugs.openjdk.java.net/browse/JDK-8206965 patch: http://cr.openjdk.java.net/~rgoel/JDK-8206965/webrev.06/ This is a regression caused by JDK-8181157 due to which for some locales,  t

[11]RFR:JDK-8206965: java/util/TimeZone/Bug8149452.java failed on de_DE and ja_JP locale.

2018-07-25 Thread Rachna Goel
Hi, Kindly review fix for JDK-8206965. Bug: https://bugs.openjdk.java.net/browse/JDK-8206965 patch: http://cr.openjdk.java.net/~rgoel/JDK-8206965/webrev.06/ This is a regression caused by JDK-8181157 due to which for some locales, timezone display names were not getting generated. Generating

Re: Prototype of jpackager in jdk/sandbox [was: Draft JEP proposal: JDK-8200758: Packaging Tool]

2018-07-25 Thread Alexey Semenyuk
Jörg, I don't think it will be very much work to bring service bundler code from JFX packager into OpenJDK jpackager. Though I can't give you estimates on amount of work needed to be done for this at the moment. - Alexey On 7/23/2018 7:47 AM, Buchberger, Joerg wrote: Thanks for the insight.

Re: Please review EdDSA API

2018-07-25 Thread Adam Petcher
+core-libs-dev for additional API expertise. On 7/25/2018 10:29 AM, Adam Petcher wrote: The draft CSR[1] for the EdDSA API[2] is ready for review. Please take a look and send me any feedback you may have. Here are a few high-level notes to explain the API: 1) Where possible, this API is simi

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

2018-07-25 Thread Andrew Dinn
Round 2 --- I have updated the JEP and uploaded a revised webrev in the light of existing feedback JEP JIRA: https://bugs.openjdk.java.net/browse/JDK-8207851 Formatted JEP: http://openjdk.java.net/jeps/8207851 New webrev: http://cr.openjdk.java.net/~adinn/pmem/webrev.02/ I would welco

Re: Add x-IBM-1129 charset

2018-07-25 Thread Nasser Ebrahim
Hello, I had kept aside this discussion for a while as there is a parallel discussion on whether to move the IBM charsets on openjdk to a different location or outside JDK[ http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-July/054248.html ]. From that discussion, it is confirmed that t

[12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

2018-07-25 Thread Chris Yin
Please review the changes to add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/ in OpenJDK, due to known issue 7164518, PortUnreachable.java will be problem list for 'macosx-all', thanks bug: https://bugs.openjdk.java.net/browse/JDK-8200151 webr