Ping! Could you please review and sponsor this changeset?
I updated version tag from since 11 to since 12:
http://cr.openjdk.java.net/~tvaleev/webrev/8205461/r2/
Thanks in advance!
With best regards,
Tagir Valeev.
On Thu, Jun 21, 2018 at 11:33 AM Tagir Valeev wrote:
> Please review and
Got it, thank you Vyom, and I added some javadoc to LookupFactoryBase (per
comments from another thread) in new webrev as below
http://cr.openjdk.java.net/~xyin/8208483/webrev.02/
Thanks & Regards,
Chris
> On 6 Aug 2018, at 8:38 PM, vyom tewari wrote:
>
>
>
> On Monday 06 August 2018 03:02
Hi, Roger
Thanks a lot for your review and comments, inline and updated webrev as below,
thanks
http://cr.openjdk.java.net/~xyin/8208279/webrev.03/
> On 6 Aug 2018, at 10:58 PM, Roger Riggs wrote:
>
> Hi Chris,
>
> EnvTestBase.java: The class and each of the methods should have javadoc
Hi.
Please review the following minor change to update the java.se
module summary.
8201394: Update java.se module summary to reflect removal of java.se.ee
module
https://bugs.openjdk.java.net/browse/JDK-8201394
In JDK 10, we had the following module summaries:
java.base - Defines
Hi Max,
I can give you some guidance but no quick fixes ...
On 7/08/2018 4:21 AM, mr rupplin wrote:
Three problems that I run into when running the 'make jdk' after minor work on
the System.java class for JNI and custom JDK:
java/lang/memory/GroupListener.java:111: warning: [rawtypes] found
Hi Sergey,
On 8/6/2018 3:39 PM, Sergey Bylokhov wrote:
Hi, Joe.
On 06/08/2018 14:30, joe darcy wrote:
Even if currently less commonly used, I think "ineffectual" better
captures the intention of what I want to convey in the comment than
"ineffective."
Can you please clarify this: what does
Hi, Joe.
On 06/08/2018 14:30, joe darcy wrote:
Even if currently less commonly used, I think "ineffectual" better
captures the intention of what I want to convey in the comment than
"ineffective."
Can you please clarify this: what does it mean "ineffectual" in this
context? why we need to
There was extra space before the star in "by reflection API” line. I have
removed it.
- * by reflection API
+ * by reflection API
> On Aug 6, 2018, at 3:19 PM, Jonathan Gibbons
> wrote:
>
> You might check the indentation of the modified lines.
>
> -- Jon
>
> On 08/06/2018
You might check the indentation of the modified lines.
-- Jon
On 08/06/2018 03:10 PM, mandy chung wrote:
+1
Mandy
On 8/6/18 1:51 PM, Alexandre (Shura) Iline wrote:
Hi,
Please taka a quick look on this fix:
$ hg diff
---
+1
> On Aug 6, 2018, at 3:11 PM, joe darcy wrote:
>
> Hello,
>
> Various interfaces in the JDK extend Serializable and declare
> serialVersionUID fields. Such fields are ineffectual and
> @SuppressWarnings("serial") should be applied to such fields to suppress
> future planned serial lint
+1
Mandy
On 8/6/18 1:51 PM, Alexandre (Shura) Iline wrote:
Hi,
Please taka a quick look on this fix:
$ hg diff
--- a/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
+++ b/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
@@ -25,8 +25,9 @@
* @test
Hi Roger,
Even if currently less commonly used, I think "ineffectual" better
captures the intention of what I want to convey in the comment than
"ineffective."
Thanks all for the reviews; cheers,
-Joe
On 8/6/2018 12:44 PM, Roger Riggs wrote:
Hi Joe,
Looks fine. I would probably have
Hi,
Please taka a quick look on this fix:
$ hg diff
--- a/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
+++ b/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
@@ -25,8 +25,9 @@
* @test
* @bug 8202113
* @summary Test the caller class loader is
Looks fine to me.
--Sean
On 8/6/18 3:11 PM, joe darcy wrote:
Hello,
Various interfaces in the JDK extend Serializable and declare
serialVersionUID fields. Such fields are ineffectual and
@SuppressWarnings("serial") should be applied to such fields to suppress
future planned serial lint
Hi Joe,
Looks fine. I would probably have used "ineffective" instead of
"ineffectual".
(Googling "define ineffective" and "define ineffectual" shows an
interesting graph of
the use of the term with ineffective growing and ineffectual dropping in
use.
Look under the more tag)
Regards,
Hi Joe,
Looks fine.
Brian
On Aug 6, 2018, at 12:11 PM, joe darcy wrote:
> Various interfaces in the JDK extend Serializable and declare
> serialVersionUID fields. Such fields are ineffectual and
> @SuppressWarnings("serial") should be applied to such fields to suppress
> future planned
After further evaluation of the new jdk.includeInExceptions security
property originally introduced in JDK-8204233 [1] and further
generalized in JDK-8207846 [2], I felt that a stronger warning should be
added to the description of the property alerting the user to the
potential risks of
Hello,
Various interfaces in the JDK extend Serializable and declare
serialVersionUID fields. Such fields are ineffectual and
@SuppressWarnings("serial") should be applied to such fields to suppress
future planned serial lint checks (JDK-8202056).
Most of the affected files are in the
On 06/08/2018 19:13, Paul Sandoz wrote:
Thanks, i uploaded a new webrev in place that uses a similar technique to some
stuff in j.u.concurrent tests.
The update looks good to me.
-Alan
That is alot of reading. I will look into it. We would build some according
to the frameworks' ability to handle that control area.
Thank you. I will be in touch.
Max R.
Sr. Software Lead
From: Claes Redestad
Sent: Monday, August 6, 2018 2:20:38 PM
To:
On 05/08/2018 20:54, Albert Schimpf wrote:
Hi,
I stumbled upon some strange behavior when using the new Java httpclient.
Can you bring this to net-dev (as that is where the issues with the new
HTTP client are being discussed)?
-Alan
Three problems that I run into when running the 'make jdk' after minor work on
the System.java class for JNI and custom JDK:
java/lang/memory/GroupListener.java:111: warning: [rawtypes] found raw type:
Class
Class basetype = null;
-- --
java/lang/memory/GroupListener.java:7: error:
Hi Max,
On 2018-08-06 17:55, mr rupplin wrote:
Clases, Hello.
Firstly thank you for replying. Of course our goal is to show the
strengths in the OpenJDK.
Some weeks ago we were working with the ClassFileTransformer as an
initial hook for a modest databasing proposal. We found it to
Thanks, i uploaded a new webrev in place that uses a similar technique to some
stuff in j.u.concurrent tests.
Paul.
> On Aug 5, 2018, at 11:59 AM, Alan Bateman wrote:
>
> On 03/08/2018 23:15, Paul Sandoz wrote:
>> Got caught up with JVMLS this week…
>>
>> I searched but could not find a
On 8/6/18 1:41 PM, Vladimir Kozlov wrote:
On 8/6/18 10:25 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:14 PM, Vladimir Kozlov wrote:
Okay, I read more about what happened. I think compiler tests should
be modified as David Holmes suggested (use /othervm):
"Tests that don't manage their threads
On 8/6/18 1:52 PM, Vladimir Kozlov wrote:
On 8/6/18 10:43 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:41 PM, Vladimir Kozlov wrote:
On 8/6/18 10:25 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:14 PM, Vladimir Kozlov wrote:
Okay, I read more about what happened. I think compiler tests
should be
On 8/6/18 10:43 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:41 PM, Vladimir Kozlov wrote:
On 8/6/18 10:25 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:14 PM, Vladimir Kozlov wrote:
Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use
On 8/6/18 1:41 PM, Vladimir Kozlov wrote:
On 8/6/18 10:25 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:14 PM, Vladimir Kozlov wrote:
Okay, I read more about what happened. I think compiler tests should
be modified as David Holmes suggested (use /othervm):
"Tests that don't manage their threads
On 8/6/18 10:25 AM, Daniel D. Daugherty wrote:
On 8/6/18 1:14 PM, Vladimir Kozlov wrote:
Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use
/othervm):
"Tests that don't manage their threads properly (ie ensure they terminate at test
On 8/6/18 1:14 PM, Vladimir Kozlov wrote:
Okay, I read more about what happened. I think compiler tests should
be modified as David Holmes suggested (use /othervm):
"Tests that don't manage their threads properly (ie ensure they
terminate at test end) should be run in othervm mode. jtreg
Okay, I read more about what happened. I think compiler tests should be
modified as David Holmes suggested (use /othervm):
"Tests that don't manage their threads properly (ie ensure they terminate at test end) should be run in othervm mode.
jtreg can't know how to make these threads
On 8/6/18 12:59 PM, Vladimir Kozlov wrote:
Hi Dan,
8208690 lists only next 2 tests:
sun/net/www/http/HttpClient/MultiThreadTest.java (4 instances)
java/net/Socket/LingerTest.java (2 instances)
Why you also added 2 compiler tests?
If you look at all the sightings in the bug report, you'll
Hi Dan,
8208690 lists only next 2 tests:
sun/net/www/http/HttpClient/MultiThreadTest.java (4 instances)
java/net/Socket/LingerTest.java (2 instances)
Why you also added 2 compiler tests?
Thanks,
Vladimir
On 8/6/18 9:49 AM, Daniel D. Daugherty wrote:
Greetings,
I'm in the process of
Ted,
I just use --disable-warnings-as-errors in bash configure command to build jdk
10/11 on Ubuntu 18.
--
Thanks,
Pengfei
>
> Assuming I want to build JDK 8/9/10/11 (for research and spelunking
> purposes), what's the best way to do that if the changes aren't going to be
> backported? Turn
Assuming I want to build JDK 8/9/10/11 (for research and spelunking purposes),
what's the best way to do that if the changes aren't going to be backported?
Turn off the warnings-as-errors (and what's the best way to do that), or
somehow downgrade glibc (on my Ubuntu 18 image)? I could use
And forgot to lead with: Thanks, Pengfei! That helps a great deal.
Ted Neward
Technologist and Leader
T: @tedneward | M: (425) 647-4526
http://www.newardassociates.com
-Original Message-
From: Pengfei Li
Sent: Sunday, August 5, 2018 11:26 PM
To: t...@tedneward.com; 'Alan Bateman' ;
Giving that a spin now; thanks!
Ted Neward
Technologist and Leader
T: @tedneward | M: (425) 647-4526
http://www.newardassociates.com
-Original Message-
From: Severin Gehwolf
Sent: Monday, August 6, 2018 1:46 AM
To: t...@tedneward.com; 'Pengfei Li' ; 'Alan Bateman'
;
Hey, all; did this get resolved? I'm still getting this error in
pulled-yesterday clones of jdk8u and jdk9 and jdk10. I would prefer not to
make local changes (mostly I want to build debug builds so I can spelunk the
JVM bits), but if this isn't going to roll out fairly shortly I'll disable
Hi,
I stumbled upon some strange behavior when using the new Java httpclient.
The issue is very simple to reproduce. Send a GET request via a known
bad proxy:
HttpClient client = HttpClient.newBuilder()
.proxy(ProxySelector.of(BAD_PROXY))
.build();
Well, that works for JDK 10, it seems... (building now...) but is there a
similar way to disable warnings for JDK 8 and 9? Some combination of
CFLAGS/CPPFLAGS, perhaps? I'd really like to be able to build 8 and 9;
particularly 8, since that's what my current employer is still using. :-)
Ted
Greetings,
I'm in the process of reducing the noise in the JDK12 CI so
I need a single (R)eviewer for the following fix:
JDK-8209018 ProblemList tests affected by JDK-8208690
https://bugs.openjdk.java.net/browse/JDK-8209018
Here's the diff:
$ hg diff
diff -r c00451b67854
Clases, Hello.
Firstly thank you for replying. Of course our goal is to show the strengths in
the OpenJDK.
Some weeks ago we were working with the ClassFileTransformer as an initial hook
for a modest databasing proposal. We found it to be a dead end.
Of course the company has greenlit
Hi Chris,
EnvTestBase.java: The class and each of the methods should have javadoc
with a descriptive comment
to make the test construction easier to understand for future
maintenance especially since
they are shared/overridden and used by many of the test cases.
For example,
On 07/06/2018 02:23 PM, Nasser Ebrahim wrote:
Hi Florian,
Thank you for your response. iconv is platform dependent and not good for
the platform agnostic nature of Java. Also, many charsets in Java are not
available across platforms. I believe Java decided to have its own
charsets due to those
On Monday 06 August 2018 03:02 PM, Chris Yin wrote:
Hi, Vyom
Many thanks for your review and comments, inline and updated webrev as below,
thanks
http://cr.openjdk.java.net/~xyin/8208483/webrev.01/
On 6 Aug 2018, at 4:12 PM, vyom tewari wrote:
Hi Chris,
1-> DirAFactory.java,
Hi all,
restarting discussion about JDK-8181098,
java.io.File has several severe issues so we should alert users to migrate to
use java.nio.file.[Path|Files] ASAP using the deprecation mechanism (obviously
not for removal).
The usual gotchas
- File used string name which may do not map
On 31/07/2018 07:16, Felix Yang wrote:
Hi all,
please review a patch to improve the checking on the settings.
Originally it will throw NPE, if specified path is invalid.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8194230
Webrev:
Hi, Vyom
Many thanks for your review and comments, inline and updated webrev as below,
thanks
http://cr.openjdk.java.net/~xyin/8208483/webrev.01/
> On 6 Aug 2018, at 4:12 PM, vyom tewari wrote:
>
> Hi Chris,
>
> 1-> DirAFactory.java, "getIbjectInstance" returns "null" if it fails to
>
On 25/07/2018 12:44, Andrew Dinn wrote:
Round 2
---
I have updated the JEP and uploaded a revised webrev in the light of
existing feedback
JEP JIRA: https://bugs.openjdk.java.net/browse/JDK-8207851
Formatted JEP: http://openjdk.java.net/jeps/8207851
New webrev:
On Mon, 2018-08-06 at 01:32 -0700, t...@tedneward.com wrote:
> I'd really like to be able to build 8 and 9; particularly 8, since
> that's what my current employer is still using. :-)
For JDK 8 we have to use:
$ bash configure ...
$ make WARNINGS_ARE_ERRORS="" \
SCTP_WERROR= \
...
Hi Chris,
1-> DirAFactory.java, "getIbjectInstance" returns "null" if it fails to
construct object. I will suggest you to throw some "RuntimeException"
instead returning null. If you return null then caller of
"getObjectInstance" had to check for null and it will end in lots of
boilerplate
Thank you, Vyom
Regards,
Chris
> On 6 Aug 2018, at 2:02 PM, vyom tewari wrote:
>
> Hi Chris,
>
> Latest webrev looks good to me.
>
> Thanks,
>
> Vyom
>
>
> On Friday 03 August 2018 02:46 PM, Chris Yin wrote:
>> Hi, Vyom
>>
>> Thank a lot for your review and comments, inline and update
On 2018-08-04 14:29, mr rupplin wrote:
Any help?
I think it would help if you described what you're trying to achieve,
rather than the current stumbling block.[0]
Reading between the lines then it seems you're trying to add some kind
of adhoc allocation profiling, so I wonder if you've
Hi Chris,
Latest webrev looks good to me.
Thanks,
Vyom
On Friday 03 August 2018 02:46 PM, Chris Yin wrote:
Hi, Vyom
Thank a lot for your review and comments, inline and update new webrev as below
http://cr.openjdk.java.net/~xyin/8208279/webrev.02/
On 3 Aug 2018, at 3:45 PM, vyom tewari
54 matches
Mail list logo
