Re: Javac Compiler

$ find . -name main | grep javac ./src/jdk.compiler/share/classes/com/sun/tools/javac/main ./test/langtools/tools/javac/main On 8/23/18 6:10 PM, mr rupplin wrote: com.sun.tools.javac.main.Main com.sun.tools.javac.main.Main compiler = new com.sun.tools.javac.main.Main("javac"

Re: (XS) java.logging Level.java minor cleanups

Do you find the class files containing the bridge methods. I checked my JDK build and the Level and KnownLevel classes are in the same nest as I expect. Level is the nest host of KnownLevel which can access Level.name and other fields via getfield. I also skimmed through the class file and doesn

Interpreter Function Handler

jdk9/hotspot/src/share/vm/interpreter/interpreterRuntime.cpp Where does Java handle pass by value? Where can I see that implementation? Great. Thank you.

Javac Compiler

com.sun.tools.javac.main.Main com.sun.tools.javac.main.Main compiler = new com.sun.tools.javac.main.Main("javac"); return compiler.compile(args).exitCode; I see this down in jdk.compiler. The com.sun.tools.javac.main folder doesn't exist.

Re: (XS) java.logging Level.java minor cleanups

Hello Mandy, the fields Level#name, Level#value and resourceBundleName accessed from KnownLevel inner class are private and therefore an synthetic accessor will be used. Eclipse warns about this. But, Looking at it again, it is not only a non-issue with JEP 181 in Java 11, it is also hard to f

Re: (XS) java.logging Level.java minor cleanups

On 8/23/18 2:49 PM, Bernd Eckenfels wrote: Did you had any opinion on the synthetic accessors as well? : BTW: I get a synthetic Accessor warning on l.name/value, is this what nestmates will resolve – is it worth adjusting the modifiers for>> those fields anyway? What warning message d

Re: RFR(JDK12/JAXP/java.xml) 8209873: Typo in javax.xml.validation.Validator.validate​ documentation

Thanks Lance! Joe On 8/23/18, 12:34 PM, Lance Andersen wrote: +1 On Aug 23, 2018, at 3:27 PM, Joe Wang > wrote: Hi, Please review a quick fix for a typo in javax.xml.validation.Validator: diff --git a/src/java.xml/share/classes/javax/xml/validation/Validator.

Re: (XS) java.logging Level.java minor cleanups

Yes, Seeburger AG OCA should be on file (b.eckenf...@seeburger.de) Thanks for following up Did you had any opinion on the synthetic accessors as well? Gruß Bernd -- https://Bernd.eckenfels.net Von: Daniel Fuchs Gesendet: Donnerstag, August 23, 2018 11:20 AM An:

Re: RFR(JDK12/JAXP/java.xml) 8209873: Typo in javax.xml.validation.Validator.validate​ documentation

+1 > On Aug 23, 2018, at 3:27 PM, Joe Wang wrote: > > Hi, > > Please review a quick fix for a typo in javax.xml.validation.Validator: > > diff --git a/src/java.xml/share/classes/javax/xml/validation/Validator.java > b/src/java.xml/share/classes/javax/xml/validation/Validator.java > --- a/src/j

RFR(JDK12/JAXP/java.xml) 8209873: Typo in javax.xml.validation.Validator.validate​ documentation

Hi, Please review a quick fix for a typo in javax.xml.validation.Validator: diff --git a/src/java.xml/share/classes/javax/xml/validation/Validator.java b/src/java.xml/share/classes/javax/xml/validation/Validator.java --- a/src/java.xml/share/classes/javax/xml/validation/Validator.java +++ b/s

Re: RFR: JDK-8176553 LdapContext follows referrals infinitely ignoring set limit

> On 20 Aug 2018, at 12:29, Vyom Tewari wrote: > > On 8/20/2018 4:19 PM, Chris Hegarty wrote: >>> On 19 Aug 2018, at 12:51, vyom tewari wrote: >>> >>> Hi, >>> >>> Please review the below code change. >>> >>> Webrev : http://cr.openjdk.java.net/~vtewari/8176553/webrev0.0/index.html >>> >>>

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

Hi Claes, useCanonPrefixCache = useCanonCaches ? getBooleanProperty("sun.io.useCanonPrefixCache",false) : false; can be written useCanonPrefixCache = useCanonCaches && getBooleanProperty("sun.io.useCanonPrefixCache",false); and the name useCanonCaches/useCanonPrefixCache should follow the c

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

On 2018-08-23 16:30, Sundararajan Athijegannathan wrote: Looks good Thanks, Sundar! /Claes

Re: RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

Looks good -Sundar On 23/08/18, 7:39 PM, Claes Redestad wrote: Hi, it's a tiny startup improvement to rearrange code so that the ExpiringCaches used in the FileSystem implementations aren't created if they aren't going to be used: Webrev: http://cr.openjdk.java.net/~redestad/8209837/open.0

RFR: 8209837: Avoid initializing ExpiringCache during bootstrap

Hi, it's a tiny startup improvement to rearrange code so that the ExpiringCaches used in the FileSystem implementations aren't created if they aren't going to be used: Webrev: http://cr.openjdk.java.net/~redestad/8209837/open.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8209837 3 fewer

Re: RFR 8209064: Make intellij support more robust after changes for 2018.2

On 21/08/18 10:31, Magnus Ihse Bursie wrote: Hi Maurizio! Even if this only incidentally relates to the build, please always include build-dev when making changes in the "make" directory. I will - thanks As far as I can understand, your changes looks good. One question: the build.xml was

Re: (XS) java.logging Level.java minor cleanups

Hi Bernd, Good finding! I agree with the proposed cleanup. I am always a bit uneasy of touching these classes as they have a propensity to come back and bite you from behind when you're not looking ;-) I have applied your patch and sent it to our test system for more confidence and everything we