Ah BTW, there is a TimeZone.getTimezone(ZoneOffset.UTC) construct which can be
used. The ZoneId is also immutable, but that construct does say nothing about
TimeZone instance.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: Bernd Eckenfels
Gesendet: Samstag,
Hello,
I am not sure I missed it, but it looks like there is no definition in the JCL
JavaDoc about instances of j.u.TimeZone (specifically SimpleTimeZone as well as
instances obtained with getDefault or by Id) beeing reentrant/thread Safe or
not. (There are for examplequite a few non-final
Hello!
The javadoc for CharsetDecoder [1] states that an exception is thrown
when a non-positive number is passed in as an argument.
However we only reject negative or zero numbers, but not NaN.
And likewise for CharsetEncoder.
Would you please help review a trivial fix?
BUGURL:
Alan, Chris,
thanks for looking at it, I went w/ the alternative suggested by Chris. that
required a sprinkle of doPrivileged in the testlibrary, but now
Sockets/policy.* files grant the minimal required permissions to the test code.
the incremental webrev can found here[1], please let me know
Looks ok to me (and same caveat as Magnus).
/Erik
On 2018-08-31 06:59, Maurizio Cimadamore wrote:
Thanks for the reviews; once again, when doing some more testing I
discovered some issues which had to do with coexistence with the
intellij jtreg plugin.
The bottom of the issue is that
On Aug 31, 2018, at 2:28 AM, Magnus Ihse Bursie
wrote:
>> Magnus, Philip, Brian, Goetz, can we have a vote? => "Fix" or
>> "DisableWarnings" ?
>
> Note that this decision can be different for the two libraries. I'd argue
> that the maintainer of each library decides. And if so, it seems to
Thanks for the reviews; once again, when doing some more testing I
discovered some issues which had to do with coexistence with the
intellij jtreg plugin.
The bottom of the issue is that certain IDE owned ant variable (such as
$ModuleFileDir$) are only set when clicking on certain IDE
> On Aug 31, 2018, at 8:52 PM, Baesken, Matthias
> wrote:
>
> Hi Max :
>
>>
>> - No need to "import java.security.Security".
>
> Sure I can remove this, it is a leftover.
>
>> - In the updated read() method, I think there is no need to use an "int
>> offset"
>> parameter. "int
Hi Max :
>
> - No need to "import java.security.Security".
Sure I can remove this, it is a leftover.
> - In the updated read() method, I think there is no need to use an "int
> offset"
> parameter. "int lineNumber" is enough and you can modify it and return it
> without a new local variable.
On 2018-08-31 11:14, Andrew Leonard wrote:
Hi,
So there seems to be varying opinion here, taking the 2D view point
since it is going to be maintained, the opinion seems to be more with
the fix (http://cr.openjdk.java.net/~aleonard/8209786/webrev.00/
Hi,
So there seems to be varying opinion here, taking the 2D view point since
it is going to be maintained, the opinion seems to be more with the fix (
http://cr.openjdk.java.net/~aleonard/8209786/webrev.00/). This would be my
personal preference also, but previous comments seemed to prefer
On 2018-08-31 01:28, Philip Race wrote:
Some day, I'd like to replace a lot of medialib functionality with
something
like the proposed Vector API. But that is far enough away that
medialib needs
to be maintained, and unlike a previous discussion about a similar
issue in
the JPEG library, we
On 2018-08-30 17:12, Maurizio Cimadamore wrote:
Hi,
this patch adds proper support for -o option to the idea.sh script,
which allows to place the .idea folder under any given output folder
(not necessarily the JDK root).
To be able to do this, I had to revampo the logic for template
Hi Leonard,
Whom should I add as reviewers? (Besides me :))
Best regards,
Goetz.
> -Original Message-
> From: Andrew Leonard
> Sent: Donnerstag, 30. August 2018 17:02
> To: Lindenmaier, Goetz
> Cc: Brian Burkhalter ; build-dev (build-
> d...@openjdk.java.net) ; core-libs-
>
14 matches
Mail list logo
