Re: [PATCH] JDK-7033681 - Improve the documentation of Arrays.asList

2018-09-15 Thread Jaikiran Pai
Hello Stuart, Thank you very much for the detailed review. I have attached an updated patch which incorporates the suggested changes. The complete javadoc text is included inline here and a few comments are inline in the rest of this mail:     /** * Returns a fixed-size list backed by the sp

Re: RFR 8210787 : Object.wait(long, int) throws inappropriate IllegalArgumentException

2018-09-15 Thread Martin Buchholz
Looks good! On Fri, Sep 14, 2018 at 10:44 PM, Ivan Gerasimov wrote: > Hello! > > This is inspired by a recent fix for JDK- 8210004 (Thread.sleep(millis, > nanos) timeout returns early). > > Currently, Object.wait(Long.MAX_VALUE, 1) would throw > "IllegalArgumentException: timeout value is negativ

Re: RFR 8210787 : Object.wait(long, int) throws inappropriate IllegalArgumentException

2018-09-15 Thread Roger Riggs
+1 On 9/15/2018 10:33 AM, Martin Buchholz wrote: Looks good! On Fri, Sep 14, 2018 at 10:44 PM, Ivan Gerasimov wrote: Hello! This is inspired by a recent fix for JDK- 8210004 (Thread.sleep(millis, nanos) timeout returns early). Currently, Object.wait(Long.MAX_VALUE, 1) would throw "IllegalAr

Re: RFR: JDK-8205461 Create Collector which merges results of two other collectors

2018-09-15 Thread Brian Goetz
tl;dr: "Duplexing" is an OK name, though I think `teeing` is less likely to be a name we regret, for reasons outlined below. The behavior of this Collector is:  - duplicate the stream into two identical streams  - collect the two streams with two collectors, yielding two results  - merge the tw

Re: Source file launcher - Handling of pre-compiled classes of the source file

2018-09-15 Thread Jonathan Gibbons
Jaikiran, This issue is on our radar; there is no need for any additional action on your part at this point. -- Jon On 9/14/18 7:50 PM, Jaikiran Pai wrote: Hello Peter, On 14/09/18 1:03 PM, Peter Levart wrote: The check for main class is performed after compilation (which actually produces

Thought on multiplicity of properties in Java

2018-09-15 Thread Martin Desruisseaux
I’m deriving Java interfaces from the UML of ISO 19111 international standard, and a though come to my mind. This is not a request for changing anything in the Java language now, I’m just wondering if this is something worth to be considered for the future. This proposal would require javac to hand

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

2018-09-15 Thread Philip Race
Were people mis-reading this as java.desktop ? Yes, its fine, this was added under https://bugs.openjdk.java.net/browse/JDK-8055206 and we should have removed that when jdk.desktop was backed out under https://bugs.openjdk.java.net/browse/JDK-8173409 -phil. On 9/14/18, 11:41 AM, Sean Mullan

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

2018-09-15 Thread Philip Race
It was exported in the past .. and it was publicly documented .. http://www.oracle.com/technetwork/articles/javase/appletwarning-135102.html .. so I think Sergey was correct in his "JDK" scope. Implementation would be for something entirely internal. +1 -phil. On 9/13/18, 7:20 PM, mandy chun

Re: Source file launcher - Handling of pre-compiled classes of the source file

2018-09-15 Thread Jaikiran Pai
Thank you Jon. -Jaikiran On 15/09/18 10:34 PM, Jonathan Gibbons wrote: > Jaikiran, > > This issue is on our radar; there is no need for any additional action > on your part at this point. > > -- Jon > > > On 9/14/18 7:50 PM, Jaikiran Pai wrote: >> Hello Peter, >> >> >> On 14/09/18 1:03 PM, Peter

[JDK-8209078] Unable to call default interface methods from named module

2018-09-15 Thread Johannes Kuhn
Hi everyone, I recently reported JDK-8209078 "Unable to call default method from interface in another module from named module" [1]. It is possible to call any default interface method directly using MethodHandles.lookup().findSpecial(Interf.class, "defaultMethodName", ..., Intef.class).invoke(..