Re: Thought on multiplicity of properties in Java

Hello Rémi Le 18/09/2018 à 00:28, fo...@univ-mlv.fr a écrit : > - theoretically, the covariance is defined in term of sub-typing, > trying to widen it's definition may have unintended consequences that > need studying. > Agree that it would require studying. But we have a general guidance, which

Sized Collector supplier

Is there a reason why java.util.stream.Collector doesn't support sized supply of a mutable result container? It seems that it could be hugely beneficial when the size of the stream is known, e. g. for precise ArrayList and HashMap.

Re: Reactive Streams utility API

Hi Pavel, Thanks for asking about this. I was meant to send an update to the list earlier but never got around to it. As you probably noticed from the history of this thread, there was a deafening silence in response to it. We decided that core-libs-dev might not have been the best place to start

Re: Sized Collector supplier

Hello! See the ticket: https://bugs.openjdk.java.net/browse/JDK-8072840 In my opinion only toList and toUnmodifiableList collectors would benefit significantly, but this could be solved in alternative way, adding the corresponding methods to the stream interface. Another possibility is to add a

答复: RFR JDK-8034802: (zipfs) newFileSystem throws UOE when the zip file is located in a custom file system

Hi Sherman, just one comment, the copyright dates in ZipFileSystem.java, ZipFileSystemProvider.java and ZipFSTester.java are not updated. -Felix 发件人: core-libs-dev 代表 Xueming Shen 发送时间: 2018年9月17日 17:51:05 收件人: Langer, Christoph 抄送: nio-dev; core-libs-d

Re: RFR 12 : 8072130 : java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX

Any thoughts on this change? -B On 9/11/18 3:41 PM, Brent Christian wrote: Hi, Please review this change to how the platform encoding is determined on Mac when loading agents. Webrev: http://cr.openjdk.java.net/~bchristi/8072130/webrev.01.cleanned/ Additional details in the bug report: htt

RFR(JDK12/JAXP/java.xml) 8210874: Test for JDK-8209615

Hi Lance, I accidentally missed checking in the test for JDK-8209615. Here's the original webrev for JDK-8209615: http://cr.openjdk.java.net/~joehw/jdk12/8209615/webrev/ and here's the webrev for requesting checking in the test: http://cr.openjdk.java.net/~joehw/jdk12/8210874/webrev/ I kept th

Re: RFR 12 : 8072130 : java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX

+1 On 9/18/18, 9:42 AM, Brent Christian wrote: Any thoughts on this change? -B On 9/11/18 3:41 PM, Brent Christian wrote: Hi, Please review this change to how the platform encoding is determined on Mac when loading agents. Webrev: http://cr.openjdk.java.net/~bchristi/8072130/webrev.01.cle

Re: 8210496: Improve filtering for classes with security sensitive fields

On 9/16/18 6:03 AM, Alan Bateman wrote: I've put a new webrev here, the only change is the replacement of the old loop to use contains as you suggested:   http://cr.openjdk.java.net/~alanb/8210496/2/webrev/index.html Looks good. Mandy

[12] RFR: 8209880: tzdb.dat is not reproducibly built

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209880/webrev.00/ The fix is to remove the use of HashSet/Map which is not guaranteed to preserve the same order on i

Re: RFR(JDK12/JAXP/java.xml) 8210874: Test for JDK-8209615

+1 > On Sep 18, 2018, at 1:00 PM, Joe Wang wrote: > > Hi Lance, > > I accidentally missed checking in the test for JDK-8209615. > > Here's the original webrev for JDK-8209615: > http://cr.openjdk.java.net/~joehw/jdk12/8209615/webrev/ > > and here's the webrev for requesting checking in the tes

RFR - JDK-8210718 String::detab, String::entab (CSR Review)

Please review the API for String::detab and String::entab. Used to expand tabs into spaces, and spaces back to tabs. csr: https://bugs.openjdk.java.net/browse/JDK-8210718 jbs: https://bugs.openjdk.java.net/browse/JDK-8210717 Cheers, — Jim

RFR - JDK-8210717 String::detab, String::entab (Code Review)

Please review the code for String::detab and String::entab. Used to expand tabs into spaces, and spaces back to tabs. webrev: http://cr.openjdk.java.net/~jlaskey/8210717/webrev/index.html jbs: https://bugs.openjdk.java.net/browse/JDK-8210717 csr: https://bugs.openjdk.java.net/browse/JDK-8210718

RFR - JDK-8202442 - String::unescape (Code Review)

Please review the code for String::unescape. Used to translate escape sequences in a string, typically in a raw string literal, into characters represented by those escapes. webrev: http://cr.openjdk.java.net/~jlaskey/8202442/webrev/index.html jbs: https://bugs.openjdk.java.net/browse/JDK-820244

RFR - JDK-8203703 String::transform (CSR Review)

Please review the API for String::transform. The goal is to provide a String instance method to allow function application of custom transformations applied to an instance of String. csr: https://bugs.openjdk.java.net/browse/JDK-8203703 jbs: https://bugs.openjdk.java.net/browse/JDK-8203442 Chee

RFR - JDK-8202443 - String::unescape (CSR Review)

Please review the API for String::unescape. Used to translate escape sequences in a string, typically in a raw string literal, into characters represented by those escapes. We decided to simplify the interface to the basics, i.e., translate all escape sequences. No reciprocating method since t

RFR - JDK-8203442 String::transform (Code Review)

Please review the code for String::transform. The goal is to provide a String instance method to allow function application of custom transformations applied to an instance of String. webrev: http://cr.openjdk.java.net/~jlaskey/8203442/webrev/index.html jbs: https://bugs.openjdk.java.net/browse/

Re: RFR - JDK-8202442 - String::unescape (Code Review)

Do you mean the throws specifically? If so, of course. > On Sep 18, 2018, at 2:51 PM, Jim Laskey wrote: > > Please review the code for String::unescape. Used to translate escape > sequences in a string, typically in a raw string literal, into characters > represented by those escapes. > > w

Re: RFR - JDK-8202442 - String::unescape (Code Review)

Revised to break up long exception statements; webrev: http://cr.openjdk.java.net/~jlaskey/8202442/webrev-01/index.html > On Sep 18, 2018, at 3:03 PM, Jim Laskey wrote: > > Do you mean the throws specifically? If so, of course. > > > >> On Sep 18, 2018, at 2:51 PM, Jim Laskey wrote: >> >>

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

Looks good to me. I guess it's hard to prove that the output is now stable, but time will tell. /Erik On 2018-09-18 10:41, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at: http:/

Re: RFR - JDK-8202442 - String::unescape (Code Review)

Jim, In JLS, and hence javac, Unicode escape handling happens early on at a low level, before string escape handling. This means that it is technically possible to write string escape sequences in terms of Unicode escapes. I'm not suggesting you should do the same here, but you should be awa

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

Hi Naoto, The elimination of duplicates and stable iteration should help. +1 Roger On 9/18/18 1:41 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at: http://cr.openjdk.java.net/~

Re: RFR - JDK-8202442 - String::unescape (Code Review)

The intent, of course, is to offset the raw string literals non-translation of Unicode escapes and escape sequences. That is, have the multi-line cake and eat the escapes too. So a developer could have String s = ` \t\tTitle \t\t\tbody

Re: RFR - JDK-8210718 String::detab, String::entab (CSR Review)

Hi Jim, It may be useful to be more specific about the definition of a tab stop. In this context I think you mean the next multiple of 'n' greater than the current position + 1. (And not taking into account surrogates, high and low) as 1 character or 2. In some other contexts, tab stops can be

Re: RFR(JDK12/JAXP/java.xml) 8210874: Test for JDK-8209615

Thanks Lance! It's done now. Joe On 9/18/18, 10:46 AM, Lance Andersen wrote: +1 On Sep 18, 2018, at 1:00 PM, Joe Wang > wrote: Hi Lance, I accidentally missed checking in the test for JDK-8209615. Here's the original webrev for JDK-8209615: http://cr.openjdk.

Re: RFR - JDK-8202442 - String::unescape (Code Review)

Hi Jim, At the last sentence in the method description, there's a line "otherwise a CharacterCodingException may occur during UTF-8 decoding." It's not decoding into UTF-8, so simply "during decoding (or unescaping)" sounds better to me. Naoto On 9/18/18 10:51 AM, Jim Laskey wrote: Please

RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

Hi, Please help codereview the change for JDK-8210899. issue: https://bugs.openjdk.java.net/browse/JDK-8210899 webrev: http://cr.openjdk.java.net/~sherman/8210899/webrev Thanks, Sherman

Re: RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

Hi Sherman, This looks fine to me. Does the current code fail both of the added checks in the test? Thanks, Brian On Sep 18, 2018, at 5:14 PM, Xueming Shen wrote: > Please help codereview the change for JDK-8210899. > > issue: https://bugs.openjdk.java.net/browse/JDK-8210899 > webrev: http:

Re: RFR JDK-8210899: (zipfs) ZipFileSystem.EntryOutputStreamCRC32 mistakenly set the crc32 value into size field

On 9/18/18, 5:50 PM, Brian Burkhalter wrote: Hi Sherman, This looks fine to me. Does the current code fail both of the added checks in the test? Hi Brian, Thanks looking into it. Yes, the current code (with the change for JDK-8034802) fails both of the added checks. Thanks, Shermzn