Re: [12] RFR: 8211961: Broken link in java.util.Locale

2018-10-12 Thread Mandy Chung
+1 Mandy On 10/12/18 2:38 PM, naoto.s...@oracle.com wrote: Hi, Please review this simple doc fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8211961 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8211961/webrev.01/ Although @link is preferred i

[12] RFR: 8211961: Broken link in java.util.Locale

2018-10-12 Thread naoto . sato
Hi, Please review this simple doc fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8211961 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8211961/webrev.01/ Although @link is preferred in the javadoc, it is currently not working for @serialField (

RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and permissions of the files

2018-10-12 Thread Langer, Christoph
Hi Sherman, thanks for your input. Next week I’ll work on updating my webrev to incorporate your points and I’ll also draft a CSR. Best regards Christoph From: Xueming Shen Sent: Mittwoch, 10. Oktober 2018 09:17 To: Langer, Christoph Cc: core-libs-dev@openjdk.java.net Subject: Re: RFR (Enhan

Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

2018-10-12 Thread Joe Wang
Hi all, Here's an update based on all of the great reviews and comments (thanks all!): JBS: https://bugs.openjdk.java.net/browse/JDK-8202285 CSR: https://bugs.openjdk.java.net/browse/JDK-8202302 Current version: specdiff: http://cr.openjdk.java.net/~joehw/jdk12/8202285/specdiff_02/java/nio/f

Review Request: 6443578: Continuation lines in JAR manifests do not follow RFC-822

2018-10-12 Thread Philipp Kunz
Hi, Attached is a patch with a proposal to fix bug 6443578 about Manifest inserting line breaks in between bytes of characters encoded in utf-8 with more than one byte and a test for it. The Issue The current Manifest implementation places line breaks for breaking and continuing values onto th

Re: JDK 12 RFR of JDK-8058202 : AnnotatedType implementations don't override toString(), equals(), hashCode()

2018-10-12 Thread Werner Dietl
Hi Joe, all, the logic looks good to me. In the tests I'm wondering whether to include an annotated wildcard bound. There is: 307 public @AnnotType(11) Set<@AnnotType(13) ? extends Number> fooNumberSet2() {return null;} but nothing like Set fooNumberSet2() {return null;} I wouldn't ex

Re: CODETOOLS-7902290 breaks all JTreg tests which use @requires vm.opt.*

2018-10-12 Thread Jonathan Gibbons
On 10/12/18 8:15 AM, Volker Simonis wrote: On Thu, Oct 11, 2018 at 11:09 PM Igor Ignatyev wrote: Hi Volker, vm.opt.* options are set by jtreg (RegressionContext::processVMOptions), and their value is expected to be "null" if a flag hasn't been passed to JDK under tests via -javaoptions or

Re: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Sean Mullan
On 10/12/18 10:33 AM, Langer, Christoph wrote: Sean, what is your take on this? Sorry, I haven't had time to look at this in more detail yet. But, let's take a step back first. Can you or Matthias explain in more detail why this fix is necessary? What are the use cases and motivation? The bug

Re: CODETOOLS-7902290 breaks all JTreg tests which use @requires vm.opt.*

2018-10-12 Thread Volker Simonis
On Thu, Oct 11, 2018 at 11:09 PM Igor Ignatyev wrote: > > Hi Volker, > > vm.opt.* options are set by jtreg (RegressionContext::processVMOptions), and > their value is expected to be "null" if a flag hasn't been passed to JDK > under tests via -javaoptions or -vmoptions. I don't think there is so

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Langer, Christoph
Hi Matthias, I generally support this enhancement of IOExceptions to include path information. I also think that we should protect this with the java.security property "jdk.includeInExceptions" and agree that "path" would be a good choice since it is generic enough to be used in other places w

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Baesken, Matthias
Hi Alan, Goetz, >There are several issues with this proposal. The security concern is the main >one and I think we should wait for comment from security-dev. . >If this is required, I would choose a more generic tag >so it can be reused in other places. >I would just use "path". > >Bes

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Lindenmaier, Goetz
Hi, If this is required, I would choose a more generic tag so it can be reused in other places. I would just use "path". Best regards, Goetz. > -Original Message- > From: core-libs-dev On Behalf > Of Baesken, Matthias > Sent: Freitag, 12. Oktober 2018 10:13 > To: security-...@openjdk

Re: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Alan Bateman
On 12/10/2018 09:12, Baesken, Matthias wrote: Ping …  any reviews / comments ? Should I add  a category  , for example    “ioExceptionsWithPath” to the java.security – file  to control  the enabling/disabling of the  enhanced exception ?   java.security # # Enhanced exception message

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Baesken, Matthias
Ping ... any reviews / comments ? Should I add a category , for example"ioExceptionsWithPath" to the java.security - file to control the enabling/disabling of the enhanced exception ? java.security # # Enhanced exception message information ... #jdk.includeInExceptions=hostInfo