Re: Review Request: JDK-8207146: Rename jdk.internal.misc.Unsafe::xxxObject to xxxReference

2018-10-21 Thread Tobias Hartmann
Hi Mandy, the compiler related changes look good to me. Please run hs-tier1-3 if you haven't done so yet. Best regards, Tobias On 16.10.18 18:08, Mandy Chung wrote: > Webrev: > http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8207146/webrev.00/ > > Unsafe::getObject returns a reference to an

Re: Approval Request to update TreeSet#add method documentation

2018-10-21 Thread Martin Buchholz
Hi Kishor, I think your attachment was stripped out - standard policy for this mailing list, I think. For a small patch like this, you should just include the patch inline in text form. On Thu, Oct 18, 2018 at 2:21 AM, Kishor Gollapalliwar < kishor.gollapalli...@gmail.com> wrote: > Hi Team, > >

Re: 6850720: Allow POSIX_SPAWN to be used for ProcessImpl on Linux

2018-10-21 Thread Martin Buchholz
As author of the vfork strategy ... I'm supportive of the directions in this thread.👍👍 David's patch seems like clear progress (although maybe now that we have configure, we can make the spawn strategy conditional on HAVE_SPAWN_H) vfork is even (!) less in favor than it used to be, so migrating o

Re: Review Request: 6202130: java.util.jar.Attributes.writeMain() can't handle multi-byte chars

2018-10-21 Thread Martin Buchholz
I only took a quick look. Looks good, but here's a nitpick - capitalize javadoc that begins with "returns" On Fri, Oct 19, 2018 at 1:27 AM, Philipp Kunz wrote: > Hi Martin and everyone, > > You were absolutely right to object "utf". > Please find a revised and updated patch attached. > > Regard