PS Re-refined implementation at
http://cr.openjdk.java.net/~darcy/8212081.1/
The implementation now elides "extends java.lang.Object" in "? extends
java.lang.Object" if Object is not annotated and there are no other bounds.
The tests were updated to cover this situation too.
Thanks,
Hi Peter,
Coming back to this review after my Code One activities this year have
run their course...
On 10/17/2018 3:07 PM, Peter Levart wrote:
Hi Joe,
On 10/17/2018 09:16 PM, joe darcy wrote:
PS In response to some off-list feedback, an updated webrev uses a
stream-ier implementation:
Thanks Daniel:
http://cr.openjdk.java.net/~robm/8139965/webrev.03/
I'm planning to follow up on the test side of things with a separate
bug. I think the technique used in some of the recent SQE LDAP tests
might be applicable.
-Rob
On 05/09/18 09:53, Daniel Fuchs wrote:
> Hi Rob,
>
> That
Hi Thomas,
In an abundance of caution, I was thinking that it would be a change right
at the beginning of a new release so it gets the most exercise and
users in early access, etc.
And before that it needs to be put into more regular usage and
some more unusual environments. The default is
+1
A potential "enhancement" for future consideration is whether or not worth
to combine DeflaterZFStreamRef/InflaterZFStream back to one class, maybe
with a "instanceof" before calling Deflater/Inflater.end(addr).
-Sherman
On 10/24/18, 10:19 AM, Lance Andersen wrote:
Hi all,
This change
I'm in favor, for whatever that's worth.
On Thu, Oct 25, 2018 at 5:33 AM Thomas Stüfe wrote:
>
> Hi all,
>
> the more I mull over this, the more I would prefer to do the jump for
> real and attempt switch the default to posix_spawn() for Linux.
>
> We have theoretically established that both
This recently received CSR approval, so it seems like a good time to pick
the codereview up again:
http://cr.openjdk.java.net/~robm/8160768/webrev.08/
Referencing:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050794.html
1) I'm copying the behaviour from
On 10/24/18 11:12 PM, Alan Bateman wrote:
On 24/10/2018 23:17, Mandy Chung wrote:
Remove a leftover file from JDK-8159590 that removed
jdk.internal.misc.VM.registerVMNotification method taking
VMNotification parameter.
$ hg remove
Thanks, Stephen.
I filed an issue for your suggestion:
https://bugs.openjdk.java.net/browse/JDK-8212970
I will need to look into the issue, but so far as I understand, will it
be fine to modify the offending transition date to the next day for
2018f's immediate issue?
Naoto
On 10/22/18
Hi,
The FIS skipping past of end of file is puzzling.
If the 'were beyond EOF' was considering the possibility that the file
was being
extended concurrently with the skip operation then it would not be random,
just a normal writer/reader race. The return value from skip would be
accurate
> On Oct 25, 2018, at 9:32 AM, Alan Bateman wrote:
>
>
>
> On 24/10/2018 18:19, Lance Andersen wrote:
>> Hi all,
>>
>> This change removes the finalize methods from
>> java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecated and
>> marked for removal in JDK 9
>>
>> The
On 24/10/2018 18:19, Lance Andersen wrote:
Hi all,
This change removes the finalize methods from
java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecated and
marked for removal in JDK 9
The webrev can be found at: http://cr.openjdk.java.net/~lancea/8212129/webrev.00/
Looks good Lance
Thanks
On 10/24/2018 01:19 PM, Lance Andersen wrote:
Hi all,
This change removes the finalize methods from
java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecated and
marked for removal in JDK 9
The webrev can be found at:
Andy added the a comment [1] to the JEP with the command line options.
I'll format it and add it to the JEP itself soon, but until then you can
see it in the comments to help you review it.
The tests will come shortly (Andy can comment on the state of this).
They will be a mix of automated
Hi all,
the more I mull over this, the more I would prefer to do the jump for
real and attempt switch the default to posix_spawn() for Linux.
We have theoretically established that both glibc down to 2.4 and
muslc since always did "the right thing".
We still have time in the 12 time line to
On Thu, 25 Oct 2018 at 09:37, Andrew Haley wrote:
>
> On 10/22/2018 11:25 PM, Stephen Colebourne wrote:
> > The IANA time-zone database [1] provides details of how time-zones
> > change over time. The latest release - 2018f - cannot be processed
> > successfully by the current JDK parser [2]. A
Hi Brian,
Hmmm... Just thinking aloud:
Should InputStream provide a safe but non-optimized version of
skipNBytes() that does not rely on skip(), and should subclasses
that override skip() for performance also be changed to override
skipNBytes too if performance improvement can be gained?
best
On 10/22/2018 11:25 PM, Stephen Colebourne wrote:
> The IANA time-zone database [1] provides details of how time-zones
> change over time. The latest release - 2018f - cannot be processed
> successfully by the current JDK parser [2]. A workaround exists
> however unlike previous cases of tzdb
Hi Lance,
looks fine, reviewed. Good to see this happening.
Best regards
Christoph
> -Original Message-
> From: core-libs-dev On Behalf
> Of Lance Andersen
> Sent: Mittwoch, 24. Oktober 2018 19:20
> To: core-libs-dev
> Subject: RFR 8212129: Remove finalize methods from
>
On 24/10/2018 23:17, Mandy Chung wrote:
Remove a leftover file from JDK-8159590 that removed
jdk.internal.misc.VM.registerVMNotification method taking
VMNotification parameter.
$ hg remove
src/java.base/share/classes/jdk/internal/misc/VMNotification.java
Looks okay to me. I assume you've
20 matches
Mail list logo
