Re: Proposal Extending API for Streams (or other potentially long builder or chain calls)

Oops. I was meaning JDK-8140283 of course. You can vote for it in JBS, if you find it useful :) With kind regards, Ivan On 10/29/18 3:06 PM, Constantine Plotnikov wrote: Hello Ivan, Yes. It is practically the same request, only method name

Re: RFR: 8213035: Pack MethodHandleInlineStrategy coder and length into a long

Vladimir, Mandy, thanks for reviewing! /Claes On 2018-10-29 20:16, Mandy Chung wrote: On 10/29/18 8:17 AM, Claes Redestad wrote: Hi, by packing the coder and length values into a long, and combining the length and coder mixers, we can reduce the number of MHs generated to set up String co

Re: RFR: 8213035: Pack MethodHandleInlineStrategy coder and length into a long

On 10/29/18 8:17 AM, Claes Redestad wrote: Hi, by packing the coder and length values into a long, and combining the length and coder mixers, we can reduce the number of MHs generated to set up String concatenations. Theoretically we reduce the number of MHs created by up to a third, and

Re: JDK 12 RFR of JDK-8212081: AnnotatedType.toString implementation don't print annotations on embedded types

Hi Joel, Thanks for the review :-) I'll push the 8212081.2 version with a few additional notes for future maintainers: +    /* + * Note that if additional subclasses of AnnotatedTypeBaseImpl are + * added, the equals methods of AnnotatedTypeBaseImpl will need to + * be updated to

Re: Proposal: Stream.iterateWhile(T seed, Function> mapper)

Two more things: 1) The example I provided might have been too simple to be convincing. Note that the proposed method is particularly useful when the Predicate (hasNext) has some common expensive part with the UnaryOperator (next). For example: boolean hasNext(Foo foo) { Bar bar = com

Re: Proposal Extending API for Streams (or other potentially long builder or chain calls)

Hello Constantine! It seems that a request for such method was made in JDK-8210372 . I like the method name chain(), proposed in that request. With kind regards, Ivan On 10/26/18 2:13 AM, Constantine Plotnikov wrote: Hello All! This email w

Re: RFR: 8213035: Pack MethodHandleInlineStrategy coder and length into a long

Looks good. Best regards, Vladimir Ivanov On 29/10/2018 08:17, Claes Redestad wrote: Hi, by packing the coder and length values into a long, and combining the length and coder mixers, we can reduce the number of MHs generated to set up String concatenations. Theoretically we reduce the num

Re: Proposal Extending API for Streams (or other potentially long builder or chain calls)

Jim Laskey ask for a similar feature on String, calling it "transform", so i don't know if it's a good idea or not to add this API, but at least the name should be the same. see http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-September/055532.html cheers, Rémi - Mail original

Re: [12]RFR of JDK-8210409:Refactor java.util.TimeZone:i18n shell tests to plain java tests

Looks good. Naoto On 10/28/18 11:55 PM, Ying Zhou wrote: Hello, test/jdk/java/util/TimeZone/OldIDMappingTest.sh test/jdk/java/util/TimeZone/Bug8066652.sh test/jdk/java/util/TimeZone/TimeZoneDatePermissionCheck.sh Please review this patch to refactor above shell script tests to java. Bug: htt

Re: RFR: 8213085: (tz) Upgrade time-zone data to tzdata2018g

Looks good. Thanks for catching up with it quickly. Naoto On 10/29/18 8:19 AM, Ramanand Patil wrote: Hi all, Please review the latest TZDATA integration (tzdata2018g) into JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213085 Webrev: http://cr.openjdk.java.net/~rpatil/8213085/webrev.00/

Re: Fwd: Re: JMathConstant submission for upcoming JDK

Here are the measurement systems, as I see them. public enum MeasurementSystem { INTERNATIONAL_SYSTEM_OF_UNITS, METRIC, UNITED_STATES_CUSTOMARY, BRITISH_IMPERIAL }

RE: [RFR] 8160768: Add capability to custom resolve host/domain names within the default JDNI LDAP provider

Thanks Rob, looks fine to me now. Looking forward for a JDK 8 + JDK 11 backport and a testable package for Windows. Michael > -Original Message- > From: Rob McKenna > Sent: Thursday, October 25, 2018 6:35 PM > To: core-libs-dev@openjdk.java.net > Cc: Osipov, Michael (GS IT PD LD PLM) ;

Proposal Extending API for Streams (or other potentially long builder or chain calls)

Hello All! This email was previously filled as a feature request for JDK, I was forwarded here to write it as an email. Currently, if one needs to skip some stage or provide a group of reused stages one to have to do the following: Stream s = collection.stream() .map(a -> doIt(a, bb)) .

Re: RFR: JDK-8212828 Allow POSIX_SPAWN to be used for ProcessImpl on Linux

Hi Roger, On Thu, Oct 25, 2018 at 10:45 PM Roger Riggs wrote: > > Hi Thomas, > > In an abundance of caution, I was thinking that it would be a change right > at the beginning of a new release so it gets the most exercise and > users in early access, etc. > Okay, I understand that. Over the next

Re: RFR: 8213085: (tz) Upgrade time-zone data to tzdata2018g

LGTM. On Mon, Oct 29, 2018 at 8:19 AM, Ramanand Patil wrote: > Hi all, > Please review the latest TZDATA integration (tzdata2018g) into JDK12. > Bug: https://bugs.openjdk.java.net/browse/JDK-8213085 > Webrev: http://cr.openjdk.java.net/~rpatil/8213085/webrev.00/ > > All the TimeZone related test

RFR: 8213085: (tz) Upgrade time-zone data to tzdata2018g

Hi all, Please review the latest TZDATA integration (tzdata2018g) into JDK12. Bug: https://bugs.openjdk.java.net/browse/JDK-8213085 Webrev: http://cr.openjdk.java.net/~rpatil/8213085/webrev.00/ All the TimeZone related tests are passed after integration. Regards, Ramanand.

RFR: 8213035: Pack MethodHandleInlineStrategy coder and length into a long

Hi, by packing the coder and length values into a long, and combining the length and coder mixers, we can reduce the number of MHs generated to set up String concatenations. Theoretically we reduce the number of MHs created by up to a third, and real time improvements in startup tests exerci

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions (was: Enhance jdk.nio.zipfs to support Posix File Permissions)

Hi Alan, security guys, I've proposed a CSR for this change now: https://bugs.openjdk.java.net/browse/JDK-8213082. I also updated the webrev, simplifying jdk.nio.zipfs.ZipUtils.permsFromFlags and eliminating the WeakHashMap: http://cr.openjdk.java.net/~clanger/webrevs/8213031.2/ Since I've de

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions (was: Enhance jdk.nio.zipfs to support Posix File Permissions)

On 29/10/2018 09:26, Langer, Christoph wrote: : As per request from Alan, I’m adding security-dev to get a review from security perspective. For security-dev then I think it would be better to write-up a summary of the overall proposal and the implications for applications/libraries that u

Re: RFR(xxs): 8213017: jspawnhelper: need to handle pipe write failure when sending return code

Thank you Alan. On Mon, Oct 29, 2018 at 9:30 AM Alan Bateman wrote: > > On 27/10/2018 16:58, Thomas Stüfe wrote: > > May I please have reviews for this trivial patch? > > > > On Linux, I get compiler warnings when building the jspawnhelper. It > > complains about not checking the return code to wr

RFR 8213031: (zipfs) Add support for POSIX file permissions (was: Enhance jdk.nio.zipfs to support Posix File Permissions)

Hi, here's an update of my webrev: http://cr.openjdk.java.net/~clanger/webrevs/8213031.1/ I added synchronization to the updating of permCache in ZipUtils.java to avoid concurrent modifications. As per request from Alan, I'm adding security-dev to get a review from security perspective. Than

Re: JDK 12 RFR of JDK-8212081: AnnotatedType.toString implementation don't print annotations on embedded types

Hi Joe, I suspect you pasted the wrong link, link to updated impl ends in 8212081.2 right? Anyhow, the .2 version looks good. Ship it! Cheers /Joel /Joel On Fri, 26 Oct 2018 at 04:03, joe darcy wrote: > PS Re-refined implementation at > > http://cr.openjdk.java.net/~darcy/8212081.1/ > > T

Re: RFR(xxs): 8213017: jspawnhelper: need to handle pipe write failure when sending return code

On 27/10/2018 16:58, Thomas Stüfe wrote: May I please have reviews for this trivial patch? On Linux, I get compiler warnings when building the jspawnhelper. It complains about not checking the return code to write when communicating an error code back to be parent. I decided to just fix it sinc

RE: RFR: 8213016: (tz) Upgrade time-zone data to tzdata2018f

Thank you Martin and Naoto for your reviews. Unfortunately, I have to discard this review and start a new review for tzdata2018g, since 2018g is already released now. Regards, Ramanand. > -Original Message- > From: Naoto Sato > Sent: Saturday, October 27, 2018 1:41 AM > To: Martin Buchho