Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

On 10/19/18 11:26 AM, Joe Wang wrote: Current version: http://cr.openjdk.java.net/~joehw/jdk12/8202285/webrev_v06/ Hi Joe, Thanks for updating the tests per my comments. Everything looks good now! s'marks

Re: Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

Thanks for the review, Vladimir.  hotspot tier1-3 and jdk tier1-3 all passed. I will submit another test run as sanity tests before I push. Mandy On 11/5/18 5:51 PM, Vladimir Kozlov wrote: I looked on tests changes in src/jdk.internal.vm.compiler and test/hotspot/jtreg/compiler/jvmci. They loo

Re: Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

I looked on tests changes in src/jdk.internal.vm.compiler and test/hotspot/jtreg/compiler/jvmci. They look fine. And you ran hotspot tier1-3 which tests AOT, JVMCI and Graal. So your changes should be fine regarding them since you did not get failures. Thanks, Vladimir On 11/1/18 9:16 PM, Ma

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Based on feedback and further discussion, we're going with jdk.jpackager and jdk.jpackager.runtime. I’m also hoping that the service daemon support will make it into the JDK 12 deliverable. Is that out of the question at this point? It won't make JDK 12, but is near the top of the list for

Re: RFR 8212876: ftp: links for character-sets require a login password

Thanks Lance, again :-) On 11/5/18, 12:34 PM, Lance Andersen wrote: +1 On Nov 5, 2018, at 3:24 PM, Joe Wang > wrote: Hi, Please review a fix for the broken links to IANA-CHARSETS. While we are here, I also updated the link to XML 1.0 since "REC-xml-20040204" w

Re: RFR 8212876: ftp: links for character-sets require a login password

+1 > On Nov 5, 2018, at 3:24 PM, Joe Wang wrote: > > Hi, > > Please review a fix for the broken links to IANA-CHARSETS. While we are here, > I also updated the link to XML 1.0 since "REC-xml-20040204" was outdated. > Both the current and outdated XML 1.0 spec actually referenced the correct >

RFR 8212876: ftp: links for character-sets require a login password

Hi, Please review a fix for the broken links to IANA-CHARSETS. While we are here, I also updated the link to XML 1.0 since "REC-xml-20040204" was outdated. Both the current and outdated XML 1.0 spec actually referenced the correct iana.org page for the charsets. --- a/src/java.xml/share/clas

Re: RFR 8212872: Broken link to http://www.w3.org/XML/xml-names-19990114-errata

Thanks Lance! On 11/5/18, 11:13 AM, Lance Andersen wrote: +1 On Nov 5, 2018, at 2:10 PM, Joe Wang > wrote: Hi, Please review a correction of the links: 1. the 1st link shall point to the standard "Namespaces in XML", not the inner anchor to the "Qualified Name

Lazy memory initialization for Unsafe (calloc vs. malloc)

Hi, lets assume an application A [1] which is optimized for throughput, not latency. Additionally, A reverts to sun.misc.Unsafe to store gigabytes of data on off-heap memory to e.g. improved memory utilization and performance. Due to the fact that Unsafe#allocateMemory returns an uninitialized (m

Re: RFR 8212872: Broken link to http://www.w3.org/XML/xml-names-19990114-errata

+1 > On Nov 5, 2018, at 2:10 PM, Joe Wang wrote: > > Hi, > > Please review a correction of the links: > > 1. the 1st link shall point to the standard "Namespaces in XML", not the > inner anchor to the "Qualified Names" section. > 2. the 2nd link shall point to the html file > "xml-names-19990

Re: [12] RFR: 8213330: Fix legal headers in i18n tests

Hi Lance, On 11/3/18 6:12 AM, Lance Andersen wrote: Hi Naoto Looks good over all. One question: * I noticed that some of the files had a copyright date and others did not.  For example: o test/jdk/sun/util/calendar/zi/tzdata/gmt  has a copyright o test/jdk/sun/util/calendar/

RFR 8212872: Broken link to http://www.w3.org/XML/xml-names-19990114-errata

Hi, Please review a correction of the links: 1. the 1st link shall point to the standard "Namespaces in XML", not the inner anchor to the "Qualified Names" section. 2. the 2nd link shall point to the html file "xml-names-19990114-errata.html", not "xml-names-19990114-errata". --- a/src/java.

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Christoph, in general your change looks good to me. I need some more time to think about the implications mentioned by Alan and Chris but for the time being please find some comments regarding your implementation below: ZipFileAttributeView.java - can you please throw an AssertionError() for

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

Fixed.  Thanks. dl On 11/5/18 8:00 AM, Sean Mullan wrote: 726 * The VM recoginizes this method as special, so any changes to the s/recoginizes/recognizes/ --Sean On 11/3/18 4:00 PM, dean.l...@oracle.com wrote: I made a pass at improving the comments based on feedback I've received.  I updat

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

Thanks Alan. dl On 11/4/18 1:03 AM, Alan Bateman wrote: On 03/11/2018 20:00, dean.l...@oracle.com wrote: I made a pass at improving the comments based on feedback I've received.  I updated webrev.4 in place, along with an incremental diff: I looked through the updated webrev.4, mostly studying

Re: RFR: JDK8U Backport of 8171049: Era.getDisplayName doesn't work with non-IsoChronology

Looks good. Since you modified the test case, please add the copyright year 2018 in the test case before you push. Naoto On 11/4/18 10:26 PM, Deepak Kejriwal wrote: Hi all, Please review the fix for JDK8u Backport of https://bugs.openjdk.java.net/browse/JDK-8171049 Webrev: http://cr.op

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 05/11/18 15:59, Alan Bateman wrote: On 05/11/2018 13:05, Langer, Christoph wrote: ... I think you'll need to do a write-up of the overall proposal so that folks can jump in and point out the implications. It's not easy to do this in a code review of a small piece of the solution. Righ

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 05/11/2018 13:05, Langer, Christoph wrote: Hi Alan, all, I’d welcome a discussion, for sure. Unfortunately there hasn’t been so much participation in this yet. I think this is an item where it’s hard to have a clear opinion and where it’s difficult to oversee all implications it might hav

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

726 * The VM recoginizes this method as special, so any changes to the s/recoginizes/recognizes/ --Sean On 11/3/18 4:00 PM, dean.l...@oracle.com wrote: I made a pass at improving the comments based on feedback I've received.  I updated webrev.4 in place, along with an incremental diff:

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Chris > The reason I asked about the CSR scope clarification is that it was > unclear to me what the ultimate intentions are, given that the previous > mails ( linked to from the CSR ) did have Java SE API changes ( in the > java.util.zip package ). > > Are you now happy to reduce the scope of

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 05/11/18 12:54, Langer, Christoph wrote: Hi Chris, yes, there's no impact on Java SE with this item. No API is changed. I've set the scope to JDK, as it affects the features that are available with the "jar" filesystem provider from module jdk.zipfs. ... The reason I asked about the CSR

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Alan, all, I'd welcome a discussion, for sure. Unfortunately there hasn't been so much participation in this yet. I think this is an item where it's hard to have a clear opinion and where it's difficult to oversee all implications it might have. Who'd be willing to have a look from security

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Chris, yes, there's no impact on Java SE with this item. No API is changed. I've set the scope to JDK, as it affects the features that are available with the "jar" filesystem provider from module jdk.zipfs. Best regards Christoph > -Original Message- > From: Chris Hegarty > Sent: M

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Christoph, On 05/11/18 07:32, Langer, Christoph wrote: .. CSR: https://bugs.openjdk.java.net/browse/JDK-8213082 Can you please add a `Scope` value to the CSR? I can't quite tell, but I assume it should be `JDK` or `Implementation`, right? I want to clarify that there is no impact on Java

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 05/11/2018 07:32, Langer, Christoph wrote: Hi, Ping. May I get reviews/substantial feedback on this zipfs enhancement? It might be bit early to be asking for a code review on just one piece of this. I think the first step on this feature has to be to put all the issues on the table. The