[12] RFR JDK-8211266: [TESTBUG] jdk/nio/zipfs/ZipFSTester.java failed intermittently in ZipFSTester.checkRead()

2018-11-11 Thread Amy Lu
Please review this test fix for jdk/nio/zipfs/ZipFSTester.java bug: https://bugs.openjdk.java.net/browse/JDK-8211266 webrev: http://cr.openjdk.java.net/~amlu/8211266/webrev.00/ Testcase testStreamChannel fails when the given "bytes" length=0 (expected.length=0, and in such case, also

Re: The new optimized version of Dual-Pivot Quicksort

2018-11-11 Thread Zheka Kozlov
Hi Tagir! I wrote a simple benchmark comparing Arrays.sort() and your implementation: https://gist.github.com/orionll/595d10ff37ffe0d8c3824e734055cf00 Here are the results on my computer (JDK 11): REMEMBER: The numbers below are just data. To gain reusable insights, you need to follow up on why

Re: Stream Method Proposal: long count(Predicate predicate)

2018-11-11 Thread James Roper
Another reason to prefer a smaller API is that it can aid the ability to comprehend, since there's less concepts to understand. The idea behind design patterns is that APIs constrain themselves to just using the well established and understood patterns, which means when someone who has never seen

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-11 Thread Andy Herrick
On 11/9/2018 5:25 PM, Andy Herrick wrote: This is an update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool This refresh renames the packages used to jdk.jpackager