Re: Re[4]: The new optimized version of Dual-Pivot Quicksort

2018-11-15 Thread Laurent Bourgès
Hi all Sorting experts, I want to let you know I am building a Sorting benchmark suite myself based on contributions of Sebastian Wild (forked github repo) & Vladimir on github (MIT license): https://github.com/bourgesl/nearly-optimal-mergesort-code I hope to exploit JMH in a short future to

RFR: 8213920 : Use {@systemProperty} tag for properties listed in System.getProperties

2018-11-15 Thread Priya Lakshmi Muthuswamy
Hi, Kindly review the fix for https://bugs.openjdk.java.net/browse/JDK-8213920 webrev: http://cr.openjdk.java.net/~pmuthuswamy/8213920/webrev.00/ Thanks, Priya

Re: FYI: new javadoc tag to document system properties

2018-11-15 Thread Weijun Wang
I had also thought about this. In JCE, the API and implementation (aka provider) might even be in different modules, if some system properties only apply a specific provider, we can put them into module-info.java of that module. We do support the new tag in module-info.java, right? Thanks Max

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-11-15 Thread Kim Barrett
> On Oct 3, 2018, at 3:13 PM, Kim Barrett wrote: > > I've submitted a JEP for > > (1) enabling the use of C++14 Language Features when building the JDK, > > (2) define a process for deciding and documenting which new features > can be used or are forbidden in HotSpot code, > > (3) provide an

RFR: 8130264 : change the mechanism by which JDK loads the platform-specific PrinterJob implementation

2018-11-15 Thread Phil Race
bug: http://cr.openjdk.java.net/~prr/8130264/ webrev: http://cr.openjdk.java.net/~prr/8130264/ Currently java launcher code embeds the name of the java.desktop module's PrinterJob implementation class for each platform in a system property which is later read by the java.desktop code to use to

Re: RFR (JDK 12/java.base) 8213325: (props) Properties.loadFromXML does not fully comply with the spec

2018-11-15 Thread Joe Wang
Hi Daniel, I deleted the endDTD method. It could have been used to signal the end of DTD parsing and therefore serve as a validation point. However, the parser would have thrown Exceptions if a DTD parsing wasn't completed properly, that seems to make an endDTD check unnecessary, at least as

Re: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-15 Thread Phil Race
I don't know how much of a security concern it is, and this is a developer tool, but in general we have used JNI + API for registry queries. Perhaps because this is a non-performance sensitive developer tool there was a thought that it was OK. So I would myself have used the API and think

RE: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-15 Thread Andrew Luo
I noticed in WindowsRegistry.java we're actually making calls to reg(.exe) and parsing the output/result. Is this preferred over making direct calls to the WINAPI functions via JNI? (Also, would this be a security concern if another reg.exe is in the PATH before the Windows system one?)

Re: [12]RFR 8210408: Refactor java.util.ResourceBundle:i18n shell tests to plain java tests

2018-11-15 Thread naoto . sato
Looks good to me. Naoto On 11/14/18 6:39 PM, Dora Zhou wrote: Hello, Please help review the fix for refactor java.util.ResourceBundle:i18n shell tests to plain java tests. Thank you. Shell Tests: test/java/util/ResourceBundle/modules/appbasic2/appbasic2.sh

Re: FYI: new javadoc tag to document system properties

2018-11-15 Thread Roger Riggs
Hi, If a system property is defined and specified as supported then it needs a public declaration and specification as part of the public class or package documentation. Checking for and adding the tag will be a good way to reconfirm property definitions are in the right place. Would it be

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

2018-11-15 Thread Roger Riggs
Hi Brian, Looking good. I would add a message to the thrown IOException @598:  "Unable to skip exactly". Adding a @see to skip(n) would be a good addition to recommend using skipNBytes. Thanks, Roger On 11/14/2018 08:21 PM, Brian Burkhalter wrote: Hi Brent / Daniel, On Nov 9, 2018, at

Re: FYI: new javadoc tag to document system properties

2018-11-15 Thread Xuelei Fan
In JCE and JSSE, the public APIs definition (javax.net.ssl) and the internal implementation (sun.security.ssl) are separated. The system property can be defined in the internal implementation classes. I think we should add the @systemProperty on the public APIs, right? The public API class

Re[4]: The new optimized version of Dual-Pivot Quicksort

2018-11-15 Thread Vladimir Yaroslavskiy
Hello, Tagir! I compared Radix sort with Dual-Pivot Quicksort and see that Radix sort is faster than DPQ (on 2M elements) on random data in twice times, but it works slower on repeated elements (in 3-7 times). For highly structured arrays merging sort is invoked in both cases. Other data types -

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-15 Thread Andy Herrick
On 11/10/2018 8:12 AM, Sverre Moe wrote: I have been using the jpackager that Johan Vos backported for OpenJDK 11. For this I have some points of improvement I would like to mention. 1) The control file for debian package does not set correct description --name test --description This is a

RE: FW: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

2018-11-15 Thread Baesken, Matthias
Thanks for the reviews ! > -Original Message- > From: Alan Bateman > Sent: Donnerstag, 15. November 2018 11:08 > To: Baesken, Matthias ; Langer, Christoph > > Subject: Re: FW: RFR : 8211106: [windows] Update OS detection code to > recognize Windows Server 2019 > > On 15/11/2018 10:22,

Re: RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

2018-11-15 Thread Daniel Fuchs
Looks good to me Jon! Thanks for taking care of that. best regards, -- daniel On 15/11/2018 00:01, Jonathan Gibbons wrote: Please review the removal of two extraneous in HttpClient.java. $ hg diff -R open diff -r 40098289d580 src/java.net.http/share/classes/java/net/http/HttpClient.java

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

2018-11-15 Thread Daniel Fuchs
Hi Brian, This looks good to me now. best regards, -- daniel On 15/11/2018 01:21, Brian Burkhalter wrote: I tend to agree that covering this sort of aberration is probably a good idea. I have updated the patch per the foregoing comments and have also improved the Skip test:

Re[2]:

2018-11-15 Thread Vladimir Yaroslavskiy
Hi Laurent, Actually the author of this test suite is Jon L. Bentley. I got Java version from Josh Bloch and later fixed minor bug and improved output. From my side no objections to put this code on github. Regards, Vladimir >Четверг, 15 ноября 2018, 10:23 +03:00 от Laurent Bourgès >: > >Hi