Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions

2018-12-01 Thread Vladimir Kozlov
All tests passed. Vladimir On 12/1/18 4:37 PM, Vladimir Kozlov wrote: I am fine with Hotspot changes. But we need to verify changes on all platforms. I see that aarch64 also supports it in addition to SPARC. I will run compiler/codegen/aes/ test to make sure it pass on SPARC but we don't tes

Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions

2018-12-01 Thread Vladimir Kozlov
I am fine with Hotspot changes. But we need to verify changes on all platforms. I see that aarch64 also supports it in addition to SPARC. I will run compiler/codegen/aes/ test to make sure it pass on SPARC but we don't test aarch64. I let you know testing results when they are done. Thanks, Vl

Re: RFR: 8212703: Remove sun.java2d.fontpath property from java launcher code

2018-12-01 Thread Alan Bateman
On 30/11/2018 23:11, Roger Riggs wrote: Hi Phil, That looks fine. Too bad it introduces a new shell test, we're trying to get rid of them. The other alternative would have the test program needed to set the environment and launch a java program. The implementation look good to me too and I a

RFR: JDK-8066619: String(byte[],int,int,int) in String has been deprecated in Manifest and Attributes

2018-12-01 Thread Philipp Kunz
Find the proposed patch attached. Some comments and explanations, here: There is a quite interesting implementation in Manifest and Attributes worth quite some explanation. The way it used to work before was: 1. put manifest header name, colon and space into a StringBuffer -> the buffer now conta

jar --verify operation mode checking mrjar validity

2018-12-01 Thread Christian Stein
Hi, jar --create (and --update) perform type API validation checks when used in combination with --release option. This detects invalid "version overlays" at package time, where the API doesn't match a previous one. Having a jar --verify mode that performs the same checks consuming an already exi