Re: RFR: 8214570 : Use {@systemProperty} for definitions of system properties

This looks okay to me (cc'ing security-dev as that is where the smart card I/O API is maintained) On 18/12/2018 05:23, Priya Lakshmi Muthuswamy wrote: Hi, Kindly review the changes for https://bugs.openjdk.java.net/browse/JDK-8214570 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8214570/

Re: RFR: JDK-8066619: String(byte[],int,int,int) in String has been deprecated in Manifest and Attributes

Thanks. Find a new patch attached. On Mon, 2018-12-17 at 12:12 -0500, Roger Riggs wrote: > Hi Philipp, > > > > Manifest.java: > > > >  - Line 258: creating a new array for two characters on each call > isn't as efficient as: > >     out.write('\r');  > >    

Re: RFR: JDK-8066619: String(byte[],int,int,int) in String has been deprecated in Manifest and Attributes

Thanks for pointing out about ISC. I replaced it with StringBuilders but now I don't know with what capacity to initialize. Also the previous code does not reveal a conscious choice about the buffer capacity. So I arbitrarily chose 72 as an initial capacity which is one line. Any suggestions? Ideal

RFR: 8214570 : Use {@systemProperty} for definitions of system properties

Hi, Kindly review the changes for https://bugs.openjdk.java.net/browse/JDK-8214570 webrev : http://cr.openjdk.java.net/~pmuthuswamy/8214570/webrev.00/ Thanks, Priya

Re: [PATCH] improve javadoc in TreeSet#add api documentation

Hello Stuart, Kindly find the diff file attached for your reference. Request you to review and provide your feedback. Once we finalize SortedSet, I'll start to enhance TreeSet documentation. Thank you, Kishor Gollapalliwar On Tue, Dec 18, 2018 at 4:13 AM Stuart Marks wrote: > Hi Kishor, > > N

Re: Adding Path-based constructors to various classes

Hi Andrew, java.nio.channels.FileChannel pretty much covers RandomAccessFile, I think. The ZipFile case is something else, not really in I/O. Thanks, Brian > On Dec 17, 2018, at 4:56 PM, Andrew Luo > wrote: > > Hi Brian, > > Thanks for your thoughts on this. I agree that if a class is su

RE: Adding Path-based constructors to various classes

Hi Brian, Thanks for your thoughts on this. I agree that if a class is superseded by a newer NIO.2 class with Path APIs, we should not add the Path-based APIs to the older class, but I do not believe there are NIO.2 replacements that supersede ZipFile. I also don't believe that there are any

Re: Adding Path-based constructors to various classes

(looping in nio-dev) Hi Andrew, The NIO APIs (Java 1.4) were intended to supplement the pre-existing Java I/O APIs and this effort was continued in the NIO.2 APIs (Java 7). The Path interface is part of the latter. My impression is that the intent was more to supersede the older APIs than to e

Re: RFR(XS): 8215009: GCC 8 compilation eror in libjli

On 11/12/2018 9:30 pm, Dmitry Chuyko wrote: On 12/11/18 4:03 AM, David Holmes wrote: Hi Dmitry, On 11/12/2018 12:16 am, Dmitry Chuyko wrote: Hello, Please review a small fix in java_md_solinux.c: continuation is not truly compatible with pthread_create start_routine's signature but we contr

Adding Path-based constructors to various classes

Many classes such as: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/io/RandomAccessFile.html https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/zip/ZipFile.html have constructors that use the File API or String but no constructor that takes Path. Is there

Re: [PATCH] improve javadoc in TreeSet#add api documentation

Hi Kishor, No problem about the delay; I've certainly contributed to delays myself. And certainly I have an unbounded queue of things I'm working on myself at the moment. And no, it's not too late for this work! In the past, if you missed a JDK deadline, you might have to wait three years for

Re: jpackage EA Build 0

On 12/17/2018 12:45 PM, Scott Palmer wrote: I finally got to the point where I can play with this… I’m just using trial and error, trying to figure out what to do based on the output of package --help and responding to error messages to guide me. I’ve already used jlink to create a runtime

Re: RFR (S): 8215472: Cleanups in implementation classes of jdk.zipfs and tests

HI Christoph > On Dec 17, 2018, at 5:38 AM, Claes Redestad wrote: > > Hi Christoph, > > I believe the convention in the OpenJDK sources is to sort static > imports after non-static, so changing to the other way around in a few > places adds inconsistencies. > > In ZipFileSystem you remove the u

RFR - CSR JDK-8215499 - String::indent inconsistency with blank lines

Please review CSR: https://bugs.openjdk.java.net/browse/JDK-8215499 Thank you. — Jim

Re: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

The change to the langtools test looks OK -- Jon On 12/15/18 1:40 AM, Alan Bateman wrote: This is test only change to fix a few tests that don't have complete @modules or --add-exports options and so fail when running jtreg with vmoption:--illegal-access=deny. The only change that might not

Re: jpackage EA Build 0

I finally got to the point where I can play with this… I’m just using trial and error, trying to figure out what to do based on the output of package --help and responding to error messages to guide me. I’ve already used jlink to create a runtime (including JavaFX) that I want to use with my no

Re: 8215449: Several tests failing when jtreg run with -vmoption:--illegal-access=deny

On 12/15/18 1:40 AM, Alan Bateman wrote: This is test only change to fix a few tests that don't have complete @modules or --add-exports options and so fail when running jtreg with vmoption:--illegal-access=deny. The only change that might not be obvious is to langtools/tools/javac/platform

Re: jpackage EA Build 0

Building a non-modular app on macOS: In the output folder I find a .dmg file and a .pkg file. However, the .dmg produced contains both the application bundle AND the .pkg installer. It should not contain the .pkg Scott > On Dec 14, 2018, at 7:46 AM, Andy Herrick wrote: > > I am pleased to

Re: RFR: JDK-8066619: String(byte[],int,int,int) in String has been deprecated in Manifest and Attributes

Hi Philipp, Manifest.java:  - Line 258: creating a new array for two characters on each call isn't as efficient as:     out.write('\r');     out.write('\n'). The new test that need internal access can gain that access by adding:    @modules java.base/java.util.jar:+open That instructs testng

Re: JDK-8210280 - Unnecessary reallocation when invoking HashMap.putAll()

All tests I've run passed, benchmarks show ~15% performance boost for putAllWithBigMapToNonEmptyMap. On 12/17/18 7:32 AM, Michal Vala wrote: Hi, thanks Doug, this is nice reduction. Here's the new webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8210280/webrev.03/ Just a nitpick, issu

Re: JDK-8165199: UUID.fromString(str) compliance checking?

Hi, I could imagine a more performant implementation as Claes suggested by expecting the format and only those characters defined by the rfc 4122. And it could retain compatibility by faulting back to the current implementation for other formats and characters outside of those in the rfc. But

Re: jpackage EA Build 0

One more thing discovered: Even though the version is defined in DEB control file, the deb bundler does not use it for the deb file name. The RPM bundler does it right. It uses the version and release specified in the RPM spec file. application-1.0-deb application-1.2.3-rc1.rpm A workaround is to

Re: RFR (S): 8215472: Cleanups in implementation classes of jdk.zipfs and tests

Hi Christoph, I believe the convention in the OpenJDK sources is to sort static imports after non-static, so changing to the other way around in a few places adds inconsistencies. In ZipFileSystem you remove the unused method releaseDeflater - to me this indicates the resource pooling is actuall

Re: jpackage EA Build 0

I have discovered a bug with the jpackage created application image. It does not pass any --arguments to the application. The application.cfg contains the arguments, but the native binary does not pass them to the application. [ArgOptions] --laf=nimbus --test1=value1 --test2=value2 /Sverre

RFR (S): 8215472: Cleanups in implementation classes of jdk.zipfs and tests

Hi, when working with jdk.zipfs, I found some opportunity for cleanups. I'd like to contribute this independently from my other thread regarding Posix permissions in zip files (http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-November/056426.html). So, please help to review the cleanu