RFR: jsr166 integration 2019-02

https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html 8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/CountDownLatch-Basic/index.html https://bugs.openjdk.java.net/browse/JDK-81950

Re: RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

Hi Roger! That's because two tiny changes are combined in the patch: 1) remove a problematic statement from the javadoc, as it doesn't hold anyway. This part does not change the behavior. 2) unify type of the exception thrown for all negative values of CharSequence.length(). The regression

Re: RFR 8218228 : The constructor StringBuffer(CharSequence) violates spec for negatively sized argument

Hi Ivan, In the direction of not changing the behavior; the webrev does change the behavior. In the case of CharSeqence with length -1..-16, the new behavior throws NegativeArrayIndexException instead of java.lang.IndexOutOfBoundsException. AbstractStringBuilder:101-102 throw an exception

Re: JDK-8210280 - Unnecessary reallocation when invoking HashMap.putAll()

and ... finally committed (sorry as always for the sloth pace) On Wed, Feb 6, 2019 at 10:28 AM Martin Buchholz wrote: > Finally got around to doing some work on this. > I'm happy with this latest revision: > > > https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/HashMap-resize/in

Re: RFR(s): 8212828: (process) Change the Process launch mechanism default on Linux to be posix_spawn

Hi Thomas, The new OutputAnalyzer methods are new: 496: now that we have Immutable Lists, can the filterByKeyword argument be a List? List interesting = List.of( "fork", "clone", "vfork", "exec", "/bin/true", "jspawnhelper" ); 497: Instead of passing an int, pass the String itself 480, 485

Re: RFR 8216407 : java.util.UUID.fromString accepts input that does not match expected format

Gentle ping. So, do you think it is an appropriate fix? To emphasize: It is proposed to start rejecting only obviously incorrect UUIDs, which may help the applications, as they would fail earlier on invalid input. With kind regards, Ivan On 1/10/19 8:50 AM, Ivan Gerasimov wrote: Hi Roger!

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, A few higher level issues should be considered, though the details of the webrev captured my immediate attention. Is this the right feature and is this the right level of implementation (C++/native)? From a security perspective, adding field names to exceptions exposes information to ca

Re: RFR 8182117 : Document Zip File System Properties

Thank you for catching that Christoph, sometimes you see what you want to see :-) I will tweak that prior to the push once the CSR is approved Thank you and have a good weekend > On Feb 8, 2019, at 8:56 AM, Langer, Christoph > wrote: > > Hi Lance, > > I found a small nit (hopefully right i

Re: jpackage windows --version-swap --icon-swap weirdness

We have recently moved this functionality from jpackage.exe command line to a native library, (JDK-8217317). That being said, it sounds like there was a bug in the implementation, and that bug was moved with the code. I have filed bug JDK-8218681

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, On 02/08/2019 06:51 AM, Lindenmaier, Goetz wrote: ... though I think trying to produce signatures within the message is going to be very awkward in the general case. The key part is the "method NPE.b() ... returned from NPE.a()" Actually, I have left out code that changes the signat

Re: RFR 8205991: Cannot start application (WinLauncher) if path contains non-ascii character

I reopened this issue to fix in new jpackage. /Andy On 2/8/2019 5:58 AM, Tornai András wrote: Hi all, The issue was reported some time ago and it was closed (wont-fix) since javapackager was removed from JDK11. Hopefully jpackage will come back with JDK13 so I retested it with the latest jpac

jpackage windows --version-swap --icon-swap weirdness

Hi list, I'm using jpackage EA from https://jdk.java.net/jpackage/ to create a windows executable on windows 2012 R2 (jpackager create-image ...) The resulting exe file doesn't have the correct vendor and version information (it has openjdk 13 instead of my vendor name and version). It has the corr

RFR 8205991: Cannot start application (WinLauncher) if path contains non-ascii character

Hi all, The issue was reported some time ago and it was closed (wont-fix) since javapackager was removed from JDK11. Hopefully jpackage will come back with JDK13 so I retested it with the latest jpackage* and it seems that the issue is still there. Are there any plans to fix this? Regards, András

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

...just one thing if you go that route. Make sure to initialize the NPE_MESSAGE_PENDING to a new String("something") or else you may be sharing this constant reference with somebody else via string interning... 2019-02-08 16:01 GMT+01.00, Peter Levart : > Hi Goetz, > > In NPE: > > 97 Stri

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, In NPE: 97 String extendedMessage = getExtendedNPEMessage(super.getMessage()); ...do you expect super.getMessage() to return anything else than null? Wouldn't that only occur when there was a data race between two threads observing that lazyComputeMessage is strill true in the

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, > 91 synchronized (this) { > -> I think this is not needed here. The transient modifier for > lazyComputeMessage already implies the lock on the Object, I think. please ignore this comment, I'm wrong here. I confused transient with volatile... /Christoph

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, > ok, so here a new webrev just adding a setter for the field: > http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/02 > > ... and incorporating the other comments. Looks better 😊 I have a few additions to src/java.base/share/classes/java/lang/NullPointerException.java: 28 imp

RE: RFR 8182117 : Document Zip File System Properties

Hi Lance, I found a small nit (hopefully right in time before pushing): + * URI Scheme Used to Identity the Zip File System should probably be: + * URI Scheme Used to Identify the Zip File System (Identify instead of Identity) Thanks Christoph

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, ok, so here a new webrev just adding a setter for the field: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/02 ... and incorporating the other comments. Best regards, Goetz. > -Original Message- > From: David Holmes > Sent: Freitag, 8. Februar 2019 13:31 > To: Linde

Re: RFR: JDK-8217687: jpackage --help improvements

On 2/7/2019 5:11 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8217687/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html Line 140: I think we do not need " at the end. yes - will remove this before pus

Re: JDK-6982173: Small problem causing thousands of wasted CPU hours

Hello! > I would argue that iterating the argument and calling remove() on "this" are > the > right semantics, because you want set membership to be determined by this set, > not by whatever collection you pass as an argument. However, I note that > AbstractCollection.removeAll and other removeAl

Re: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, Just one follow up for now: * Add package visible "void setMessage (String msg)" to Throwable. Yes, just use package accessibility to deal with this, no need to jump through hoops (or the VM :) ). Thanks, David On 8/02/2019 9:51 pm, Lindenmaier, Goetz wrote: Hi David, Hi Vo

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi David, > Hi Volker, ... I assume Volker could have contributed this as well, but actually I must mention Ralf Schmelter as the original author of this :) > You know I'm not going to be a big fan of this :), but as long as we > don't pay for it if we don't want it, then that's okay. (I'm sti

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Christoph, thanks for looking at this. > src/java.base/share/classes/java/lang/NullPointerException.java: > line 56: > remove a space before the comment fixed. > line 62: private transient boolean lazyComputeDefaultMessage; > I think the name for this variable is not well chosen. I'd pre

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

> 122 private native void setDefaultMessage(String extendedMessage); > Here, I agree with David, that you should do it in Java. Just use a shared > secret, then you don't even need reflection... Addition: you should not even need to use a shared secret as Throwable and NPE are in the same pac

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, thanks for bringing this into OpenJDK finally. I know of people that'll be quite happy about this feature. I had a quick glance through the code. Here are a few findings: src/java.base/share/classes/java/lang/NullPointerException.java: line 56: remove a space before the comment line

Re: RFR(s): 8212828: (process) Change the Process launch mechanism default on Linux to be posix_spawn

Hi Roger, Martin, next version: http://cr.openjdk.java.net/~stuefe/webrevs/8213192--(process)-change-the-process-launch-mechanism-default-on-linux-to-be-posix_spawn/webrev.02/webrev - did massage the comment in ProcessImpl.c - made the test more resilient by scanning for the strace tool and by s