Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

Hi Andy, Updated changes looks fine. Thanks, Alexander On 2/22/2019 9:50 AM, Andy Herrick wrote: revised webrev t address issues brought up by Mandy: [2] http://cr.openjdk.java.net/~herrick/8218055/webrev.03 /Andy On 2/21/2019 8:54 PM, Mandy Chung wrote: On 2/21/19 4:49 PM, Andy Herrick

RFR: JDK-8218681 : Windows exe's generated by jpackage have wrong info

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - User provided version was not display, because it was added as additional LANG_ENGLISH resource and Windows Explorer was displaying default one adde

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

thanks :) Vicente On 2/22/19 2:50 PM, Mandy Chung wrote: On 2/22/19 8:37 AM, Vicente Romero wrote: Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ Looks good. [2

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

On 2/22/19 8:37 AM, Vicente Romero wrote: Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ Looks good. [2] https://bugs.openjdk.java.net/browse/JDK-8219587 Revie

Re: [13] RFR 8209175: Handle 'B' character introduced in CLDR 33 JDK update for Burmese (my) locale

+1 On 02/22/2019 01:53 PM, naoto.s...@oracle.com wrote: Hi Nishit, Looks good to me. One minor typo: Bundle.java:line 699 "SimpledateFormat" -> "SimpleDateFormat". No further review is needed for this. Naoto On 2/22/19 5:18 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8209175

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

On 2/22/19 9:50 AM, Andy Herrick wrote: revised webrev t address issues brought up by Mandy: [2] http://cr.openjdk.java.net/~herrick/8218055/webrev.03 I only looked at JLinkBundlerHelper.java and the removed files that look okay. Nit: can you use "jlink" lower case in the log/exception mes

Re: RFR(XS): 8215009: GCC 8 compilation eror in libjli

Hi, After a closer look, I'd take the route of the 01 webrev. It is more localized and does not force the function signature needed by pthread_create to be propagated elsewhere. The code can be a lot more comprehensible by renaming the CallIntFunc function to be specific to ContinueInNewThread0.

Re: [13] RFR 8209175: Handle 'B' character introduced in CLDR 33 JDK update for Burmese (my) locale

Hi Nishit, Looks good to me. One minor typo: Bundle.java:line 699 "SimpledateFormat" -> "SimpleDateFormat". No further review is needed for this. Naoto On 2/22/19 5:18 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8209175 Bug: https://bugs.openjdk.java.net/browse/JDK-8209175 We

Re: RFR(S) : 8219139 : move hotspot tests from test/jdk/vm

  Overall the change looks good; thank you Igor for doing this. I have couple of comments:   - I am in favor of the approach where we move tests first under corresponding sub-component directories in     test/hotspot sub-tree, and then figure out whether to keep them. Even though in general I

Re: RFR(XS): 8215009: GCC 8 compilation eror in libjli

Let me preface by saying that I don’t have a strong opinion about this. Like, at all. The problem with an inline cast is that it’s not necessarily correct, because it all depends on the ABI. For example, consider this case: double JavaMain(void* args) { … return 47.11; } int ContinueInNe

Re: Fix proposal: JDK-8219378 NPE in ReflectionFactory.newMethodAccessor when langReflectAccess not initialized

Hi Andrew, Thanks for the stack trace of the issue triggering this. It seems to me that Modifier:: isn't the right place to setLangReflectAccess shared secret. It might have assumed that Modifier should have been initialized when Field/Method or other AccessibleObject is instantiated which isn'

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

revised webrev t address issues brought up by Mandy: [2] http://cr.openjdk.java.net/~herrick/8218055/webrev.03 /Andy On 2/21/2019 8:54 PM, Mandy Chung wrote: On 2/21/19 4:49 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch

Re: can't create an image using jpackage and javafx

Il 21/02/19 22:39, Michael Hall ha scritto: On Feb 20, 2019, at 12:57 PM, Edoardo Panfili > wrote: LSOpenURLsWithRole() failed with error -10810 for the file /Users/edoardo/Desktop/java-next/asteroidi/Asteroids.app. That sounds like maybe an error from the open com

Re: RFR: JDK-8219480: j.l.c.ClassDesc::arrayType(int rank) throws IllegalArgumentException if rank = 0

Hi Mandy, Thanks for the review. I have uploaded a new iteration [1], please also review the CSR at [2] Vicente [1] http://cr.openjdk.java.net/~vromero/8219480/webrev.01/ [2] https://bugs.openjdk.java.net/browse/JDK-8219587 On 2/21/19 5:22 PM, Mandy Chung wrote: On 2/20/19 3:10 PM, Vicen

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

On 2/22/2019 8:06 AM, Mandy Chung wrote: On 2/22/19 6:17 AM, Andy Herrick wrote: On 2/21/2019 8:54 PM, Mandy Chung wrote: I only skimmed on the patch.  A couple of comments:   73 () -> new RuntimeException("link tool not found")); yes jlink should always exist in the JDK tha

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

On 2/22/19 6:17 AM, Andy Herrick wrote: On 2/21/2019 8:54 PM, Mandy Chung wrote: I only skimmed on the patch.  A couple of comments:   73 () -> new RuntimeException("link tool not found")); yes jlink should always exist in the JDK that jpackage is run from - I just copied this

Re: RFR(XS): 8215009: GCC 8 compilation eror in libjli

Hi, If the warning can be addressed with an extra in-line cast then that's cleaner and easier to understand than replicating that structure in 3 files. And of course, add a comment. To make the source more readable, the cast could be factored into a macro in the same file with the comment about w

Re: Fix proposal: JDK-8219378 NPE in ReflectionFactory.newMethodAccessor when langReflectAccess not initialized

On 22/02/2019 08:49, Andrew Leonard wrote: Hi Roger, I had a think about this and a testcase will be difficult, as it was found during OpenJ9 testing and occured during VM bootstrap, Can you say if the J9 failure was with an exploded build or an images build? Just asking as suggest we could trig

Re: Fix proposal: JDK-8219378 NPE in ReflectionFactory.newMethodAccessor when langReflectAccess not initialized

Hi Andrew, Thanks for the references and consideration.  I agree it will be hard to reproduce. It is an obvious oversight and is localized to a single file so I don't think a test case is necessary. Thanks, Roger On 02/22/2019 03:49 AM, Andrew Leonard wrote: Hi Roger, I had a think about t

Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.

On 2/21/2019 8:54 PM, Mandy Chung wrote: On 2/21/19 4:49 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This enhancement removes the use of jdk.tools.jlink.internal.pa

[13] RFR 8209175: Handle 'B' character introduced in CLDR 33 JDK update for Burmese (my) locale

Hi, Please review the fix for JDK-8209175 Bug: https://bugs.openjdk.java.net/browse/JDK-8209175 Webrev: http://cr.openjdk.java.net/~nishjain/8209175/webrev.03/ Issue: In CLDR 33 update, 'B' character has been added in date time patterns for Burmese locale, which is used to represent the day p

Re: JDK 13 RFR of JDK-8219561: Update jdeprscan to avoid the need for start-of-release changes

Looks good Joe! > On Feb 21, 2019, at 9:15 PM, Joe Darcy wrote: > > Set releasesWithForRemoval = Set.of("9", "10", "11", "12", "13");

Re: Manifest ignores last line if not terminated by line break

Its on my list, just have not time to look at it > On Feb 22, 2019, at 6:16 AM, Philipp Kunz wrote: > > Hi, > > Without any impatience, but may I ask if someone has read the previous > message or if there is any opinion about it? > > Regards, > Philipp > > On Fri, 2019-02-15 at 22:30 +0100, P

Re: JDK 13 RFR of JDK-8219561: Update jdeprscan to avoid the need for start-of-release changes

Looks good to me Joe! best regards, -- daniel On 22/02/2019 02:15, Joe Darcy wrote: Hello, Internally jdeprscan initializes a set of strings of releases supporting deprecation with removal. Currently those releases are JDK 9 and subsequent values. The lists is explicitly initialized and mus

Re: Manifest ignores last line if not terminated by line break

Hi, Without any impatience, but may I ask if someone has read the previous message or if there is any opinion about it? Regards, Philipp On Fri, 2019-02-15 at 22:30 +0100, Philipp Kunz wrote: > Hi, > > Manifest parsing an input stream given to the constructor or the read > method ignores the co

Re: can't create an image using jpackage and javafx

> On Feb 21, 2019, at 11:40 PM, Edoardo Panfili wrote: > > Il 21/02/19 22:39, Michael Hall ha scritto: >> >> >>> On Feb 20, 2019, at 12:57 PM, Edoardo Panfili >> > wrote: >>> >>> LSOpenURLsWithRole() failed with error -10810 for the file >>> /Users/edoardo/Desktop/

Re: Fix proposal: JDK-8219378 NPE in ReflectionFactory.newMethodAccessor when langReflectAccess not initialized

Hi Roger, I had a think about this and a testcase will be difficult, as it was found during OpenJ9 testing and occured during VM bootstrap, feel free to read further details here: https://github.com/eclipse/openj9/issues/3399#issuecomment-459004840 So the issue was discovered due to the bootstrap