Re: Proposal to enhance Stream.collect

2019-03-03 Thread August Nagro
Tagir, I slapped my forehead when I saw that StringBuilder's initialCapacity is the number of chars, and not added elements! The CollectorOp class I added for ReferencePipeline.collect(Collector) is so a concurrent + unordered collector may be pre-sized. I thought it was needed for completeness (

Re: Proposal to enhance Stream.collect

2019-03-03 Thread Tagir Valeev
Hello August. I'm not supporting the proposed spec change, but I have few comments about implementation (in case OpenJDK reviewers would support it). 1. joining(): Setting initial StringBuilder size to the number of characters which is equivalent to the number of stream elements would be a good i

Re: Proposal to enhance Stream.collect

2019-03-03 Thread August Nagro
Hi everyone, My implementation is at https://github.com/AugustNagro/presize-collectors-bench and I have a webrev here: http://august.nagro.us/presized-collectors/webrev/. The changes that I made were: - Add `default IntFunction sizedSupplier()` to Collector - Add 2 new Collector.of helper

RFR: JDK-8219678: CLI changes in jpackage

2019-03-03 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change modifies the CLI and other behavior as described in [1] [1] https://bugs.openjdk.java.net/browse/JDK-8219678 [2] http://cr.openjdk.java.ne

RFR: JDK-8219679: Help text changes in jpackage

2019-03-03 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8219679 [2] http://cr.openjdk.java.net/~herrick/8219679/ /Andy