RE: RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

2019-03-23 Thread Langer, Christoph
Hi Matthias, yes, I think this is generally a good way to go. In JLI_Open(const char* name, int flags), you should remove ret and only use fd, I think. (Currently it would return 0 in the _wopen case). Furthermore, I think it would be a good time to introduce a test now that exercises paths t

Re: When executing in module mode, the java command doesn't show the verifyError message details

2019-03-23 Thread Alan Bateman
On 23/03/2019 15:49, fo...@univ-mlv.fr wrote: : found the issue, it's more simple :) If you take a look to the error message, the module name is printed twice: Error: Unable to initialize main class fr.umlv.lazystaticfinal.Main in module module fr.umlv.lazystaticfinal Caused by: module fr

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation

2019-03-23 Thread Remi Forax
- Mail original - > De: "daniel smith" > À: "Brian Goetz" > Cc: "core-libs-dev" > Envoyé: Samedi 23 Mars 2019 16:13:29 > Objet: Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve > documentation >> On Mar 21, 2019, at 8:58 AM, Brian Goetz wrote: >> >> +1 from me. >> >>

Re: When executing in module mode, the java command doesn't show the verifyError message details

2019-03-23 Thread forax
- Mail original - > De: "Alan Bateman" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Samedi 23 Mars 2019 16:09:07 > Objet: Re: When executing in module mode, the java command doesn't show the > verifyError message details > On 23/03/2019 13:17, fo...@univ-mlv.fr wrote: >> : >> >> /

Re: RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation

2019-03-23 Thread Dan Smith
> On Mar 21, 2019, at 8:58 AM, Brian Goetz wrote: > > +1 from me. > > >> http://cr.openjdk.java.net/~dlsmith/8174222/webrev.00/ >> >> > > AbstractValidatingLMF > - > > I see you renamed most of the fields and params. Most of these are > improvements, but it may be wort

Re: When executing in module mode, the java command doesn't show the verifyError message details

2019-03-23 Thread Alan Bateman
On 23/03/2019 13:17, fo...@univ-mlv.fr wrote: : /usr/jdk/jdk-13/bin/java -Xlog:init=debug --enable-preview --module-path target/main/artifact:deps -m fr.umlv.lazystaticfinal Error: Unable to initialize main class fr.umlv.lazystaticfinal.Main in module module fr.umlv.lazystaticfinal Caused by:

Re: When executing in module mode, the java command doesn't show the verifyError message details

2019-03-23 Thread forax
- Mail original - > De: "Alan Bateman" > À: "Remi Forax" , "core-libs-dev" > > Envoyé: Samedi 23 Mars 2019 14:09:10 > Objet: Re: When executing in module mode, the java command doesn't show the > verifyError message details > On 23/03/2019 12:36, Remi Forax wrote: >> : >> >> /usr/jd

Re: When executing in module mode, the java command doesn't show the verifyError message details

2019-03-23 Thread Alan Bateman
On 23/03/2019 12:36, Remi Forax wrote: : /usr/jdk/jdk-13/bin/java --enable-preview --module-path target/main/artifact -m fr.umlv.lazystaticfinal Error occurred during initialization of boot layer java.lang.module.FindException: Module org.objectweb.asm.util not found, required by fr.umlv.lazys

When executing in module mode, the java command doesn't show the verifyError message details

2019-03-23 Thread Remi Forax
Hi all, When you run a main class which contains an invalid bytecode sequence using the class-path you get: /usr/jdk/jdk-13/bin/java --enable-preview --class-path target/main/artifact/fr.umlv.lazystaticfinal-1.0.jar fr.umlv.lazystaticfinal.Main Error: Unable to initialize main class fr.umlv.laz