Hi Naoto,
Thanks for review. I will update the copyright information and push the changes.
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Friday, March 22, 2019 10:59 PM
To: Deepak Kejriwal ; core-libs-dev
; jdk8u-...@openjdk.java.net
Subject: Re: RFR: JDK8U Backport of
Hi Thomas,
A few queries, comments and concerns ...
On 25/03/2019 6:58 am, Thomas Stüfe wrote:
Hi all,
After a long time I tried to build a Windows 32bit VM (VS2017) and failed;
I'm somewhat surprised as I thought someone was actively doing Windows
32-bit builds out there, plus there are
Hi all,
After a long time I tried to build a Windows 32bit VM (VS2017) and failed;
multiple errors and warnings. Lets reverse the bitrot:
cr:
http://cr.openjdk.java.net/~stuefe/webrevs/8221375--windows-32bit-build-(vs2017)-broken-in-many-places/webrev.00/webrev/
Issue:
Hi Bernd,
we had that discussion about JDK-8211752:
https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-December/057370.html
There were objections against making this addition to jdk.includeInExceptions
and the patch that Matthias proposed was also considered incomplete (e.g. not
all
Hi Ivan,
thanks for looking closely.
> UnixFileSystem_md.c:
> Should the second error message be "Could not close file"?
Yes, maybe that's better. Though it's really just the fallback, one could at
least distinguish the two possibilities of IOException in this method...
> UnixFileSystem.java:
Hi Matthias,
yes, I think this is generally a good way to go.
In JLI_Open(const char* name, int flags), you should remove ret and only use
fd, I think. (Currently it would return 0 in the _wopen case).
Furthermore, I think it would be a good time to introduce a test now that
exercises paths
