Re: RFR: 8221397 Support implementation-defined Map Modes

On 09/04/2019 17:49, Alan Bateman wrote: > On 09/04/2019 17:02, Andrew Dinn wrote: >> In response to Alan's suggestion (included below) I have reverted the >> constructor for MapMode to private and will use behind the scenes access >> to construct the extended enum values. >> >> This change removes

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

On 09/04/2019 19:30, Andrew Haley wrote: > On 4/9/19 11:42 AM, Andrew Dinn wrote: >> This new API method was conceived as a preliminary change for JEP 352 to >> allow selective writeback of NVRAM-backed buffers. However, it has been >> implemented to provide a similar capability for file-mapped byt

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

On 09/04/2019 19:15, Brian Burkhalter wrote: > >> On Apr 9, 2019, at 10:59 AM, Alan Bateman > > wrote: >> >> There are a couple of implementation details to discuss > > I was wondering whether this topic has any synergy / overlap with this > prior thread [1] the pr

Re: RFR: 8221397 Support implementation-defined Map Modes

On 10/04/2019 09:34, Andrew Dinn wrote: : Does that mean it is ok to push this now or do I need a second reviewer? One Reviewer is fine but you need to finalize the CSR and wait for that to be approved before pushing. -Alan

String.join for Iterable, not just CharSequence

Hi I was wonder if there had been any considerations adding an overloaded String.join method, that take an Iterable as argument, and a Function String join(CharSequence delimiter, Iterable elements, Function mappingFunction) { Objects

Re: RFR: 8221836: Avoid recalculating String.hash when zero

On 2019-04-09 15:03, Andrew Dinn wrote: How about this: http://cr.openjdk.java.net/~redestad/8221836/open.03/ Yes, that looks fine. Thanks, Andrew. I'll push this shortly. /Claes

Re: RFR: 8222029: Optimize Math.floorMod

I found a few missing corner cases in the existing test (all permutations of [MIN|MAX]/[MIN|MAX]), so I added them and verified the test pass both with and without my patch: http://cr.openjdk.java.net/~redestad/8222029/open.01/ /Claes On 2019-04-09 21:06, Claes Redestad wrote: In my cursory an

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

On 09/04/2019 18:59, Alan Bateman wrote: > There are a couple of implementation details to discuss but I'll stick > to the API/javadoc for now so that you can create the CSR. Ok, thanks. > We discussed the method signature, parameter types, and the semantics in > previous mails so I think they ar

RFR: CSR: JDK-8222261: MappedByteBuffer.force method to specify range

Could I please get a review for the following CSR which accompanies JDK-8221696 JIRA: https://bugs.openjdk.java.net/browse/JDK-861 regards, Andrew Dinn --- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Direc

RE: RFR (S): 8221979: Cleanups for building Windows resources

Thanks, Erik. I already checked and will check carefully once again before pushing. /Christoph > -Original Message- > From: Erik Joelsson > Sent: Dienstag, 9. April 2019 15:22 > To: Langer, Christoph ; build- > d...@openjdk.java.net; hotspot-...@openjdk.java.net; core-libs-dev > > Subj

Re: [8u] 8205432: Replace the placeholder Japanese era name

Thanks, Andrew. :) On 4/9/19, 10:27 AM, "Andrew John Hughes" wrote: On 09/04/2019 18:18, Hohensee, Paul wrote: > I meant the current webrev > > https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/ > > is fine. Just backport what's in tip and fix whatever's w

RFR(s): 8217405 rmic should reject class files with preview features enabled

Hi all, Please review this small fix to rmic to make it reject class files that were compiled with preview features enabled. Bug: https://bugs.openjdk.java.net/browse/JDK-8217405 Webrev: http://cr.openjdk.java.net/~smarks/reviews/8217405/webrev.0/ Note that there is no regr

Re: RFR(s): 8217405 rmic should reject class files with preview features enabled

Looks OK Stuart :-) > On Apr 10, 2019, at 9:22 PM, Stuart Marks wrote: > > Hi all, > > Please review this small fix to rmic to make it reject class files that were > compiled with preview features enabled. > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8217405 > > Webrev: > >

Re: String.join for Iterable, not just CharSequence

Hi Michael, This seems focused rather too narrowly on the task of joining strings obtained by applying exactly one mapper. It doesn't help if the task is something other than joining, and it doesn't help if there is something other than exactly one mapper. You'd then have to fall back to using