Re: RFR: JDK-8222676: create-installer with --app-image fails on mac

looks good to me - will test it tomorrow with my test cases. /Andy On 4/18/2019 8:05 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed issue when app image is

RFR: JDK-8222676: create-installer with --app-image fails on mac

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed issue when app image is located at root of working folder, since fix for JDK-8219144 assumed app image located under some folder other then

Re: [13] Review Request: 8220134 Cleanup the code in java.base which take care about multiple AppContext

I have found one of the removed test in the ProblemList, webrev is updated in place. On 18/04/2019 15:41, Sergey Bylokhov wrote: Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8220134 Fix: http://cr.openjdk.java.net/~serb/8220134/webrev.00 The

[13] Review Request: 8220134 Cleanup the code in java.base which take care about multiple AppContext

Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8220134 Fix: http://cr.openjdk.java.net/~serb/8220134/webrev.00 The AppContext class was used as a kind of "sandbox" in case of applets/webstart. Both applets and webstart were removed from the jdk11, since

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

On 4/18/2019 2:23 PM, Andy Herrick wrote: On 4/18/2019 5:21 PM, Phil Race wrote:  173 \  This Option can be used Multiple times.\n\ Why the capitalisation ? no reason - will revise One other issue with the help message: +ERR_NoAddLauncherName=Error: --add-launcher option

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

On 4/18/2019 5:21 PM, Phil Race wrote:  173 \  This Option can be used Multiple times.\n\ Why the capitalisation ? no reason - will revise /Andy -phil. On 4/18/19 2:17 PM, Alexander Matveev wrote: Hi Andy, Looks good. Thanks, Alexander On 4/18/2019 12:49 PM, Andy Herrick

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

173 \ This Option can be used Multiple times.\n\ Why the capitalisation ? -phil. On 4/18/19 2:17 PM, Alexander Matveev wrote: Hi Andy, Looks good. Thanks, Alexander On 4/18/2019 12:49 PM, Andy Herrick wrote: Please review the jpackage fix for bugs [1] and [2] at [3]. This is a

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

Hi Andy, Looks good. Thanks, Alexander On 4/18/2019 12:49 PM, Andy Herrick wrote: Please review the jpackage fix for bugs [1] and [2] at [3]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222733

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

Hi, On 18.04.19 21:29, Brian Burkhalter wrote: On Apr 18, 2019, at 11:44 AM, Raffaello Giulietti > wrote: here's another revision of the patch. Its purpose is to overcome the test failure observed in [1]. To this end, the patch adds

RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

Please review the jpackage fix for bugs [1] and [2] at [3]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222733 [2] https://bugs.openjdk.java.net/browse/JDK-8222731 [3]

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

> On Apr 18, 2019, at 11:44 AM, Raffaello Giulietti > wrote: > > here's another revision of the patch. Its purpose is to overcome the test > failure observed in [1]. To this end, the patch adds > > FloatToDecimal.appendTo(float, Appendable) and > DoubleToDecimal.appendTo(double, Appendable)

Re: [13] RFR (XXS): 8222668: Add @since tag to JapaneseEra.REIWA

+1 > On Apr 18, 2019, at 11:27 AM, naoto.s...@oracle.com wrote: > > Hello, > > Please review this trivial change to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8222668 > > Here is the one line change to add the @since tag: > > ---

Re: [13] RFR (XXS): 8222668: Add @since tag to JapaneseEra.REIWA

> On 18 Apr 2019, at 16:27, naoto.s...@oracle.com wrote: > > Hello, > > Please review this trivial change to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8222668 > > Here is the one line change to add the @since tag: > > ---

[13] RFR (XXS): 8222668: Add @since tag to JapaneseEra.REIWA

Hello, Please review this trivial change to the following issue: https://bugs.openjdk.java.net/browse/JDK-8222668 Here is the one line change to add the @since tag: --- old/src/java.base/share/classes/java/time/chrono/JapaneseEra.java 2019-04-17 13:38:30.0 -0700 +++

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

Hi Alan, The CSR for this issue has been finalized and is awaiting approval. Would it now be possible to proceed with reviews of the implementation? JIRA: https://bugs.openjdk.java.net/browse/JDK-8221696 webrev: http://cr.openjdk.java.net/~adinn/8221696/webrev.01 regards, Andrew Dinn

Re: [PING2] RFR: 8217338: [Containers] Improve systemd slice memory limit support

Hi, On Thu, 2019-04-18 at 09:00 +1000, David Holmes wrote: > So you can add me as a reviewer. Thank you, David! I appreciate that. Cheers, Severin

RE: ZipFileSystem performance regression

Hi Alan already proposed the following RFEs when NIO2 was introduced: a memory FileSystemProvider [1], and a virtual FileSystemProvider [2] With these, the javac use case could work as follows: 1) create a VirtualFileSystem, with all sources mounted under “/src”, a MemoryFileSystem mounted