Re: RFR: 8212701: remove sun.desktop property from launcher code

2019-04-22 Thread Alan Bateman
On 22/04/2019 21:57, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8212701 CSR: https://bugs.openjdk.java.net/browse/JDK-8222814 Webrev: http://cr.openjdk.java.net/~prr/8212701/index.html The launcher changes look fine. -Alan

Re: [8u-dev] RFR (S): JDK-8194653: Deadlock involving FileSystems.getDefault and System.loadLibrary call

2019-04-22 Thread Alan Bateman
On 22/04/2019 23:11, David Holmes wrote: Hi Ryan, On 23/04/2019 7:04 am, Sciampacone, Ryan wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8194653 Webrev: http://cr.openjdk.java.net/~phh/8194653/webrev.00/ Why does this need to be pushed to the VM? Why not do the pre-loading/initializi

Re: RFR: 8212701: remove sun.desktop property from launcher code

2019-04-22 Thread Sergey Bylokhov
Looks fine. On 22/04/2019 13:57, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8212701 CSR: https://bugs.openjdk.java.net/browse/JDK-8222814 Webrev: http://cr.openjdk.java.net/~prr/8212701/index.html Please review the above CSR and webrev which eliminates the sun.desktop system

Re: [8u-dev] RFR (S): JDK-8194653: Deadlock involving FileSystems.getDefault and System.loadLibrary call

2019-04-22 Thread David Holmes
PS. Given you have implemented this in the VM you're asking for a review on the wrong mailing list. David On 23/04/2019 7:04 am, Sciampacone, Ryan wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8194653 Webrev: http://cr.openjdk.java.net/~phh/8194653/webrev.00/ Eliminates a race conditi

Re: [8u-dev] RFR (S): JDK-8194653: Deadlock involving FileSystems.getDefault and System.loadLibrary call

2019-04-22 Thread David Holmes
Hi Ryan, On 23/04/2019 7:04 am, Sciampacone, Ryan wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8194653 Webrev: http://cr.openjdk.java.net/~phh/8194653/webrev.00/ Why does this need to be pushed to the VM? Why not do the pre-loading/initializing at the Java level? Cheers, David

[8u-dev] RFR (S): JDK-8194653: Deadlock involving FileSystems.getDefault and System.loadLibrary call

2019-04-22 Thread Sciampacone, Ryan
Bug: https://bugs.openjdk.java.net/browse/JDK-8194653 Webrev: http://cr.openjdk.java.net/~phh/8194653/webrev.00/ Eliminates a race condition on call to java.nio.file.FileSystems::getDefault() where two threads (one inside a loadLibrary() call) could cause a deadlock if they both referenced this

RFR: 8212701: remove sun.desktop property from launcher code

2019-04-22 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8212701 CSR: https://bugs.openjdk.java.net/browse/JDK-8222814 Webrev: http://cr.openjdk.java.net/~prr/8212701/index.html Please review the above CSR and webrev which eliminates the sun.desktop system property which was set in launcher code to the va

Re: Feature suggestion: Allow generic wildcard in class literal expression

2019-04-22 Thread some-java-user-99206970363698485155
What do you think about this idea? I hope the fact that I did not get any responses yet does not mean that you are not interested or that I annoyed you. > JDK-6184881 describes that Object.getClass() should ideally not return > classes of raw types anymore but instead use wildcards. The problem

RFR - JDK-8212975 ClassDesc should have a full name method

2019-04-22 Thread Jim Laskey
ClassDesc.displayName(boolean detail) allows the user the option to fetch the fully qualified class name. webrev: http://cr.openjdk.java.net/~jlaskey/8212975/webrev-02 JBS: https://bugs.openjdk.java.net/browse/JDK-8212975

Re: RFR: 8215017: Improve String::equals warmup characteristics

2019-04-22 Thread Jim Laskey
+1 > On Dec 7, 2018, at 8:11 PM, Claes Redestad wrote: > > Hi, > > following up from discussions during review of JDK-8214971[1], I > examined the startup and peak performance of a few different variant of > writing String::equals. > > Webrev: http://cr.openjdk.java.net/~redestad/8215017/jdk.

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

2019-04-22 Thread Alan Bateman
On 18/04/2019 10:17, Andrew Dinn wrote: Hi Alan, The CSR for this issue has been finalized and is awaiting approval. Would it now be possible to proceed with reviews of the implementation? JIRA: https://bugs.openjdk.java.net/browse/JDK-8221696 webrev: http://cr.openjdk.java.net/~adinn/8221696

jpackage EA 6 Build 49 (2019/4/19)

2019-04-22 Thread Andy Herrick
A sixth EA build (Build 49) of jpackage tool is available at https://jdk.java.net/jpackage/ This release contains fixes to the following issues: JDK-8221777:  CLI changes from jpackage EA5 feedback JDK-8221779:  Help text changes from JDK-8221777 and other jpackage EA5 feedback JDK-8222733: