Re: RFR: 8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit

OK, looks fine then. On 5/7/19, 7:47 PM, Sergey Bylokhov wrote: Hi, Phil. Looks fine, but probably it will be worth to rename PlatformGraphicsInfo to PlatformInfo? I don't want (or intend) to do that. I already knew I was going to re-use this class for this purpose when I created it and adj

Re: RFR: 8222533 - jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine

Hi Bob, This fix seems quite reasonable. Thanks, David On 8/05/2019 6:25 am, Bob Vandette wrote: Please review this simple fix for a TestCgroupMetrics.java test failure. --- a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java +++ b/src/java.base/linux/classes/jdk/inter

Re: RFR: 8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit

On 5/7/19, 7:47 PM, Sergey Bylokhov wrote: Hi, Phil. Looks fine, but probably it will be worth to rename PlatformGraphicsInfo to PlatformInfo? I don't want (or intend) to do that. I already knew I was going to re-use this class for this purpose when I created it and adjusted the classname

Re: RFR: 8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit

Hi, Phil. Looks fine, but probably it will be worth to rename PlatformGraphicsInfo to PlatformInfo? On 06/05/2019 15:11, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8212700 CSR: https://bugs.openjdk.java.net/browse/JDK-8223417 Webrev: https://cr.openjdk.java.net/~prr/8212700

Re: RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

Changes look good to me, Misha On 5/7/19 5:56 AM, Bob Vandette wrote: Please review this change to the Container Metrics implementation. Change were made in JDK-8219562 [1] to osContainer_linux.cpp to correct the parsing of of the /proc/self/mountinfo file but corresponding changes to the Met

Re: RFR (M): JDK-6394757: AbstractSet.removeAll semantics are surprisingly dependent on relative sizes

Hi, Stuart. That all looks pretty good to me. I think, "membership semantics" is a good term. Just a few minor comments: Collection.java: 110 * that use different membership semantics. For operations that involve more than 111 * one collection, it is specified which collection's member

Re: RFR: 8222533 - jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine

Please make sure to update copyright year on the SubSystem.java before integration. Thank you, Misha On 5/7/19 1:51 PM, mikhailo.seledt...@oracle.com wrote: Looks good, Misha On 5/7/19 1:25 PM, Bob Vandette wrote: Please review this simple fix for a TestCgroupMetrics.java test failure.

Re: RFR: 8222533 - jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine

Looks good, Misha On 5/7/19 1:25 PM, Bob Vandette wrote: Please review this simple fix for a TestCgroupMetrics.java test failure. --- a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java +++ b/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java @@

Re: [13] RFR: 8221432: Upgrade CLDR to Version 35.1

Hi Steven, Thanks for your comments. My comments are embedded below. On 5/7/19 1:32 PM, Steven R. Loomis wrote: Hi Naoto,   The comment in http://cr.openjdk.java.net/~naoto/8221432/webrev.02/make/jdk/src/classes/build/tools/cldrconverter/Bundle.java.udiff.html "fix up 'Reiwa' era, which can

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi, Additional comments/observations on the jpackage webrev. Cleanup opportunities for more maintainable code. When using the ToolProvider API in an application that has a security manager, what permissions must be available?  Properties, files, ...? Main:  91: "processArguments" seems mis

RFR: 8222533 - jtreg test jdk/internal/platform/cgroup/TestCgroupMetrics.java fails on SLES12.3 linux ppc64le machine

Please review this simple fix for a TestCgroupMetrics.java test failure. --- a/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java +++ b/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java @@ -108,7 +108,7 @@ try { List lines = Fil

[13] RFR: 8221432: Upgrade CLDR to Version 35.1

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8221432 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8221432/webrev.02/ The webrev is big, but the large amount of the changes is simply replacing the CLDR data files from

Re: RFR: JDK-8222930: ConcurrentSkipListMapTest.clone() broken since jdk10

Thanks! Fix is now committed to jdk11, jdk12, jdk13. *From: *Adam Farley8 *Date: *Mon, Apr 29, 2019 at 3:16 AM *To: * *Cc: *Java Core Libs Hi All, > > Reviews and feedback requested for the fix. > > *http://cr.openjdk.java.net/~afarley/8222930.1/jdk13/webrev* >

Re: RFR: 8223402: Create tests for some Mac installer specific options

Hi Semyon, Looks good. Add space after several if statements. Thanks, Alexander On 5/7/2019 9:59 AM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8223402 webrev: http://cr.openjdk.java.net/~ssadetsky/8223402/webrev.00/ By this change tests added for jpackag

Re: An Interface equivalent for reflection

This is the wrong list, this list is about about the implementation of the core Java libraries, you are looking for the santa mailing list. Anyway, in your case, Java has already the notion of functional interface, an interface with one abstract method that can be used to store a reference to a

An Interface equivalent for reflection

I would like to request the addition of an Interface equivalent usable for reflection. Sometimes when writing a program it is desirable to have the client program specify how your program should behave in a specific scenario. Java's reflection can be used to obtain this method, but only if the clie

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, I've played with the messages a little bit and they generally look good. But I've come across two which look strange: - 'o[static Test.INDEX]' is null. Can not invoke method 'int java.lang.Object.hashCode()' - 'o[The return value of 'int java.lang.String.hashCode()]' is null. Can not

RFR: 8223402: Create tests for some Mac installer specific options

bug: https://bugs.openjdk.java.net/browse/JDK-8223402 webrev: http://cr.openjdk.java.net/~ssadetsky/8223402/webrev.00/ By this change tests added for jpackage Mac specific options: --mac-bundle-name --mac-bundle-identifier --mac-app-store-category --Semyon

Re: RFR (M): JDK-6394757: AbstractSet.removeAll semantics are surprisingly dependent on relative sizes

Stuart, That looks good. A tiny note on your FIXME comment [1]: 68 // FIXME: the first paragraph below is copied from Set.equals, because 69 // {@inheritDoc} will include text from Object.equals. You might want to check if it is the same as [2] or [3]. If it is the same, consider ad

Re: RFR: 8212700: Change the mechanism by which JDK loads the platform-specific AWT Toolkit

Hi Phil, The changes look fine. Thanks for the cleanup, Roger On 05/07/2019 12:01 AM, Philip Race wrote: On 5/6/19, 3:11 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8212700 CSR: https://bugs.openjdk.java.net/browse/JDK-8223417 Webrev: https://cr.openjdk.java.net/~prr

Re: [13] RFR: 8220037: Inconsistencies of generated timezone files between Windows and Linux

Looks fine. Thanks, Roger On 05/06/2019 03:40 PM, naoto.s...@oracle.com wrote: Thanks, Roger. Webrev is modified accordingly: http://cr.openjdk.java.net/~naoto/8220037/webrev.01/ Naoto On 5/6/19 11:59 AM, Roger Riggs wrote: Hi Naoto, CLDRConverter:   358-271: Is a lambda viable here?  Not

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, Please have a look at this further improved webrev: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/09/ http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/09-incremental/ Harold, Coleen, thanks for pointing me to those methods. I'm using them now. This simplifies the helper met

RFR: 8221340 - [TESTBUG] TestCgroupMetrics.java fails after fix for JDK-8219562

Please review this change to the Container Metrics implementation. Change were made in JDK-8219562 [1] to osContainer_linux.cpp to correct the parsing of of the /proc/self/mountinfo file but corresponding changes to the Metrics API and Container tests shou,d have been done to match this change.

Re: RFR (CSR) - JDK-8218285 ClassDesc should have a full name method

Thank you. > On May 7, 2019, at 8:45 AM, Maurizio Cimadamore > wrote: > > Looks good - only minor quibble is that the javadoc doesn't make it crystal > clear as to whether the qualified name uses dots or '/'. Should the javadoc > point at the term 'canonical name', or at Class::getCanonicalNa

Re: RFR (CSR) - JDK-8218285 ClassDesc should have a full name method

Looks good - only minor quibble is that the javadoc doesn't make it crystal clear as to whether the qualified name uses dots or '/'. Should the javadoc point at the term 'canonical name', or at Class::getCanonicalName (or both) ? https://docs.oracle.com/javase/specs/jls/se12/html/jls-6.html#jl