Re: RFR(s): 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

Hi Roger, David, second version: Full: http://cr.openjdk.java.net/~stuefe/webrevs/8223777-posix_spawn-no-exec-error/webrev.01/webrev/ Delta: http://cr.openjdk.java.net/~stuefe/webrevs/8223777-posix_spawn-no-exec-error/webrev_delta.01/webrev/ Answering Rogers remarks here since that should cover

Re: RFR 8223730 : URLClassLoader.findClass() can throw IndexOutOfBoundsException

Thank you Pavel and Brent for reviewing! With kind regards, Ivan On 5/13/19 4:47 PM, Brent Christian wrote: I think the change looks OK. I agree that this case is unlikely to come up in the real world, so no regtest seems acceptable; tag the bug with noreg-hard. (Another option might be a

Re: RFR: 8222276: (zipfs) Refactoring and cleanups to prepare for JDK-8213031

Hi Christoph, Thank you for taking this on. Overall this looks pretty good. A few comments ZipFileSystem initCEN() I think I understand why you made some of the changes here, but for initializing for example cen, and end, starting on line 137, was there a reason you are doing this outside o

RFR (M): JDK-6394757: rev1: AbstractSet.removeAll semantics are surprisingly dependent on relative sizes

Hi all, Here's an updated webrev for this change. The general direction of the change is the same as before. Differences are primarily additional wording in a few relevant places, plus editorial and markup tweaks. Highlights of changes from the previous webrev include: - addition of FIXME c

Re: RFR 8223730 : URLClassLoader.findClass() can throw IndexOutOfBoundsException

I think the change looks OK. I agree that this case is unlikely to come up in the real world, so no regtest seems acceptable; tag the bug with noreg-hard. (Another option might be a test in a seldom-run Tier that @requires a large amount of heap.) -Brent On 5/11/19 3:07 PM, Ivan Gerasimov

Re: RFR 8223730 : URLClassLoader.findClass() can throw IndexOutOfBoundsException

Ivan, This change looks good to me. It's a pity we can't use 3-args InputStream.readNBytes here. Unrelated to your change: it looks a bit wasteful to create a zero-length byte array only to throw it away later. We could probably pre-size it or at least make it a `private static final`? -Pavel >

Re: RFR(s): 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

On Mon, May 13, 2019 at 11:01 AM Thomas Stüfe wrote: > > Hi all, > > may I have please your opinions about the following change: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8223777 > webrev: > http://cr.openjdk.java.net/~stuefe/webrevs/8223777-posix_spawn-no-exec-error/webrev.00/webrev/ > [.

Re: RFR(s): 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

Hi Thomas, Some thoughts... Did you determine exactly how the failure of exec did not result in an IOException? The change at 696 just prevents an exception from getting overwritten but not one that is not thrown or was cleared. An improved test for a successful spawnChild could be added to

Re: RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc failed 6af4413c vs 0 ...)

Hi Christoph, The change seems reasonable. > On May 13, 2019, at 8:14 AM, Langer, Christoph > wrote: > > Hi, > > please review this fix of a regression in zipfs after JDK-8222532 [0]. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8223597 >

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

Would it be worth putting the logic in an aptly named (private) method? Something like: ... private long alignDown(long address, long alignment) { return address & ; } ... long mapBase = alignDown(address, ps); … Cheers, Mikael > On May 13, 2019, at 9:14 AM, Andrew Dinn wrote: > > Thank

Re: RFR : 8221696: MappedByteBuffer.force method to specify range

Thank you for looking at the patch. On 28/04/2019 18:09, Andrew Haley wrote: On 4/25/19 5:34 PM, Andrew Dinn wrote: long map_base = (address & ~(ps - 1)); This looks like a hard way to write long map_base = address & -ps; My version certainly uses more characters, that is for sure. H

RFR(s): 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

Hi all, may I have please your opinions about the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8223777 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8223777-posix_spawn-no-exec-error/webrev.00/webrev/ In short, since some weeks posix_spawn() is used on Linux to spawn chil

Re: RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc failed 6af4413c vs 0 ...)

Changes and new tests looks good, will csize always be > 0 for an empty file/channel? /Claes On 2019-05-13 14:14, Langer, Christoph wrote: Hi, please review this fix of a regression in zipfs after JDK-8222532 [0]. Bug: https://bugs.openjdk.java.net/browse/JDK-8223597 Webrev: http://cr.openjd

Re: RFR 8223593 : Refactor code for reallocating storage

Thanks for updating your patch. The updated code seems fine. -Pavel > On 11 May 2019, at 05:01, Ivan Gerasimov wrote: > > Hello! > > Please help review the updated fix. > > This new webrev includes changes suggested by Pavel, Peter and Roger. > > BUGURL: https://bugs.openjdk.java.net/browse/

Re: Process.exec with the linux posix_spawn mode has a bug

On Mon, May 13, 2019 at 4:11 PM Thomas Stüfe wrote: > > > On Mon, May 13, 2019 at 3:42 PM Thomas Stüfe > wrote: > >> >> Hi Martin, >> >> On Mon, May 13, 2019 at 2:08 PM Martin Buchholz >> wrote: >> >>> >>> >>> I am happy this is resolved and the intermittent behavior explained. Yes, we cou

Re: Process.exec with the linux posix_spawn mode has a bug

On Mon, May 13, 2019 at 3:42 PM Thomas Stüfe wrote: > > Hi Martin, > > On Mon, May 13, 2019 at 2:08 PM Martin Buchholz > wrote: > >> >> >> I am happy this is resolved and the intermittent behavior explained. Yes, >>> we could improve exception messages, especially since analyzing fork >>> scenar

Re: Process.exec with the linux posix_spawn mode has a bug

On Mon, May 13, 2019 at 4:08 PM Martin Buchholz wrote: > >>> I tried hard back in 2005 to provide pretty good java-level diagnostics >>> when subprocess starting failed somehow (see WhyCantJohnnyExec) . At least >>> the errno did get reported. >>> >>> >> I know your code. For many years I wonder

Re: Process.exec with the linux posix_spawn mode has a bug

> > >> I tried hard back in 2005 to provide pretty good java-level diagnostics >> when subprocess starting failed somehow (see WhyCantJohnnyExec) . At least >> the errno did get reported. >> >> > I know your code. For many years I wondered who Johnny is :) > https://en.wikipedia.org/wiki/Rudolf_F

Re: Process.exec with the linux posix_spawn mode has a bug

Hi Martin, On Mon, May 13, 2019 at 2:08 PM Martin Buchholz wrote: > > > I am happy this is resolved and the intermittent behavior explained. Yes, >> we could improve exception messages, especially since analyzing fork >> scenarios is cumbersome. >> > > I tried hard back in 2005 to provide pretty

RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc failed 6af4413c vs 0 ...)

Hi, please review this fix of a regression in zipfs after JDK-8222532 [0]. Bug: https://bugs.openjdk.java.net/browse/JDK-8223597 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/ The issue occurs when an empty file/channel is persisted into a zip file. The entry had already been co

Re: Process.exec with the linux posix_spawn mode has a bug

I am happy this is resolved and the intermittent behavior explained. Yes, > we could improve exception messages, especially since analyzing fork > scenarios is cumbersome. > I tried hard back in 2005 to provide pretty good java-level diagnostics when subprocess starting failed somehow (see WhyCant

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, On 13/05/2019 08:29, Langer, Christoph wrote: Hi Daniel, unfortunately, your proposed solution does not work with javac. I get this in the build: Oh darn. I should have double checked. Can we at least reduce the scope of the @SuppressedWarnings by introducing a private method t

RE: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Daniel, unfortunately, your proposed solution does not work with javac. I get this in the build: ...\mercurial\jdk\src\java.net.http\share\classes\jdk\internal\net\http\ExchangeImpl.java:103: error: method thenCompose in class CompletableFuture cannot be applied to given types;

RE: [13] RFR: JDK-8206879: Currency decimal marker incorrect for Peru

Hi Deepak, Minor, but it will be good if you change the test case name to something like TestPeruDecimalFormat.java or TestPeruCurrencyDecimalFormat instead of just using BugID. Regards, Ramanand. -Original Message- From: Naoto Sato Sent: Friday, May 10, 2019 6:12 PM To: Deepak Kejriwa