Re: RFR(s): (new approach) 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

Ping... Guys, I need some feedback on this. If we do not fix this issue, we may want to roll back the use of posix_spawn() as a default and return to vfork for JDK13. The fix has been tested in our nightlies for two nights in a row and did not show any errors. Cheers, Thomas On Mon, May 20, 20

Re: RFR: 8218997: Xusage text, man help, etc doesn't mention -Xlog option.

It was brought to my attention that the java.1 page is out of date and labeled for jdk 8, thus I will withdraw the change for java.1. Only keep the change to launcher.properties. Thanks for the review. Cheers, Henry > On May 21, 2019, at 5:26 PM, David Holmes wrote: > > That works for me. :)

Re: RFR: 8218997: Xusage text, man help, etc doesn't mention -Xlog option.

That works for me. :) Thanks, David On 22/05/2019 9:40 am, Henry Jen wrote: Good suggestion, didn’t know about that page. I took what’s in Xusage.txt. Updated as following, diff -r cd3c74c0 src/java.base/share/classes/sun/launcher/resources/launcher.properties --- a/src/java.base/share/c

Re: RFR: 8218997: Xusage text, man help, etc doesn't mention -Xlog option.

Good suggestion, didn’t know about that page. I took what’s in Xusage.txt. Updated as following, diff -r cd3c74c0 src/java.base/share/classes/sun/launcher/resources/launcher.properties --- a/src/java.base/share/classes/sun/launcher/resources/launcher.properties Tue May 21 15:08:50 2019 -

Re: RFR - JDK-8223775 String::stripIndent (Preview)

On 5/21/2019 2:10 PM, Jim Laskey wrote: Updated version http://cr.openjdk.java.net/~jlaskey/8223775/webrev-02 This webrev substantially updates the API spec, which is really a topic for amber-spec-experts (keep reading to see why). Cross-posting between -dev and -spec-experts lists is not goo

Re: RFR - JDK-8223780 String::translateEscapes (Preview)

Hi, Jim I have some comments on the CSR and the Webrev. CSR: "This method takes the receiver String a replaces escape sequences with character equivalents." a -> and -- In the specification, I like emphasizing that nothing happens to 'this', but rather to the returned string, so may

Re: RFR: 8218997: Xusage text, man help, etc doesn't mention -Xlog option.

Hi Henry, On 22/05/2019 8:41 am, Henry Jen wrote: Hi, Please review a trivial patch that add some hints about how to use -Xlog in java help and man page. diff -r cd3c74c0 src/java.base/share/classes/sun/launcher/resources/launcher.properties --- a/src/java.base/share/classes/sun/launcher

RFR: 8218997: Xusage text, man help, etc doesn't mention -Xlog option.

Hi, Please review a trivial patch that add some hints about how to use -Xlog in java help and man page. diff -r cd3c74c0 src/java.base/share/classes/sun/launcher/resources/launcher.properties --- a/src/java.base/share/classes/sun/launcher/resources/launcher.properties Tue May 21 15:08:5

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Updated version http://cr.openjdk.java.net/~jlaskey/8223775/webrev-02 > On May 21, 2019, at 3:11 PM, Alex Buckley wrote: > > On 5/21/2019 7:56 AM, Jim Laskey wrote: >> Please do a code review of the new String::stripIndent instance metho

Re: [13] RFR: 8224105: Cannot parse JapaneseDate string on some specified locales

Thanks. Looks good to me. -Brent On 5/21/19 11:33 AM, naoto.s...@oracle.com wrote: Thanks, Brent. Modified the webrev accordingly: http://cr.openjdk.java.net/~naoto/8224105/webrev.01/ Naoto On 5/21/19 11:03 AM, Brent Christian wrote: Hi, Naoto.  I have a couple comments. src/java.base/shar

RFR(XS): 8220072: GCC 8.3 reports errors in java.base

-dchuyko-JDK-8220072-1-20190521-1536-2605973: PASSED -Dmitry

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Hi, On 5/21/19 2:37 PM, Jim Laskey wrote: On May 21, 2019, at 3:27 PM, Vicente Romero wrote: Hi Jim, Some minor comments: - the javadoc for String::stripIndent needs some formating. There is a solitary "counted. The" Looking for a code review at this point. Will get to API soon. - at m

Re: RFR - JDK-8223780 String::translateEscapes (Preview)

Revised at http://cr.openjdk.java.net/~jlaskey/8223780/webrev-03/src/java.base/share/classes/java/lang/String.java.frames.html > On May 21, 2019, at 3:23 PM, Jim Laskey wrote

Re: RFR - JDK-8223775 String::stripIndent (Preview)

> On May 21, 2019, at 3:27 PM, Vicente Romero wrote: > > Hi Jim, > > Some minor comments: > > - the javadoc for String::stripIndent needs some formating. There is a > solitary "counted. The" Looking for a code review at this point. Will get to API soon. > - at method String::stripIndent,

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Thank you. I haven't really put the API out for CSR review as yet. This is current state remnant from Stuart's Raw String Literals CSR review. He and I hope to reform this very soon. Your comments will provide a good starting point. Cheers, -- Jim > On May 21, 2019, at 3:11 PM, Alex Buckley

Re: [13] RFR: 8224105: Cannot parse JapaneseDate string on some specified locales

Thanks, Brent. Modified the webrev accordingly: http://cr.openjdk.java.net/~naoto/8224105/webrev.01/ Naoto On 5/21/19 11:03 AM, Brent Christian wrote: Hi, Naoto.  I have a couple comments. src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java String.isEmpty()

Re: RFR - JDK-8223775 String::stripIndent (Preview)

Hi Jim, Some minor comments: - the javadoc for String::stripIndent needs some formating. There is a solitary "counted. The" - at method String::stripIndent, you can bail out and do nothing if outdent==0 - suggestion: method String::outdent could return a MapInteger> to indicate the first index

Re: RFR - JDK-8223780 String::translateEscapes (Preview)

> On May 21, 2019, at 2:57 PM, Ivan Gerasimov wrote: > > Hi Jim! > > A few comments: > > 1) > Probably, there's no need to update ch in these cases: >case '\'': >ch = '\''; >break; >case '\"': >ch = '

Re: RFR - JDK-8223775 String::stripIndent (Preview)

On 5/21/2019 7:56 AM, Jim Laskey wrote: Please do a code review of the new String::stripIndent instance method. My interest is in the API spec because the JLS will make normative reference to it. "Removes horizontal white space margins from the essential body of a Text Block originated stri

Re: [13] RFR: 8224105: Cannot parse JapaneseDate string on some specified locales

Hi, Naoto. I have a couple comments. src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java String.isEmpty() could be used in place of equals(""). test/jdk/java/time/test/java/time/chrono/TestEraDisplayName.java Maybe give the new constants names in all-caps.

Need code reviews for Text Block support

Brent, With Sherman gone, I don't have a Strings guy to review changes to java.lang.String. Would you be willing to take a look see? Nothing complicated. RFR sent to core-libs-dev subjects Subject: RFR - JDK-8223775 String::stripIndent (Preview) Subject: RFR - JDK-8223780 String::translateEscap

Re: RFR - JDK-8223780 String::translateEscapes (Preview)

Hi Jim! A few comments: 1) Probably, there's no need to update ch in these cases: case '\'': ch = '\''; break; case '\"': ch = '\"'; break; 2) Character.digit(ch, 8) will accept non-L

Re: RFR - JDK-8223780 String::translateEscapes (Preview)

Code has been updated to use IllegalArgumentException instead of new exception type. http://cr.openjdk.java.net/~jlaskey/8223780/webrev-02 > On May 21, 2019, at 11:56 AM, Jim Laskey wrote: > > Please do a code review of the new String:: translateEscapes instance method. > This instance method

Re: RFR: 8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances

Thanks Claes! Looks good. best regards, -- daniel On 21/05/2019 14:12, Claes Redestad wrote: Hi Daniel, On 2019-05-21 12:48, Daniel Fuchs wrote: Hi Claes, Looks good to me. Thanks! But can you add a test for when the malformed sequence is not at the end of a line, and one for when it'

Re: RFR - JDK-8203444 String::formatted (Preview)

I suppose String::formattedLocalized(Locale lc, Object... args) would also be reasonable. > On May 21, 2019, at 12:56 PM, Jim Laskey wrote: > > Good point. To make sure I fully understand what you are stating, > > - The argument for having an instance method is reasonable to achieve > "flowin

Re: RFR - JDK-8203444 String::formatted (Preview)

Good point. To make sure I fully understand what you are stating, - The argument for having an instance method is reasonable to achieve "flowiness". - However, only one version is necessary or desired, that is, "public String formatted(Object... args)". - In cases where Locale needs to be overri

Re: RFR - JDK-8203444 String::formatted (Preview)

* Jim Laskey: > All discussion is valid. I agree the ambiguity is tricky, but can be > resolved by using explicit locale. > > Example: > > "%s".formatted(Locale.getDefault(), Locale.JAPAN); > > This guarantees the "public String formatted(Locale l, > Object... args)" form is chosen with the

RE: RFR 8213031: (zipfs) Add support for POSIX file permissions

Hi Alan, Thank you for your comments. Here comes the next update... increasing the turnaround time a little bit 😊 http://cr.openjdk.java.net/~clanger/webrevs/8213031.10/ > Thanks. I think you've addressed most of my points. The only thing that > isn't clear is the group owner as I thought we h

RFR - JDK-8223775 String::stripIndent (Preview)

Please do a code review of the new String::stripIndent instance method. This instance method is being introduced to support JEP-355: Text Blocks, by removing incidental indentation from the text block content. The algorithm used is defined in the JEP and also described in the JBS entry. Thank y

RFR - JDK-8223780 String::translateEscapes (Preview)

Please do a code review of the new String:: translateEscapes instance method. This instance method is being introduced to support JEP-355: Text Blocks, by translating escape sequences in the text block content. Thank you. -- Jim webrev: http://cr.openjdk.java.net/~jlaskey/8223780/webrev-01

Re: RFR - JDK-8203444 String::formatted (Preview)

All discussion is valid. I agree the ambiguity is tricky, but can be resolved by using explicit locale. Example: "%s".formatted(Locale.getDefault(), Locale.JAPAN); This guarantees the "public String formatted(Locale l, Object... args)" form is chosen with the second Locale as an argume

Re: RFR - JDK-8203444 String::formatted (Preview)

* Jim Laskey: > Please do a code review of the new String::formatted instance method. This > method was originally introduced under the name "format" > in conjunction with Raw String Literals. The method is being reintroduced in > conjunction with Text Blocks and renamed to avoid method > resolu

RFR - JDK-8203444 String::formatted (Preview)

Please do a code review of the new String::formatted instance method. This method was originally introduced under the name "format" in conjunction with Raw String Literals. The method is being reintroduced in conjunction with Text Blocks and renamed to avoid method resolution conflicts against t

Re: RFR: 8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances

Looks good. Roger On 05/21/2019 09:12 AM, Claes Redestad wrote: Hi Daniel, On 2019-05-21 12:48, Daniel Fuchs wrote: Hi Claes, Looks good to me. Thanks! But can you add a test for when the malformed sequence is not at the end of a line, and one for when it's not the first character in th

Re: RFR: 8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances

Hi Daniel, On 2019-05-21 12:48, Daniel Fuchs wrote: Hi Claes, Looks good to me. Thanks! But can you add a test for when the malformed sequence is not at the end of a line, and one for when it's not the first character in the value? Something like:     checkMalformedUnicodeEscape("b=

Re: RFR: 8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances

Hi Claes, Looks good to me. But can you add a test for when the malformed sequence is not at the end of a line, and one for when it's not the first character in the value? Something like: checkMalformedUnicodeEscape("b=\\u012xyz\n"); checkMalformedUnicodeEscape("b=x\\u012yz\n");

RFR: 8224202: Speed up Properties.load

Hi, a few smaller optimizations for Properties.load: - when parsing comment lines, we unnecessarily breaks the fast path loop on backslashes, even though a backslash embedded in a comment line will never have any effect on subsequent logical lines - inside that same loop, we always do two com

RFR: 8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances

Hi, found a bug in Properties.load that apparently has been around since Java 5. This patch adds proper bounds checking when decoding unicode sequences. Bug:https://bugs.openjdk.java.net/browse/JDK-8224240 Webrev: http://cr.openjdk.java.net/~redestad/8224240/open.00 Since the fix means a be