Hi,
On 5/29/19 9:25 PM, Roger Riggs wrote:
Any other comments on:
"* Runs the garbage collector in the Java Virtual Machine.
*
* Calling this method suggests that the Java Virtual Machine
* expend effort toward recycling unused objects in order to
* make the memory they currently occupy
Hi Florian,
On 25/05/2019 6:50 am, Florian Weimer wrote:
* Jiangli Zhou:
Hi Florian,
On Fri, May 24, 2019 at 2:46 AM Florian Weimer wrote:
* Jiangli Zhou:
[3] change: http://cr.openjdk.java.net/~jiangli/tls_size/webrev/
(contributed by Jeremy Manson)
_dl_get_tls_static_info is an
Hi Florian,
On 24/05/2019 8:13 pm, Florian Weimer wrote:
* David Holmes:
My thoughts haven't really changed since 2015 - and sadly neither has
there been any change in glibc in that time. Nor, to my recollection,
have there been any other reported issues with this.
The issue gets
Adding back hotspot-dev. I don't think Kim saw this.
David
On 30/05/2019 4:04 am, Roger Riggs wrote:
Hi Kim,
In the normal output less output is cleaner.
It would be more useful to have the Duration of the wait and end time of
the wait.
(It saves the reader doing subtraction of times).
+
On 5/30/19 3:25 AM, Roger Riggs wrote:
Hi,
ok, thanks for the comments.
Any other comments on:
"* Runs the garbage collector in the Java Virtual Machine.
*
* Calling this method suggests that the Java Virtual Machine
* expend effort toward recycling unused objects in order to
* make the
> On May 29, 2019, at 5:56 PM, Leonid Mesnik wrote:
>
> Looks good.
Thanks.
>
> Leonid
>
> On 5/29/19 10:24 AM, Kim Barrett wrote:
>> [I’m not completely sure where this RFR should be sent, but core-libs-dev
>> and hotspot-dev seems likely to get reasonable coverage of those who
>> might
Hi Joe,
Right, I will file a corresponding CSR.
Naoto
On 5/29/19 3:51 PM, Joseph D. Darcy wrote:
Hi Naoto,
Should this bug get a CSR for the behavioral change?
Cheers,
-Joe
On 5/29/2019 2:12 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix for the following issue:
Hi Naoto,
Should this bug get a CSR for the behavioral change?
Cheers,
-Joe
On 5/29/2019 2:12 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8223773
The proposed changeset is located at:
Looks fine.
On 29/05/2019 11:38, Phil Race wrote:
Any takers ?
-phil.
On 5/24/19 9:35 AM, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223271
Webrev : http://cr.openjdk.java.net/~prr/8223271/
Whilst working on removing some inappropriate coupling of the java launcher and
Hi Roger,
I think it is important that the "best effort" be kept as per this
version. It may not be a directly testable property but it does capture
intent regarding quality-of-implementation IMO.
Thanks,
David
On 30/05/2019 5:25 am, Roger Riggs wrote:
Hi,
ok, thanks for the comments.
Looks good.
Leonid
On 5/29/19 10:24 AM, Kim Barrett wrote:
[I’m not completely sure where this RFR should be sent, but core-libs-dev
and hotspot-dev seems likely to get reasonable coverage of those who
might care.]
Please review this change to the test library to add some "logging"
output to
Hello!
In the implNote section of the javadoc for xxxSummaryStatistics classes
it is mentioned that the sum is not checked for overflow.
It would be more accurate to add that neither does the implementation
check the count for overflow.
Would you please help review this doc-only change?
Thanks, Lance.
Sure, will update the test case with @summary.
Naoto
On 5/29/19 2:21 PM, Lance Andersen wrote:
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are
consistent with other tests.
No need to spin a webrev again though
Best
Lance
On May 29,
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are consistent
with other tests.
No need to spin a webrev again though
Best
Lance
> On May 29, 2019, at 5:12 PM, naoto.s...@oracle.com wrote:
>
> Hi,
>
> Please review the fix for the following issue:
>
>
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8223773
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8223773/webrev.00/
Checking the range of HourOfAmPm with the range of AmPmOfDay is
apparently incorrect. Fixing it
As an academic note, note that non-overflowing strings can be recognized
with a regex :-)
For signed numbers in base 10:
# MAX_VALUE in base 10: 2147483647
((-)?0*((\p{Digit}){1,9})
|([0-1]\p{Digit}{9})
|(20\p{Digit}{8})
|(21[0-3]\p{Digit}{7})
|(214[0-6]\p{Digit}{6})
|(2147[0-3]\p{Digit}{5})
Hi Ivan,
interesting suggestion. I should try it out.
Also keep in mind that inlining decisions are sensitive to call depth,
and that my current patch peels off String in such a way that
appendChars(CharSequence, int, int) will never see a String argument,
which... Argh... :-)
/Claes
On
Looks fine. Thanks, Ivan.
-Brent
On 5/29/19 7:27 AM, Roger Riggs wrote:
Thanks Ivan, Looks good.
On 05/28/2019 10:08 PM, Ivan Gerasimov wrote:
Hi Brent!
On 5/28/19 4:06 PM, Brent Christian wrote:
Hi, Ivan
I agree with Roger that there are more test cases than necessary.
Otherwise I
> On May 29, 2019, at 3:39 PM, Daniel D. Daugherty
> wrote:
>
> On 5/29/19 1:24 PM, Kim Barrett wrote:
>> [I’m not completely sure where this RFR should be sent, but core-libs-dev
>> and hotspot-dev seems likely to get reasonable coverage of those who
>> might care.]
>>
>> Please review this
Hi, Andrew
I tried to test these changes and build failed on all systems except Linux
because:
workspace/open/src/hotspot/share/prims/unsafe.cpp:446:3: error: use of
undeclared identifier 'JNU_ThrowRuntimeException'
JNU_ThrowRuntimeException(env, "writeback is not implemented");
^
On 5/29/19 1:24 PM, Kim Barrett wrote:
[I’m not completely sure where this RFR should be sent, but core-libs-dev
and hotspot-dev seems likely to get reasonable coverage of those who
might care.]
Please review this change to the test library to add some "logging"
output to tests that spawn a
Hi Claes!
It looks like for the cases when this.isLatin1() != s.isLatin1() the
code is essentially the same as in appendChars(CharSequence, int, int).
So, to save some byte codes (which can actually help with inlining), it
might have been written as:
private final void appendChars(String s,
Hi,
ok, thanks for the comments.
Any other comments on:
"* Runs the garbage collector in the Java Virtual Machine.
*
* Calling this method suggests that the Java Virtual Machine
* expend effort toward recycling unused objects in order to
* make the memory they currently occupy available for
Likewise, but I am. +1
Brian
> On May 29, 2019, at 11:52 AM, Kevin Rushforth
> wrote:
>
> Looks good to me (note that I am not a "R"eviewer).
Looks good to me (note that I am not a "R"eviewer).
-- Kevin
On 5/29/2019 11:38 AM, Phil Race wrote:
Any takers ?
-phil.
On 5/24/19 9:35 AM, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223271
Webrev : http://cr.openjdk.java.net/~prr/8223271/
Whilst working on removing
Any takers ?
-phil.
On 5/24/19 9:35 AM, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223271
Webrev : http://cr.openjdk.java.net/~prr/8223271/
Whilst working on removing some inappropriate coupling of the java
launcher and the desktop module,
and testing out the -splash
Hi Kim,
In the normal output less output is cleaner.
It would be more useful to have the Duration of the wait and end time of
the wait.
(It saves the reader doing subtraction of times).
+ Instant start = Instant.now();
+ boolean aborted = true;
+ try {
+
On 5/29/19 5:06 PM, Roger Riggs wrote:
> The language is hard to construct, in part because of the innovations in gc
> technology that have
> resulted such a wide range of behaviors and timing.
>
> I'll restore the sentence "When control returns"... but I don't think it
> carries any
> definite
[I’m not completely sure where this RFR should be sent, but core-libs-dev
and hotspot-dev seems likely to get reasonable coverage of those who
might care.]
Please review this change to the test library to add some "logging"
output to tests that spawn a child process to perform the test and
then
Hi Vicente,
Why fix just this one method? The other methods of DynamicCallSiteDesc
do not make the
same claim for bootstrapArgs and the code does not check for the
contents being null
nor does the constructor that is invoked that clones the array. (Line 81).
The overhead of a change and CSR
+1
On 05/29/2019 12:04 PM, Claes Redestad wrote:
Hi Roger,
On 2019-05-29 17:45, Roger Riggs wrote:
Hi Claes,
With the use of random, you should log the seed for the possibility
to repeat a particular case.
the randomization isn't essential for this microbenchmark, only to
generate a
Hi Roger,
On 2019-05-29 17:45, Roger Riggs wrote:
Hi Claes,
With the use of random, you should log the seed for the possibility to
repeat a particular case.
the randomization isn't essential for this microbenchmark, only to
generate a non-constant String of the given length. I've
Hi Joel,
Yes, as far as I know now, only AnnotatedTypeVariable was susceptible to
the stack overflow problem.
Thanks,
-Joe
On 5/29/2019 5:37 AM, Joel Borggrén-Franck wrote:
Hi Joe!
Looks good to me. Looking at the summary by the end of your mail I
guess this is the only subtype that
Hi Claes,
With the use of random, you should log the seed for the possibility to
repeat a particular case.
Otherwise, looks ok.
Roger
On 05/29/2019 11:43 AM, Jim Laskey wrote:
+1
On May 29, 2019, at 12:36 PM, Claes Redestad wrote:
Hi,
it's been pointed out[1] that
+1
> On May 29, 2019, at 12:36 PM, Claes Redestad
> wrote:
>
> Hi,
>
> it's been pointed out[1] that append(string.substring(start, end)) can
> outperform append(string, start, end) in some circumstances. In part due
> the former being intrinsified, but also I think due it tickling some
>
Hi,
it's been pointed out[1] that append(string.substring(start, end)) can
outperform append(string, start, end) in some circumstances. In part due
the former being intrinsified, but also I think due it tickling some
string concat optimizations that allow for eliding the StringBuilder
itself
Hi Chris,
On 05/29/2019 08:50 AM, Chris Hegarty wrote:
Roger,
On 28/05/2019 21:54, Roger Riggs wrote:
Hi Aleksey,
The is always optional (in html5).
The way that the source documentation is structured suggests that a new
paragraph, ``, is missing HERE ( see below ).
642 * Runs the
Hi Hans,
The language is hard to construct, in part because of the innovations in
gc technology that have
resulted such a wide range of behaviors and timing.
I'll restore the sentence "When control returns"... but I don't think it
carries any
definite requirement on an implementation. It is
Please review fix for [1] at [2] and the CSR at [3]. This is a simple
fix that is just rewording an assertion at method
java.lang.constant.DynamicCallSiteDesc::withArgs. The fix is simply:
diff -r dd321e3596c0 -r 78f3b29fb255
Thanks Ivan, Looks good.
On 05/28/2019 10:08 PM, Ivan Gerasimov wrote:
Hi Brent!
On 5/28/19 4:06 PM, Brent Christian wrote:
Hi, Ivan
I agree with Roger that there are more test cases than necessary.
Otherwise I think it looks pretty good.
Okay. Then let's make the list of invalid
Roger,
On 28/05/2019 21:54, Roger Riggs wrote:
Hi Aleksey,
The is always optional (in html5).
The way that the source documentation is structured suggests that a new
paragraph, ``, is missing HERE ( see below ).
642 * Runs the garbage collector in the Java Virtual Machine.
643
Hi Alan,
Apologies for the previous post which escaped from the lab while Dr
Funkenstein was struggling to push the right buttons (and work out what
happened when he pushed them).
I have created an implementation subtask and associated CSR. I also
updated the last webrev to record the javadoc
Hi Joe!
Looks good to me. Looking at the summary by the end of your mail I guess
this is the only subtype that needs fixing?
Cheers
/Joel
On Wed, 29 May 2019 at 07:52, Joe Darcy wrote:
> Hello,
>
> Please review the changes to address:
>
> JDK-8224012: AnnotatedType implementations of
Hi Alan,
I have created a new JEP implementation JIRA (note change to thread
title) and associated draft CSR
Impl JIRA: https://bugs.openjdk.java.net/browse/JDK-8224974
CSR JIRA:
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and
Hi Alan,
> The table items in L119-150 look fine, we just need to avoid really long
> lines One minor comment on L123 is that it might be clearer if you drop
> "created" from the sentence.
>
> L48-78 is a "wall of text" and links that I don't think will be easy for
> most developers to read. Can
45 matches
Mail list logo
