Re: SocketAddress.toString() and RFC 2732

2019-06-07 Thread Alan Bateman
On 07/06/2019 19:46, Chris wrote: java.net.SocketAddress can represent an IPv6 address with port. Because parts of an IPv6 address are separated with colons and a colon is also used to separate the address from the port, RFC 2732 specifies that the address be in square brackets in this case, e.g.

SocketAddress.toString() and RFC 2732

2019-06-07 Thread Chris
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 java.net.SocketAddress can represent an IPv6 address with port. Because parts of an IPv6 address are separated with colons and a colon is also used to separate the address from the port, RFC 2732 specifies that the address be in square brackets in th

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

2019-06-07 Thread Semyon Sadetsky
On 6/7/19 9:52 AM, Alexey Semenyuk wrote: Not quite exactly what I meant by suggesting to use xml api. Sorry for not being specific. With DOM and Xpath this can be as simple as the following: XPath is DOM based = slow. That point is not clear. --Semyon --- package sample; import java.io.

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

2019-06-07 Thread Alexey Semenyuk
Not quite exactly what I meant by suggesting to use xml api. Sorry for not being specific. With DOM and Xpath this can be as simple as the following: --- package sample; import java.io.FileInputStream; import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; im

Re: RFR 8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-07 Thread Bernd Eckenfels
stopListening seems not atomically using listenMap. (Ie change get/remove to remove only) BTW this would be a good usecase for a CopyOnWriteMap... -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag von Andrew Leonard Gesendet: Freitag, Juni 7, 2019

Re: RFR: 8224974: Implement JEP 352

2019-06-07 Thread Andrew Dinn
On 07/06/2019 12:24, Andrew Dinn wrote: > On 06/06/2019 18:40, Vladimir Kozlov wrote: >> Hotspot changes looks good. >> >> CheckGraalIntrinsics failed because of typo - you should use 'J' instead >> of 'L': >> >> +  "jdk/internal/misc/Unsafe.writeback0(L)V", > > Doh! Thanks, Vladimir :-) > > With

Re: RFR 8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-07 Thread Alan Bateman
On 07/06/2019 14:43, Andrew Leonard wrote: Hi, Please can I request a sponsor and review of this patch for JDK-8225474. A problem that we have seen intermittently with JDI connector stress tests for quite a while that is caused by an non-thread safe HashMap in the connector class. I've created a

RFR 8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-07 Thread Andrew Leonard
Hi, Please can I request a sponsor and review of this patch for JDK-8225474. A problem that we have seen intermittently with JDI connector stress tests for quite a while that is caused by an non-thread safe HashMap in the connector class. I've created a standalone testcase that reproduces it re

Suggestion for a more sensible implementation of EMPTY_MAP

2019-06-07 Thread Abraham Marin-Perez
Hi everyone, I'm a first timer here, I just joined the group as suggested by Martijn Verburg to make a suggestion for a slight change in the implementation of Collections.EMPTY_MAP. If I understand correctly, this class represents an immutable empty map. As a result, operations like put or remove

Re: RFR: 8224974: Implement JEP 352

2019-06-07 Thread Andrew Dinn
On 06/06/2019 18:40, Vladimir Kozlov wrote: > Hotspot changes looks good. > > CheckGraalIntrinsics failed because of typo - you should use 'J' instead > of 'L': > > +  "jdk/internal/misc/Unsafe.writeback0(L)V", Doh! Thanks, Vladimir :-) With that correction the test now passes. > One nitpick i

Re: JEP 343: Packaging Tool

2019-06-07 Thread Alan Bateman
On 05/06/2019 22:20, Kevin Rushforth wrote: Hi Mark, Thank you for your detailed review of jpackage. Given that RDP1 is only a week away, I agree that we don't have time to address your feedback. Either Andy or I will move it back to "Candidate" and then proceed as you recommend. Is it time t