Re: Unused method java.lang.Integer::formatUnsignedInt

Thanks, Brian. Posted a webrev: https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-June/060892.html With best regards, Tagir Valeev On Tue, Jun 18, 2019 at 1:22 AM Brian Burkhalter < brian.burkhal...@oracle.com> wrote: > Hello, > > Well it’s package private, isn’t used anywhere, and the

RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

Hello! Please review: https://bugs.openjdk.java.net/browse/JDK-8226286 http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r1/ I left dangling javadoc in-place in the same way as it's done in java.lang.Long. Also I removed redundant reassignment of parameter like s = Objects.requireNonNull(s). B

Re: jpackage DMG creation trouble

Okay, so for OS X jpackage output, we have: An inner artifact: App Image/Bundle xor .pkg installer A wrapper (disk image): .dmg Now how do we specify these cases on the command-line? How about this: create-app-image [--with-dmg] create-installer [--with-dmg] (note that the only actua

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, On 18/06/2019 6:00 am, Roger Riggs wrote: Hi, Updated: http://cr.openjdk.java.net/~rriggs/webrev-spawn-diag-8225192-3/ + if (WIFEXITED(status)) { + snprintf(ebuf, sizeof ebuf, + "Failed to exec spawn helper: pid: %d, exit value: %d", + pid, WEXITS

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi, Updated: http://cr.openjdk.java.net/~rriggs/webrev-spawn-diag-8225192-3/ On 6/17/19 2:20 PM, Martin Buchholz wrote: On Mon, Jun 17, 2019 at 10:47 AM Thomas Stüfe > wrote: Hi Roger, I think this is fine. Could you please also print out WIFEX

Re: Unused method java.lang.Integer::formatUnsignedInt

Hello, Well it’s package private, isn’t used anywhere, and the JDK builds without so I don’t see why it could not be removed. Thanks, Brian > On Jun 16, 2019, at 9:09 PM, Tagir Valeev wrote: > > It seems that there's an unused method in java.lang.Integer with the > following signature: > sta

Re: 8226242 : Diagnostic output for posix_spawn failure

On Mon, Jun 17, 2019 at 10:47 AM Thomas Stüfe wrote: > Hi Roger, > > I think this is fine. > > Could you please also print out WIFEXITED and WIFSIGNALLED? Since I am not > sure if the WEXITSTATUS contains valid info if WIFEXITED is 0, or just > random noise. Same for WTERMSIG. > > Alternatively:

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, I think this is fine. Could you please also print out WIFEXITED and WIFSIGNALLED? Since I am not sure if the WEXITSTATUS contains valid info if WIFEXITED is 0, or just random noise. Same for WTERMSIG. Alternatively: if (WIFEXITED) print("exited normaly with %d", WEXITSTATUS) else if (W

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Thomas, yes, I meant WTERMSIG.  I figured the useful info was the value of those two fields of the status but a bit easier to read than the hex formatted value. If there is any other information available at that point of execution, let me know. Thanks, Roger [1] http://cr.openjdk.java.

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, thanks for taking care of this! I think WIFSIGNALED is just a bool though; to get the terminating signal, you need to use WTERMSIG. Strictly speaking, WEXISTSTATUS is only valid if WIFEXITED!=0 and WTERMSIG only if WIFSIGNALLED!=0; I think they are undefined otherwise. Cheers, Thoams

RE: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

My bad. I was looking at the patch at [1], and didn’t consider that the browser rendering likely doesn’t match the actual file content. Sorry for the noise. And good to hear the review process is underway. Kind regards, Anthony [1] https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-Apri

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, Looks good. Brian > On Jun 17, 2019, at 9:03 AM, Roger Riggs wrote: > > Please review adding diagnostic information to the native code handing > failures > to exec the jspawnhelper. Some information about the child process status > can be included. > > Jira: > diag task: https:

8226242 : Diagnostic output for posix_spawn failure

Please review adding diagnostic information to the native code handing failures to exec the jspawnhelper.  Some information about the child process status can be included. Jira:   diag task: https://bugs.openjdk.java.net/browse/JDK-8226242   Issue:  https://bugs.openjdk.java.net/browse/JDK-8226

Re: [PATCH] 4511638: Double.toString(double) sometimes produces incorrect results

Hi Anthony, On 16/06/2019 19.17, Anthony Vanelverdinghe wrote: Hi Raffaello While I don't have feedback on the actual math, here's a few suggestions: - there's some use of non-ASCII characters in the patch. I don't think this is common in the JDK's Java sources, so you might want to replace

Re: Slightly faster java.util.Arrays.byteSort(byte[])

>I'm not an expert, however, while your OCA (see below) is being processed I >would recommend to provide more comprehensive stats. Different lengths of an >array, different flavours of data: sorted, sorted in the reverse order, random, >typical expected case(s), etc. > >It seems that this particul