Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- There are no know bugs in how we handle java options with spaces.
However, it might be complicated to figure out how to provide such
options. Added
+1
> On Aug 8, 2019, at 8:28 AM, Claes Redestad wrote:
>
> Hi,
>
> in j.l.StringLatin1 we can and do call CharacterDataLatin1 directly in
> some places, which avoids a few indirections. Doing so has no effect on peak
> performance, but simplifies the work the JIT needs to do and speeds
> up
Looks good then.
On 8/8/2019 3:06 PM, Alexey Semenyuk wrote:
On 8/8/2019 5:35 PM, Alexander Matveev wrote:
Hi Alexey,
Do you know what behavior will be if we have two packages which will
install into
CompanyName/App1
CompanyName/App2
If App1 is removed will App2 also removed?
No,
On 8/8/2019 5:35 PM, Alexander Matveev wrote:
Hi Alexey,
Do you know what behavior will be if we have two packages which will
install into
CompanyName/App1
CompanyName/App2
If App1 is removed will App2 also removed?
No, directory structure of App2 will stay intact. With the suggested fix
Hi Alexey,
Do you know what behavior will be if we have two packages which will
install into
CompanyName/App1
CompanyName/App2
If App1 is removed will App2 also removed?
Thanks,
Alexander
On 8/8/2019 8:49 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This
Looks good.
On 8/8/2019 5:31 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8224788: jpackage fails on OS X when using --runtime-image
[1]
Hi Roger! Thanks for the comments!
On 8/8/19 6:50 AM, Roger Riggs wrote:
Hi Ivan,
To be consistent with other checks of the index, can you use the
checkIndex(index, length) method?
The message it produces would be appropriate for both cases.
Unfortunately, checkIndex(int, int) wouldn't be
Hi Claes!
On 8/8/19 6:56 AM, Claes Redestad wrote:
Hi,
perhaps a stupid question, but why isn't String::substring(int)
calling substring(beginIndex, length())? That'd ensure consistent error
messages, but otherwise preserve semantics.
It's a good point, actually!
I suspect that originally
Hi Pavel,
To your questions...
On 8/8/19 11:07 AM, Pavel Rappo wrote:
...
109: "template method" doesn't describe the method well, the method is private
and not overridable.
update the javadoc.
I can see several questions here. Correct me if I'm wrong. The first one is about the use
of
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Add all ascending subdirectories of application installation directory
to the package.
[1] https://bugs.openjdk.java.net/browse/JDK-8215446
[2]
Roger, answers are inline.
> On 7 Aug 2019, at 16:52, Roger Riggs wrote:
>
>
>
> BaseLdapServer:
>
> 100: The new exception should have a message "Unexpected exception" or
> "server should no be running"...
Fixed.
> 158: Is printing the stack trace diagnostic or an error?, the exception
> On 6 Aug 2019, at 21:04, Joe Darcy wrote:
>
> ...
> Revised webev
>
> http://cr.openjdk.java.net/~darcy/8202385.5/
LGTM.
-Chris.
Hi Joe,
Looks good, thanks for the updates.
Roger
On 8/6/19 4:04 PM, Joe Darcy wrote:
Hi Roger,
Revised webev
http://cr.openjdk.java.net/~darcy/8202385.5/
Diff of last two versions below. To ease review, I elected not to
reflow the paragraphs at this time to reduce the number of
Looks good.
- Alexey
On 8/8/2019 8:31 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8224788: jpackage fails on OS X when using --runtime-image
[1]
Hi,
perhaps a stupid question, but why isn't String::substring(int) calling
substring(beginIndex, length())? That'd ensure consistent error
messages, but otherwise preserve semantics.
/Claes
On 2019-08-08 02:17, Ivan Gerasimov wrote:
Hello!
The exception thrown by substring(int) may look
Hi Ivan,
To be consistent with other checks of the index, can you use the
checkIndex(index, length) method?
The message it produces would be appropriate for both cases.
While you are there can you add a space after the comma
in lines 3680 and 3691.
Is there an appropriate test? There should
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8224788: jpackage fails on OS X when using --runtime-image
[1] https://bugs.openjdk.java.net/browse/JDK-8224788
[2]
Hi,
in j.l.StringLatin1 we can and do call CharacterDataLatin1 directly in
some places, which avoids a few indirections. Doing so has no effect on
peak performance, but simplifies the work the JIT needs to do and speeds
up a variety of operations during startup and warmup.
Many thanks Pavel for the changes, and thanks Lance, Roger for the reviewing.
Yep, let me try to handle some questions from Roger
> On 7 Aug 2019, at 11:52 PM, Roger Riggs wrote:
>
> BaseLdapServer:
>
> 158: Is printing the stack trace diagnostic or an error?, the exception is
> not rethrown
19 matches
Mail list logo
