Re: RFR: 8229773: Resolve permissions for code source URLs lazily

2019-08-18 Thread Claes Redestad
Thanks everyone. Pushed. /Claes Roger Riggs skrev: (16 augusti 2019 19:00:29 CEST) >+1 > >On 8/16/19 12:51 PM, Sean Mullan wrote: >> +1 from me as well. >> >> --Sean >> >> On 8/16/19 12:38 PM, Alan Bateman wrote: >>> On 16/08/2019 13:30, Claes Redestad wrote: How about this:

Re: RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

2019-08-18 Thread Claes Redestad
Hi, On 2019-08-18 21:22, Evgeny Mandrikov wrote: [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/ looks ok to me. I'd add a comment that protocol is assumed to be "file", and perhaps make the constructor private (valid since JDK 11). I can sponsor the change, seeing how I apperently

RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

2019-08-18 Thread Evgeny Mandrikov
Hello! Please review patch [1] for JDK-8139820 [2]. Also it needs a sponsor since I have only author status in OpenJDK Census [3]. With best regards, Evgeny Mandrikov [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8139820 [3] https://openj