Thanks for reviewing.
Can someone help sponsor/commit the patch for me?
Thanks,
-Andrew
diff -r 70fab3a8ff02 src/java.base/share/native/libjava/jni_util.c
--- a/src/java.base/share/native/libjava/jni_util.cTue Jul 16 07:29:12 2019
+0900
+++ b/src/java.base/share/native/libjava/jni_util.c
Thank you Brian, this looks much better!
I have a few further suggestions how to simplify the code.
1)
If this BigInteger is negative, it is negated in two places: @ 3943 and
either @ 4003 or @ 4061.
It is better to keep abs value at the very beginning and make private
toString(...) and
Hi Philippe,
I'll be happy to sponsor the fix.
Mandy's suggestion makes sense to me, please update the patch.
I filed https://bugs.openjdk.java.net/browse/JDK-8230058 to track the
change.
Regards, Roger
On 8/22/19 1:56 PM, Mandy Chung wrote:
Hi Philippe,
This is a good use of
Hi
Indeed I have forgotten. Re-attached, with aesthetic fixes to the test.
On Thu, 22 Aug 2019 at 05:38, Vyom Tiwari wrote:
>
> Hi Milan,
>
> Your test need the corresponding "TcpTimeout.dns" file to run successfully, I
> believe you forgot to add with your patch.
> please check the existing
Hi Ivan,
Please see the delta [1] and absolute [2] webrevs.
> On Aug 21, 2019, at 7:38 PM, Ivan Gerasimov wrote:
>
> A couple of comments
>
> 1)
> 3974 if (signum == 0) {
> 3975 buf.append('0');
> 3976 return;
> 3977 }
>
> Shouldn't it be padded with
Hi Philippe,
This is a good use of StackWalker. getSource can simply return
StackFrame and avoid the creation of String[].
Stuart will give you better guidance related to RMI testing.
I see that test/jdk/sun/rmi/runtime/Log has a few RMI logging tests.
RMI tests are in tier3. You can run
Hi Joe,
This looks good overall.
Best
Lance
> On Aug 21, 2019, at 9:31 PM, Joe Wang wrote:
>
> Please review a specification claraficaiton/doc-only change to ErrorHandler
> and ContentHandler.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8229388
> CSR:
Thank you Julia!
On 8/22/19 2:06 AM, Julia Boes wrote:
Hi Ivan,
Thanks for pointing that out, the links are now added.
Updated webrev:
http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.03/
Is there a reason to change the text at lines 72-75?
Since you've just added the
Hello
First time contributor here.
We have exception tracing enabled in production and see thousands of
exceptions in sun.rmi.runtime.Log#getSource() to get the caller class.
In my option this should use StackWalker introduced in Java 9. I could
find no corresponding bug in JBS.
I created a
Thanks for the EA version of jpackage. Great job. I wish this could
still make it into Java 13.
Here is a little feedback according to my practical experience with it:
Add type "img", "app" or similar to --package-type.
It makes the handling in scripts easier.
DMG folder does not contain an
On 24/07/2019 14:28, Claes Redestad wrote:
Hi,
BigInteger has a number of pre-calculated constants that are profitable
to put up for archiving. This reduces initialization time of BigInteger
by 0.3-0.5ms, and archives ~12Kb worth of objects.
Bug:
Hi Ivan,
Thanks for pointing that out, the links are now added.
Updated webrev: http://cr.openjdk.java.net/~dfuchs/jboes/8229485/webrev.03/
Regards,
Julia
On 21/08/2019 20:33, Ivan Gerasimov wrote:
Hi Julia!
This looks good to me.
For all the other methods from StrictMath that have a
12 matches
Mail list logo
