Looks good.
- Alexey
On 9/13/2019 8:20 PM, Alexander Matveev wrote:
http://cr.openjdk.java.net/~almatvee/8230521/webrev.01/
- Simplified setting default value for destination folder.
- Undo renaming of output variables to dest.
- Modified help messages as per Andy suggestion.
- Removed obsolet
http://cr.openjdk.java.net/~almatvee/8230521/webrev.01/
- Simplified setting default value for destination folder.
- Undo renaming of output variables to dest.
- Modified help messages as per Andy suggestion.
- Removed obsolete tests as per Alexey suggestion.
Thanks,
Alexander
On 9/12/2019 8:16
Hi,
Please review these StackWalker and Throwable benchmarks for addition
into the JDK microbenchmarks.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8221623
Webrev:
http://cr.openjdk.java.net/~bchristi/8221623/webrev07/
The StackWalker benchmarks use StackWalker's forEach(), walk(), and
Opt
Hi Claes,
So this security manager is part of a much larger program, (a fork of
Jini / Apache River), I've almost finished the transition from Java 8 to
Java 11...
One change I noticed is permissions granted to the java extension
directory are now granted to every domain in our policy provid
On 9/13/19 12:20 PM, Alan Bateman wrote:
On 13/09/2019 19:53, Joe Wang wrote:
Please review a new method addition to SAX ContentHandler that allows
a SAX parser to send back information about the declaration of the
input document.
JBS: https://bugs.openjdk.java.net/browse/JDK-8230814
CSR:
Hi Joe,
The proposed change look fine.
> On Sep 13, 2019, at 2:53 PM, Joe Wang wrote:
>
> Please review a new method addition to SAX ContentHandler that allows a SAX
> parser to send back information about the declaration of the input document.
>
> JBS: https://bugs.openjdk.java.net/browse/JD
On 13/09/2019 19:53, Joe Wang wrote:
Please review a new method addition to SAX ContentHandler that allows
a SAX parser to send back information about the declaration of the
input document.
JBS: https://bugs.openjdk.java.net/browse/JDK-8230814
CSR: https://bugs.openjdk.java.net/browse/JDK-823
Please review a new method addition to SAX ContentHandler that allows a
SAX parser to send back information about the declaration of the input
document.
JBS: https://bugs.openjdk.java.net/browse/JDK-8230814
CSR: https://bugs.openjdk.java.net/browse/JDK-8230824
webrev: http://cr.openjdk.java.n
Much better now. One nit: label "freedata" at line 236 should not be
indented.
As to the fastpath candidate zones, I was just curious. UTC/GMT is fine
by me.
Naoto
On 9/13/19 1:32 AM, Seán Coffey wrote:
Thanks for the review Naoto. The edits certainly did need some tidying
up. Comments inli
Thank you!
On Fri, Sep 13, 2019 at 9:44 AM wrote:
>
> Android (d8 in fact) is able to desugar private access with nestmates
> since last April,
> your latest backport target 9 which is not supported anymore, so when you
> will move the backport to support Java 11,
> this tool can become handy.
>
- Mail original -
> De: "Doug Lea"
> À: "Remi Forax" , "Martin Buchholz"
> Cc: "core-libs-dev" , "loom-dev"
> , "David Holmes"
>
> Envoyé: Vendredi 13 Septembre 2019 17:19:21
> Objet: Re: RFR: jsr166 integration 2019-09
> Would doing this make anything better enough to outweigh Martin
Would doing this make anything better enough to outweigh Martin and I
needing to deal with one more incompatible codebase?
-Doug
On 9/13/19 11:10 AM, fo...@univ-mlv.fr wrote:
>
>
>
>
> *De: *"Martin Buchholz"
>
> De: "Martin Buchholz"
> À: "Remi Forax"
> Cc: "core-libs-dev" , "loom-dev"
> , "David Holmes" , "Doug
> Lea"
> Envoyé: Jeudi 12 Septembre 2019 16:20:12
> Objet: Re: RFR: jsr166 integration 2019-09
> On Thu, Sep 12, 2019 at 1:48 AM Remi Forax < [ mailto:fo...@univ-mlv.fr |
> fo...@univ-mlv.fr
Thanks Roger,
I've reverted the header file changes then and added this to the .c file:
@@ -42,6 +42,8 @@
#include "jvm.h"
#include "TimeZone_md.h"
+static char *isFileIdentical(char* buf, size_t size, char *pathname);
+
#define SKIP_SPACE(p) while (*p == ' ' || *p == '\t') p++;
#define
Hi Sean,
The declaration can be up in the _md.c file to satify the compiler about
forward declarations.
$.02, Roger
On 9/13/19 4:34 AM, Seán Coffey wrote:
Thanks for the review Roger. I run into compiler issues if I don't
declare the new function in the header file.
/ws/jdk-jdk/open/src/ja
On 9/12/2019 9:34 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Renamed "--output" to "--dest" and made it optional with default to
".".
[1] https://bugs.openjdk
Here's the latest webrev accumulating all the changes we've discussed so far:
http://cr.openjdk.java.net/~prappo/8228580/webrev.03/
If people are okay with that I will proceed to creating a CSR.
> On 12 Sep 2019, at 20:06, Alan Bateman wrote:
>
> On 12/09/2019 12:41, Chris Hegarty wrote:
>
Thanks for the review Roger. I run into compiler issues if I don't
declare the new function in the header file.
/ws/jdk-jdk/open/src/java.base/unix/native/libjava/TimeZone_md.c:143:18:
error: implicit declaration of function ‘isFileIdentical’
[-Werror=implicit-function-declaration]
Thanks for the review Naoto. The edits certainly did need some tidying
up. Comments inline.
On 12/09/2019 17:42, naoto.s...@oracle.com wrote:
Hi Seán,
I like your approach to provide the fast path to determine the system
time zone. One general question is, is UTC/GMT the right set of fast
pa
19 matches
Mail list logo
