Hi Jan,
For future work, consider having a "Preview Methods" tag alongside
static, instance, deprecated, etc.
Cheers,
-Joe
On 10/3/2019 2:57 AM, Jan Lahoda wrote:
Hi,
This is a continuation of Joe's patch from here:
https://mail.openjdk.java.net/pipermail/compiler-dev/2019-June/013498.html
Hi Chris!
On 10/3/19 8:05 AM, Chris Hegarty wrote:
Ivan,
On 3 Oct 2019, at 04:41, Ivan Gerasimov wrote:
...
So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805 to cover the
addition of @throws paragraph in the javadoc of SocketPermission.
I would really appreciate it, if som
Thanks Peter, your variant looks cute!
Let's keep this code in mind as a candidate for refactoring once the
switch expression will make its way to the standard.
I would hesitate to allow using experimental features in building the
JDK just for that code :)
With kind regards,
Ivan
On 10/2
Looks good.
On 10/3/2019 5:17 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8231850
[2] http://cr.openjdk.java.net/~asemeny
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8231850
[2] http://cr.openjdk.java.net/~asemenyuk/8231850/webrev.00/
Looks good.
- Alexey
On 10/3/2019 6:10 PM, Alexander Matveev wrote:
http://cr.openjdk.java.net/~almatvee/8215895/webrev.01/
Changes since webrev.00 as per Alexey suggestions:
- Reverted "@library /test/lib" jtreg directive when it is not needed.
- jtreg.SkippedException exceptions will be used
It is customary to have the license of a file be updated from someone
affiliated with the copyright holder of the file.
-Joe
On 10/3/2019 1:42 PM, Florian Weimer wrote:
* Adam Farley8:
Four GPLv2 files in 8u seem to be missing the classpath exception from the
copyright section.
Requesting r
http://cr.openjdk.java.net/~almatvee/8215895/webrev.01/
Changes since webrev.00 as per Alexey suggestions:
- Reverted "@library /test/lib" jtreg directive when it is not needed.
- jtreg.SkippedException exceptions will be used through reflection.
- Other minor tweaks.
Thanks,
Alexander
On 10/2/
* Adam Farley8:
> Four GPLv2 files in 8u seem to be missing the classpath exception from the
> copyright section.
>
> Requesting reviews and a sponsor.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8227715
>
> Webrev: http://cr.openjdk.java.net/~afarley/8227715/webrev/
All these files are no
Hi Stuart,
Thanks for the review. I made the changes you mentioned.
Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231161/webrev.01/
If you would like to sponsor for this change, that would be great!
Regards,
Julia
On 03/10/2019 18:44, Stuart Marks wrote:
On 10/2/19 2:36 AM, Julia Boe
On 10/2/19 2:36 AM, Julia Boes wrote:
This is a minor fix of the Collector class-level documentation, where the wrong
type declaration was used in a code sample.
While at it, I added a compilation test for all code samples of this class-level
javadoc.
Bug: https://bugs.openjdk.java.net/b
Hello Jan,
The build change looks ok, but I would recommend this construct for
copying the file instead:
$(eval $(call SetupCopyFiles, COPY_PREVIEW_FEATURES, \
FILES :=
$(TOPDIR)/src/java.base/share/classes/jdk/internal/PreviewFeature.java, \
DEST :=
$(BUILDTOOLS_OUTPUTDIR)/gensrc/ja
Hello,
In response to the recent and on-going review of serializable types in
the base module and elsewhere, I thought it would be helpful if the
collections specs discussed how collections were serialiazable. In
particular, the proposed terminology is that a collection is
"conditionally seri
Hi Adam,
This looks like an RFR for OpenJDK 8u. Adding the appropriate mailing
list (jdk8u-dev not jdk-updates-dev; bcc'ed the latter) and fixing the
subject line.
Thanks,
Severin
On Thu, 2019-10-03 at 15:53 +0100, Adam Farley8 wrote:
> Hey all,
>
> Four GPLv2 files in 8u seem to be missing the
Ivan,
> On 3 Oct 2019, at 04:41, Ivan Gerasimov wrote:
>
> ...
>
> So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805 to cover
> the addition of @throws paragraph in the javadoc of SocketPermission.
>
> I would really appreciate it, if someone helped to review it.
>
Since we’r
Hey all,
Four GPLv2 files in 8u seem to be missing the classpath exception from the
copyright section.
Requesting reviews and a sponsor.
Bug: https://bugs.openjdk.java.net/browse/JDK-8227715
Webrev: http://cr.openjdk.java.net/~afarley/8227715/webrev/
Best Regards
Adam Farley
IBM Runtimes
U
> On 3 Oct 2019, at 01:09, Joe Darcy wrote:
>
> Hello,
>
> In response to the review of JDK-8231546:
>
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-September/062612.html
>
> it was noticed a field in NodeChangeEvent.java has an @serial javadoc tag,
> but the class itself is @
change looks good.
/Andy
On 10/2/2019 9:54 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Changed "Java" dir to "app" dir in jpackage app image on macOS.
[1] https:
"investigate" is appropriate verb for a task, but not a bug or enhancement.
When proposing a fix please (along with changing the synopsis) change
the Issue from a task to a bug or an enhancement.
/Andy
On 10/2/2019 10:52 PM, Phil Race wrote:
Please remove “investigate” from the synopsis. Eve
Hi,
This is a continuation of Joe's patch from here:
https://mail.openjdk.java.net/pipermail/compiler-dev/2019-June/013498.html
APIs associated with preview features are split into two groups:
essential and non-essential. These are marked with an JDK-internal
annotation, PreviewFeature, and a
On 03/10/2019 01:09, Joe Darcy wrote:
Hello,
In response to the review of JDK-8231546:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-September/062612.html
it was noticed a field in NodeChangeEvent.java has an @serial javadoc
tag, but the class itself is @serial excluded so the
21 matches
Mail list logo
