Re: JDK 14 RFR of JDK-8231202: Suppress warnings on non-serializable non-transient instance fields in serializable classes

Hello, Please review the revised fix:     http://cr.openjdk.java.net/~darcy/8231202.1/ The revised fix omits changes in java.time thanks to the changes already made for JDK-8231314: "java.time serialization warning cleanup"; also, the collection types are updated to use the "conditionally ser

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

Hi Stuart, I prefer your more extensive write-up and thus I review it to go back :-) I've filed JDK-8231913: "Discuss serializability of collections" with you as the assignee. Thanks, -Joe On 10/4/2019 4:46 PM, Stuart Marks wrote: On 10/3/19 8:32 AM, Joe Darcy wrote: In response to the r

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

On 10/3/19 8:32 AM, Joe Darcy wrote: In response to the recent and on-going review of serializable types in the base module and elsewhere, I thought it would be helpful if the collections specs discussed how collections were serialiazable. In particular, the proposed terminology is that a co

[14] RFR: DecimalFormat.setGroupingSize(int) allows setting negative grouping size

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8212749 The proposed CSR and changeset are located at: https://bugs.openjdk.java.net/browse/JDK-8231851 https://cr.openjdk.java.net/~naoto/8212749/webrev.00/ Naoto

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

On 10/4/19 2:16 PM, Peter Levart wrote: Oh god, a typo in a typo comment... I better go to sleep now ;-) It looks like Muphry's Law is still in force. s'marks

Re: RFR (XS): 8231161: Wrong return type in code sample in Collector API documentation

On 10/4/19 6:38 AM, Daniel Fuchs wrote: Hi Julia, On 03/10/2019 19:05, Julia Boes wrote: Hi Stuart, Thanks for the review. I made the changes you mentioned. Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231161/webrev.01/ Changes look good to me as well. I can sponsor this for you ne

Re: RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

Looks good. On 10/4/2019 12:14 PM, Alexey Semenyuk wrote: Yes, it is. Sorry, my bad, I didn't notice it. Looks good then! - Alexey On 10/4/2019 3:11 PM, Andy Herrick wrote: isn't what this change in BasicTest in this webrev does ? It passes on all platforms with Mach 5 builds. /Andy On 10/

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

Oh god, a typo in a typo comment... I better go to sleep now ;-) On 10/4/19 11:14 PM, Peter Levart wrote: + * serialized. Otherwise, is one or more objects in a collection are s/is/in/ s/is/if/ Peter

Re: JDK 14 RF(pre)R: add section on "conditionally serializable" collections

Hi Joe, On 10/3/19 5:32 PM, Joe Darcy wrote: Hello, In response to the recent and on-going review of serializable types in the base module and elsewhere, I thought it would be helpful if the collections specs discussed how collections were serialiazable. In particular, the proposed terminolo

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

Hi Andrew, That does seem more straightforward. The name ALWAYSCOMPACTABLE doesn't really match the rest of the nomenclature used in the compact string code. Can you change the name to LATIN1COMPATIBLE? Its similar to the ASCIICOMPATIBLE case and tied in to the Latin1 coding for used in Strin

Re: RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

Yes, it is. Sorry, my bad, I didn't notice it. Looks good then! - Alexey On 10/4/2019 3:11 PM, Andy Herrick wrote: isn't what this change in BasicTest in this webrev does ? It passes on all platforms with Mach 5 builds. /Andy On 10/4/2019 3:05 PM, Alexey Semenyuk wrote: Please enable `ALL-MO

Re: RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

isn't what this change in BasicTest in this webrev does ? It passes on all platforms with Mach 5 builds. /Andy On 10/4/2019 3:05 PM, Alexey Semenyuk wrote: Please enable `ALL-MODULE-PATH` parameter of BasicTest.testAddModules() test. It should pass with this fix. - Alexey On 10/4/2019 2:15

Re: RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

Please enable `ALL-MODULE-PATH` parameter of BasicTest.testAddModules() test. It should pass with this fix. - Alexey On 10/4/2019 2:15 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jp

RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change eliminates the ModuleManager class and uses ModuleFinder class to locate modules. [1] https://bugs.openjdk.java.net/browse/JDK-8231882 [

Re: RFR: JDK-8227715: GPLv2 files missing Classpath Exception

Hi Adam, Someone familiar with the history and usage of these files needs to be involved with changing the license  and that doesn't include me. Cheers, -Joe On 10/4/2019 2:12 AM, Adam Farley8 wrote: Hi Joe, That sounds reasonable. Would you, or another Oracle employee, mind sponsoring th

Re: RFR (XS): 8231161: Wrong return type in code sample in Collector API documentation

Hi Julia, On 03/10/2019 19:05, Julia Boes wrote: Hi Stuart, Thanks for the review. I made the changes you mentioned. Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231161/webrev.01/ Changes look good to me as well. I can sponsor this for you next week if Stuart doesn't have the bandwidth

Re: RFR: 8231717: Improve performance of EBCDIC charset decoding for COMPACT_STRINGS

Hi Roger, So based on your suggestion i've removed the logic from the constructor and it's now pre-determined by the charset generator tooling, just like isASCIICompatible is... It works really nicely, so there is now no impact on the constructor. I have verified this using the StrCodingBenchmar

Re: RFR: JDK-8231850: BasicTest test fails in jcov build

looks find. /Andy On 10/3/2019 8:17 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8231850 [2] http://cr.openjdk.java.net/~

Re: RFR: JDK-8215895: Verify and create tests for Mac installer specific signing options

looks good. /Andy On 10/3/2019 6:10 PM, Alexander Matveev wrote: http://cr.openjdk.java.net/~almatvee/8215895/webrev.01/ Changes since webrev.00 as per Alexey suggestions: - Reverted "@library /test/lib" jtreg directive when it is not needed. - jtreg.SkippedException exceptions will be used th

Re: RFR: JDK-8227715: GPLv2 files missing Classpath Exception

Hi Joe, That sounds reasonable. Would you, or another Oracle employee, mind sponsoring the change? Best Regards Adam Farley IBM Runtimes Joe Darcy wrote on 03/10/2019 23:30:14: > From: Joe Darcy > To: Florian Weimer , Adam Farley8 > Cc: jdk-updates-...@openjdk.java.net, Java Core Libs

Re: RFR: JDK-8227715: GPLv2 files missing Classpath Exception

Heya Florian Thanks for your thoughts. My understanding of the nuances of GPLv2 is limited, but a layman's summary could describe GPLv2 as "contagious", so it seems best to have all the GPLv2-licensed code tagged as having Classpath Exception just in case they end up "infecting" code that do

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Ivan, > On 4 Oct 2019, at 03:00, Ivan Gerasimov wrote: > > ... > > I've adopted your suggested changes and the test: > http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/ > LGTM. > CSR was also updated accordingly: > https://bugs.