On 10/10/19 9:54 AM, Anton Kozlov wrote:
Updated review is:
http://cr.openjdk.java.net/~akozlov/8231584/webrev.04/
Nit:
112 try {
113 loader = new TestClassLoader();
114 } catch (MalformedURLException e) {
115 throw new RuntimeException(e);
116
Sverre,
I've captured your input in [1]. Currently Windows installers are not
localized. We just have sources structured to support localization.
This is a major effort to implement if multiple languages in msi
installers generated by jpackage are required.
[1]
Looks good.
It would be good to have this fix accompanied with the relevant jtreg test.
- Alexey
On 10/9/2019 11:50 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
-
It should be possible to provide localized strings to the Windows installer
with jpackage.
WiX supports building localized installers through the use of language
files that include localized strings.
looks OK.
/Andy
On 10/9/2019 11:50 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Patch is based on JDK-8231856 fix.
- Fixed by using URI to escape URLs.
Hi Mandy,
On 10.10.2019 08:00, Mandy Chung wrote:
> 2014 static synchronized void initLibraryPaths() {
> This does not need synchronized since it's still during phase 1 before other
> thread can execute java code.
Thanks! I missed this
> LoadLibraryTest.java
> - please add @bug 8231584
> -
The javac changes looks good.
I guess I would have preferred to move the check for preview from Check
to Preview, and also create a tighter integration between
PreviewFeature.Feature and javac's Feature enum, so that we could
generate tight error messages, but I guess we can also do that as a
Hi Roger,
I've updated the webrev here :
http://cr.openjdk.java.net/~aleonard/8231717/webrev.02/
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Roger Riggs
To: Andrew Leonard
Cc: Alan
