java.lang.System's comment about initializeSystemClass

The java.lang.System has this code comment[1] which states: " /* Register the natives via the static initializer. * * VM will invoke the initializeSystemClass method to complete * the initialization for this class separated from clinit. * Note that to use properties set by the

Re: java.lang.System's comment about initializeSystemClass

On 18/10/2019 08:03, Jaikiran Pai wrote: However, I can't find that "initializeSystemClass" method anywhere in that class or any other class in the JDK code. Is that comment still relevant or am I looking in the wrong places? It's stale, the equivalent of what was initializeSystemClass is init

Re: java.lang.System's comment about initializeSystemClass

On 18/10/19 12:39 PM, Alan Bateman wrote: > On 18/10/2019 08:03, Jaikiran Pai wrote: >> >> However, I can't find that "initializeSystemClass" method anywhere in >> that class or any other class in the JDK code. Is that comment still >> relevant or am I looking in the wrong places? >> > It's stale

Re: JEP-343: jpackage Windows installer localization

fre. 18. okt. 2019 kl. 01:17 skrev Alexey Semenyuk < alexey.semen...@oracle.com>: > > > On 10/17/2019 6:10 PM, Sverre Moe wrote: > > I wonder if there is something I can contribute with to improve the > localization. Perhaps work further with the existing Localization that > exists for WiX in jpac

Re: RFR (S) 8232168: Fix non wide char canonicalization on Windows

On 16/10/2019 09:28, Schmelter, Ralf wrote: Hi David, the canonicalize() method is never used by java.io or any Java code. Currently it is used by the hotspot in classloader.cpp (which I use in the test) and in libinstrument in InvocationAdapter.c. There is no way to test it in core-libs. One

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

On 16/10/2019 18:06, Lance Andersen wrote: Hi all, Please review this fix to ZipFileInputStream::skip when specifying a negative value to the skip method when accessing a STORED entry, https://bugs.openjdk.java.net/browse/JDK-8231451 . Prior

Re: java.lang.System's comment about initializeSystemClass

On 18/10/2019 08:12, Jaikiran Pai wrote: : Thank you Alan. Should I create a JBS issue to track and have this changed? Yes, go ahead, we just missed updating this comment in JDK 9. -Alan

Re: RFR 8231451: ZipFileInputStream::skip handling of negative values with STORED entries

Thank you for the feedback Alan. > On Oct 18, 2019, at 7:18 AM, Alan Bateman wrote: > > On 16/10/2019 18:06, Lance Andersen wrote: >> Hi all, >> >> Please review this fix to ZipFileInputStream::skip when specifying a >> negative value to the skip method when accessing a STORED entry, >> https:

Re: RFR: JDK-8226585: Improve javac messages for using a preview API

Looks good - but I suggest garbage collecting the isEssentialAPI() from the @PreviewFeature annotation, as the new behavior effectively removes any distinctions between the two (unless I miss something). Maurizio On 16/10/2019 13:50, Jan Lahoda wrote: Hi, An updated patch is here: http://cr.

Re: JDK 14 RFR of JDK-8232230: Suppress warnings on non-serializable non-transient instance fields in java.util.concurrent

These look OK to me. We could change some declared types to ConditionObject for sake of clarifying some Condition usages, but it would not be an improvement. I did notice though that ForkJoinTask doc should include a caveat that is normally the case now, but will always hold under some upcoming c

Re: RFR: JDK-8231972: Build a stable list of jpackager tests for SQE

Looks good. /Andy On 10/17/2019 10:03 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8231972 [2] http://cr.openjd

Re: RFR: JDK-8226585: Improve javac messages for using a preview API

18. října 2019 14:05:45 SELČ, Maurizio Cimadamore napsal: >Looks good - but I suggest garbage collecting the isEssentialAPI() from > >the @PreviewFeature annotation, as the new behavior effectively removes > >any distinctions between the two (unless I miss something). I am afraid there is sti

Re: RFR: JDK-8223325: Improve wix sources generated by jpackage

This change seems ok to me, but since it is a fairly substantial change I want to test it locally a bit before integrating. I also think we should we should release another EA after this change is pushed. /Andy On 10/17/2019 6:24 PM, Alexey Semenyuk wrote: Please review the jpackage fix for

Re: RFR: JDK-8223325: Improve wix sources generated by jpackage

Sounds good. - Alexey On 10/18/2019 8:45 AM, Andy Herrick wrote: This change seems ok to me, but since it is a fairly substantial change I want to test it locally a bit before integrating. I also think we should we should release another EA after this change is pushed. /Andy On 10/17/2019

Re: java.lang.System's comment about initializeSystemClass

On 18/10/19 4:51 PM, Alan Bateman wrote: > On 18/10/2019 08:12, Jaikiran Pai wrote: >> : >> Thank you Alan. Should I create a JBS issue to track and have this >> changed? >> > Yes, go ahead, we just missed updating this comment in JDK 9. Done - https://bugs.openjdk.java.net/browse/JDK-8232617

Re: RFR: JDK-8226585: Improve javac messages for using a preview API

Sorry, I got the table in the CSR completely mixed up. So, the new behavior only really changes the fact that essential API warnings are now suppressible when using --enable-preview. I now see the relevant difference in Check.java. Looks good Maurizio On 18/10/2019 13:38, Jan Lahoda wrote:

RFR: JDK-8232281,,jpackage is not always reporting an error when no main class specified

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fixes the case where using runtime-image prevented checking for no main class being specified. [1] https://bugs.openjdk.java.net/browse/JDK-8232

Re: JEP-343: jpackage Windows installer localization

On 10/18/2019 4:41 AM, Sverre Moe wrote: fre. 18. okt. 2019 kl. 01:17 skrev Alexey Semenyuk mailto:alexey.semen...@oracle.com>>: On 10/17/2019 6:10 PM, Sverre Moe wrote: I wonder if there is something I can contribute with to improve the localization. Perhaps work further with

Re: RFR: JDK-8232281, , jpackage is not always reporting an error when no main class specified

Looks good. - Alexey On 10/18/2019 10:53 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fixes the case where using runtime-image prevented checking for no main class

Loading classes during VM shutdown

For JDK-8232081 (Try to link all classes with ArchiveClassesAtExit), when creating a dynamic CDS archive, I need to link all classes in the "loaded" state. I am thinking of doing it at this point: src/java.base/share/classes/java/lang/Shutdown.java:     private static void runHooks() {    

Review Request JDK-8232617: Update the outdated code comments in java.lang.System class

A trivial doc fix: diff --git a/src/java.base/share/classes/java/lang/System.java b/src/java.base/share/classes/java/lang/System.java --- a/src/java.base/share/classes/java/lang/System.java +++ b/src/java.base/share/classes/java/lang/System.java @@ -94,10 +94,8 @@ public final class System {

Re: Review Request JDK-8232617: Update the outdated code comments in java.lang.System class

Looks fine. You might consider s/separated/separately/ . -Brent On 10/18/19 1:56 PM, Mandy Chung wrote: A trivial doc fix: diff --git a/src/java.base/share/classes/java/lang/System.java b/src/java.base/share/classes/java/lang/System.java --- a/src/java.base/share/classes/java/lang/System.j

Re: RFR: JDK-8232281, , jpackage is not always reporting an error when no main class specified

Looks good. On 10/18/2019 7:53 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fixes the case where using runtime-image prevented checking for no main class being speci

Re: RFR: JDK-8223325: Improve wix sources generated by jpackage

Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java.frames.html Line 180: man -> main http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java.fr

Re: RFR: JDK-8223325: Improve wix sources generated by jpackage

Little bit late, Andy has pushed the patch already. Please find my comment below. On 10/18/2019 6:15 PM, Alexander Matveev wrote: Hi Alexey, http://cr.openjdk.java.net/~asemenyuk/8223325/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java.frames.html Line 180: m

Re: Review Request JDK-8232617: Update the outdated code comments in java.lang.System class

thanks. I think "separated from" reads right to me.  I will leave it as is. Mandy On 10/18/19 2:46 PM, Brent Christian wrote: Looks fine.  You might consider s/separated/separately/ . -Brent On 10/18/19 1:56 PM, Mandy Chung wrote: A trivial doc fix: diff --git a/src/java.base/share/classes