RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
This change implements jlink plugins, and associated changes in the VM
and libraries, to support the following new jlink options:
- --
Hi Claes,
My only nit with this is that I don't think register_native and friends
belongs in the SystemDictionary class as it has nothing to do with the
SD. This code seems to be all about Methods so that seems like the place
to put this.
Thanks,
David
On 22/10/2019 12:55 am, Claes Redestad
+1
On 22/10/2019 4:03 am, Claes Redestad wrote:
On 2019-10-21 19:58, Alexey Ivanov wrote:
Just to confirm: Is the patch
http://cr.openjdk.java.net/~aivanov/8232624/webrev.00/
approved?
Ship it!
/Claes
+1
Thanks,
David
On 22/10/2019 6:33 am, Brent Christian wrote:
Looks great. -B
On 10/21/19 10:10 AM, Mandy Chung wrote:
>
Thanks. Updated:
/* Register the natives via the static initializer.
*
* The VM will invoke the initPhase1 method to complete the
initialization
Looks great. -B
On 10/21/19 10:10 AM, Mandy Chung wrote:
>
Thanks. Updated:
/* Register the natives via the static initializer.
*
* The VM will invoke the initPhase1 method to complete the initialization
* of this class separate from .
*/
On 10/18/19 2:46 PM, B
Hi all,
Please review the serialization changes to support records.
Thanks,
Vicente
http://cr.openjdk.java.net/~vromero/records.review/serialization/webrev.00/
Hi David, Claes, Alan,
Thank you for your reviews!
Just to confirm: Is the patch
http://cr.openjdk.java.net/~aivanov/8232624/webrev.00/
approved?
The cleanup to avoid indirection for calling JNU_NewStringPLatform will
be addressed in the follow-up issue
https://bugs.openjdk.java.net/browse/JD
On 2019-10-21 19:58, Alexey Ivanov wrote:
Just to confirm: Is the patch
http://cr.openjdk.java.net/~aivanov/8232624/webrev.00/
approved?
Ship it!
/Claes
On 10/20/19 3:50 PM, David Holmes wrote:
On 19/10/2019 10:38 am, Mandy Chung wrote:
thanks. I think "separated from" reads right to me. I will leave it
as is.
I think "separately" or "separate" seems more correct here. And if
we're picking on grammar then it should be "The VM ..." and "of th
+1. Thanks Aleksei!
-Joe
On 10/21/19 6:09 AM, Aleks Efimov wrote:
Hi,
The BCEL version has been updated to 6.3.1 by JDK-8224157 [1]. The
BCEL license file needs to be updated to include the correct version.
Webrev: http://cr.openjdk.java.net/~aefimov/8232713/00
JBS: https://bugs.openjdk.ja
Hi,
Object.java currently registers various native functions via the
registerNatives facility.
private static native void registerNatives();
static {
registerNatives();
}
Not costly in and off itself, but this has the side effect that these
two methods are taken into accoun
Hi David,
On 21/10/2019 14:00, David Holmes wrote:
On 21/10/2019 10:14 pm, Alexey Ivanov wrote:
Hi David,
On 21/10/2019 02:19, David Holmes wrote:
So what would happen if we drop the JNICALL from JNU_NewStringPLatform?
Yes, it will be found by its undecorated name too.
But I'd rather not
I have filed
https://bugs.openjdk.java.net/browse/JDK-8232724
"Remove indirection with calling JNU_NewStringPlatform"
On 21/10/2019 13:49, Claes Redestad wrote:
On 2019-10-21 14:14, Alexey Ivanov wrote:
Probably, Claes thought "NewStringPlatform" wasn't used. Yet it
proved that "NewStringPlat
Yes - we should fix.
filed issue: https://bugs.openjdk.java.net/browse/JDK-8232723
/Andy
On 10/20/2019 9:49 AM, Nicolas Roduit wrote:
Hi,
Previously the WiX script could be overloaded in the resource
directory but not anymore. Is there a reason?
It seems important to me to be able to modif
(adding core-libs-dev)
Ping?
> I just realized that this has still not been reviewed. Can I do anything
> to move forward?
>
> Thanks,
> Roman
>
>> I added one extra verification to the JAXP based properties parser to
>> verify that no extra internal DTD is being supplied. As far as I can
>> t
Hi,
The BCEL version has been updated to 6.3.1 by JDK-8224157 [1]. The BCEL
license file needs to be updated to include the correct version.
Webrev: http://cr.openjdk.java.net/~aefimov/8232713/00
JBS: https://bugs.openjdk.java.net/browse/JDK-8232713
With Best Regards,
Aleksei
[1] https://b
On 21/10/2019 10:14 pm, Alexey Ivanov wrote:
Hi David,
On 21/10/2019 02:19, David Holmes wrote:
Hi Alexey,
On 21/10/2019 9:37 am, Alexey Ivanov wrote:
Hi David,
On 20/10/2019 23:59, David Holmes wrote:
Hi Alexey,
On 21/10/2019 2:20 am, Alexey Ivanov wrote:
Hello,
Please review the fol
On 2019-10-21 14:14, Alexey Ivanov wrote:
Probably, Claes thought "NewStringPlatform" wasn't used. Yet it proved
that "NewStringPlatform" is still used.
If required, I can create a follow-up issue to re-do the cleanup as Alan
suggested.
Yes, please. If some or even just one platform needs
Hi David,
On 21/10/2019 02:19, David Holmes wrote:
Hi Alexey,
On 21/10/2019 9:37 am, Alexey Ivanov wrote:
Hi David,
On 20/10/2019 23:59, David Holmes wrote:
Hi Alexey,
On 21/10/2019 2:20 am, Alexey Ivanov wrote:
Hello,
Please review the following fix which it brings back
NewStringPlatfor
On 10/16/19 10:49 AM, Amy Lu wrote:
> I think it's fine and worth to enable them in standard testing. I'll
> continue monitor the results and make necessary adjustment if they cause
> any issue.
>
> Any concerns? Please let me know.
It might be worth disabling such tests in Zero builds.
--
An
20 matches
Mail list logo
