Hi, Vladimir
I'd prefer to keep the code as is. Perhaps the exception could help
some other future maintainer to pinpoint a problem with a potential change.
-Brent
On 10/24/19 5:11 AM, Vladimir Yaroslavskiy wrote:
Hi Brent,
Looking at coverage of DualPivotQuicksort class, I found that
case
Hi, Vladimir
Thanks for the explanation of the changes to LONG_RUN_LENGTHS and
SHORT_RUN_LENGTHS.
I've incorporated the other suggested changes:
http://cr.openjdk.java.net/~bchristi/8226297/webrev10/
-Brent
On 10/24/19 4:30 AM, Vladimir Yaroslavskiy wrote:
Hi Brent,
See my comments inline
Ping.
Naoto
On 10/9/19 3:39 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8231273
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8231273/webrev.00/
The webrev is huge, but majority of th
Looks good.
On 10/23/2019 7:00 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8223323
[2] http://cr.openjdk.java.n
yes - this looks good.
/Andy
On 10/23/2019 9:59 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8230612
[2] http:/
Looks good.
On 10/23/2019 6:59 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8230612
[2] http://cr.openjdk.java.n
On 24/10/2019 17:32, seth lytle wrote:
The use case that's always interested me is checking to see if a
callback to a recursive method (eg during parsing) is "too deep" so
you can bail out (eg, to a non-recursive one or using message
passing). For that purpose, it's already suspended and the nati
There is cost to examine the stack frames. The StackWalker API allows
you to fetch the stack frames one batch at a time to avoid unnecessary
deoptimization to frames that are not traversed. In addition,it can
specify to include/exclude the hidden frames and/or reflection
implementation-specif
+1
Brian
> On Oct 24, 2019, at 8:35 AM, Joe Darcy wrote:
>
> +1
>
> -Joe
>
> On 10/24/2019 8:33 AM, Igor Ignatev wrote:
>> LGTM
>>
>> — Igor
>>
>>> On Oct 24, 2019, at 1:49 AM, Amy Lu wrote:
>>>
>>> java/math/BigInteger/largeMemory/SymmetricRangeTests.java
>>>
>>> Please review the patc
The use case that's always interested me is checking to see if a
callback to a recursive method (eg during parsing) is "too deep" so
you can bail out (eg, to a non-recursive one or using message
passing). For that purpose, it's already suspended and the native
method is close to what I'd like if it
> I would like to review this change. Would you mind holding off for a few
> days until I can find time?
OK, sure. Then I'll wait for you.
Cheers
Christoph
On 24/10/2019 16:25, Langer, Christoph wrote:
Thanks, Calvin for the review.
Alan, unless you have severe objections I'd push this tomorrow after running
another night of tests with this patch and run doing jdk-submit. Is that ok
with you?
I would like to review this change. Would you mind ho
+1
-Joe
On 10/24/2019 8:33 AM, Igor Ignatev wrote:
LGTM
— Igor
On Oct 24, 2019, at 1:49 AM, Amy Lu wrote:
java/math/BigInteger/largeMemory/SymmetricRangeTests.java
Please review the patch to add above test to ProblemList-Xcomp.txt while
JDK-8232840 is being investigated/fixed.
bug: htt
LGTM
— Igor
> On Oct 24, 2019, at 1:49 AM, Amy Lu wrote:
>
> java/math/BigInteger/largeMemory/SymmetricRangeTests.java
>
> Please review the patch to add above test to ProblemList-Xcomp.txt while
> JDK-8232840 is being investigated/fixed.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-82
Thanks, Calvin for the review.
Alan, unless you have severe objections I'd push this tomorrow after running
another night of tests with this patch and run doing jdk-submit. Is that ok
with you?
Thanks
Christoph
> -Original Message-
> From: Calvin Cheung
> Sent: Mittwoch, 23. Oktober 2
Looks good to me.
/Andy
On 10/23/2019 10:00 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8223323
[2] http://cr.
Hi Brent,
Looking at coverage of DualPivotQuicksort class, I found that
cases of unexpected type of given array are not invoked at all
(mentioned in my previous email).
I think that these "else" can be removed, because method
compute() of private classes are invoked from DualPivotQuicksort
class
Hi Brent,
See my comments inline
>Oct 24б 2019, 7:42 +03:00 от Brent Christian :
>
>Hi,
>
>I've created a webrev of the latest test changes that Vladimir sent me:
>
>http://cr.openjdk.java.net/~bchristi/8226297/webrev09-testUpdate/
>
>(I also created an incremental webrev[1] along the way, in cas
java/math/BigInteger/largeMemory/SymmetricRangeTests.java
Please review the patch to add above test to ProblemList-Xcomp.txt while
JDK-8232840 is being investigated/fixed.
bug: https://bugs.openjdk.java.net/browse/JDK-8232922
Thanks,
Amy
--- old/test/jdk/ProblemList-Xcomp.txt 2019-10-24 1
On 23/10/2019 23:00, seth lytle wrote:
At least a couple appear to be recently active, though I don't have
current access. Maybe an IDE generates boilerplate for proxies and
ignores deprecation ?
is the speed of the StackWalker approach to counting frames comparable
to the current native method
20 matches
Mail list logo
