Re: Question about String.toUpperCase behaviour

> That doesn't remove the performance difference when the string is NOT upper > case. When the code is C2 compiler there is no significant difference, but in interpreter mode it's noticeable. @OutputTimeUnit(TimeUnit.NANOSECONDS) @BenchmarkMode(value = Mode.AverageTime) public class StringEquali

Re: RFR 8233091 : Backout JDK-8212117: Class.forName loads a class but not linked if class is not initialized

On 31/10/2019 22:50, Brent Christian wrote: Hi, Please review my change to backout JDK-8212117: http://cr.openjdk.java.net/~bchristi/8233091/webrev-revert-01/ The backout looks right. -Alan

Re: RFR of JDK-8233313: server socket created by LocateRegistry.createRegistry(0) can not be closed

This is found during fixing JDK-8233105 , so please consider test scenario in JDK-8233105 On 2019/11/1 12:47 PM, Hamlin Li wrote: Would you please to review the following patch? bug: https://

RFR of JDK-8233313: server socket created by LocateRegistry.createRegistry(0) can not be closed

Would you please to review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8233313 webrev: http://cr.openjdk.java.net/~mli/8233313/webrev.00/ With following code, port used behind is not closed after unexportObject /Registry registry = LocateRegistry.createRegistry(0);// //b

Re: RFR: 8233291: [TESTBUG] tools/jlink/plugins/VendorInfoPluginsTest.java fails with debug VMs

Hi Mandy, Thanks for your review and nice suggestion. Updated: http://cr.openjdk.java.net/~jiefu/8233291/webrev.01/ I had added '@requires vm.flavor == "server"' since the test is only suitable for server VMs. Testing:   --     Ben="tools/jlink/plugins/VendorIn

Re: RFR 8233091 : Backout JDK-8212117: Class.forName loads a class but not linked if class is not initialized

This looks good to me. Mandy On 10/31/19 3:50 PM, Brent Christian wrote: Hi, Please review my change to backout JDK-8212117: http://cr.openjdk.java.net/~bchristi/8233091/webrev-revert-01/ Background: A couple months ago, JDK-8212117[1] was fixed[2].  It changed the behavior of the 2-arg and

Re: RFR 8233091 : Backout JDK-8212117: Class.forName loads a class but not linked if class is not initialized

Hi Brent, This looks like an accurate backout to me. Thanks, David - On 1/11/2019 8:50 am, Brent Christian wrote: Hi, Please review my change to backout JDK-8212117: http://cr.openjdk.java.net/~bchristi/8233091/webrev-revert-01/ Background: A couple months ago, JDK-8212117[1] was fixed[

RFR 8233091 : Backout JDK-8212117: Class.forName loads a class but not linked if class is not initialized

Hi, Please review my change to backout JDK-8212117: http://cr.openjdk.java.net/~bchristi/8233091/webrev-revert-01/ Background: A couple months ago, JDK-8212117[1] was fixed[2]. It changed the behavior of the 2-arg and 3-arg Class.forName methods to ensure that linking is performed. This con

Re: RFR: JDK-8233265: jpackage --add-modules cannot find additional modules with non-modular app

Looks good. On 10/31/2019 2:02 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a fixes a regression from the fix to JDK-8231882

Re: RFR: JDK-8233333: Incorrect comparison of number version strings in ToolValidator

Looks good. On 10/31/2019 12:11 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally: - fixed issue with truncated log output of jtreg tests (added maxOutputSize=

Re: RFR: JDK-8233265: jpackage --add-modules cannot find additional modules with non-modular app

Looks good. - Alexey On 10/31/2019 5:02 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a fixes a regression from the fix to JDK-8231882

Re: RFR: JDK-8233333: Incorrect comparison of number version strings in ToolValidator

looks good. /Andy On 10/31/2019 3:11 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally: - fixed issue with truncated log output of jtreg tests (added maxOutpu

Re: RFR: JDK-8233265: jpackage --add-modules cannot find additional modules with non-modular app

Looks good. -- Kevin On 10/31/2019 2:02 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a fixes a regression from the fix to JDK-8231882

RFR: JDK-8233265: jpackage --add-modules cannot find additional modules with non-modular app

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This is a fixes a regression from the fix to JDK-8231882 and improves behavior when module listed i

RFR: JDK-8233333: Incorrect comparison of number version strings in ToolValidator

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Additionally: - fixed issue with truncated log output of jtreg tests (added maxOutputSize=200 to TEST.properties) - fixed issue in code looking up

Re: RFR: 8233291: [TESTBUG] tools/jlink/plugins/VendorInfoPluginsTest.java fails with debug VMs

Hi Jie, On 10/30/19 11:13 PM, Jie Fu wrote: Hi all, May I get reviews for the small fix for the failure of VendorInfoPluginsTest.java in debug VMs? JBS:    https://bugs.openjdk.java.net/browse/JDK-8233291 Webrev: http://cr.openjdk.java.net/~jiefu/8233291/webrev.00/ Thanks for fixing this.

Re: RFR: JDK-8232186: Add verification for pkg and dmg tests

looks good /Andy On 10/30/19 8:37 PM, Alexander Matveev wrote: http://cr.openjdk.java.net/~almatvee/8232186/webrev.04/ - Added trace to Hello.java. - Re-done how FA is excluded for DMG tests. Thanks, Alexander On 10/29/2019 10:42 AM, Alexey Semenyuk wrote: http://cr.openjdk.java.net/~almatv

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

Thanks Doug! Appreciate the help getting the Graal bits correct. David On 31/10/2019 5:47 pm, Doug Simon wrote: On 31 Oct 2019, at 05:30, David Holmes > wrote: Hi Doug, On 30/10/2019 10:06 pm, Doug Simon wrote: On 30 Oct 2019, at 05:28, David Holmes

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

> On 31 Oct 2019, at 05:30, David Holmes wrote: > > Hi Doug, > > On 30/10/2019 10:06 pm, Doug Simon wrote: >>> On 30 Oct 2019, at 05:28, David Holmes >> > wrote: >>> >>> Hi Doug, >>> >>> Your proposed patch wasn't quite right. I made some adjustments but I'm