Whatever you are comfortable with, we will have the final patch reviewed on the
public list though.
Please keep me in the direct email recipient to make sure I read the email in
time.
Cheers,
Henry
> On Nov 4, 2019, at 3:40 PM, Mat Carter wrote:
>
> Thanks Henry
>
> I'm working on a test,
Hi,
Please review the draft of the CSR for javax.lang.model support for
records at [1]
Thanks,
Vicente
[1]https://bugs.openjdk.java.net/browse/JDK-8233546
Today I took the jpackage tool for another spin, using build
14-jpackage+1-64 from https://jdk.java.net/jpackage.
This looks much better! The simple command line
$ jpackage -p lib -m org.openjdk.hello -n hello
did exactly what I expected, and the resulting package installed (and
uninstalled)
Thanks Henry
I'm working on a test, do you want me to share directly with you (incl.
questions) or continue with comms through the mailing list
Cheers
Mat
From: Henry Jen
Sent: Monday, November 4, 2019 12:47 PM
To: Mat Carter
Cc: core-libs-dev@openjdk.java.net
Hello,
On 11/4/2019 1:27 PM, Florian Weimer wrote:
* Vicente Romero:
Please review the draft of the CSR for Core-libs support for records at [1]
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8233436
I would have expected something regarding serialization in the
description of
Thanks for confirmation and for updating the bug Henry.
Please let me know if there's anything else related to this issue I can help
with; tests and/or verification etc.
In the meantime, I'll take a look at the existing ArgsFile tests for my own
education.
Cheers
Mat
__
* Vicente Romero:
> Please review the draft of the CSR for Core-libs support for records at [1]
>
> Thanks,
> Vicente
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8233436
I would have expected something regarding serialization in the
description of java.lang.Record.
Right now, it appears to
Hi,
Please review the draft of the CSR for Core-libs support for records at [1]
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8233436
Hi Mat,
I’ll sponsor this fix, let me know if you are coming up with test and I’ll work
with you to get your patch committed.
Cheers,
Henry
> On Nov 4, 2019, at 9:21 AM, Henry Jen wrote:
>
> The fix is on the spot, good catch.
>
> As the test, test/jdk/tools/launcher/ArgsFileTest.java is te
The fix is on the spot, good catch.
As the test, test/jdk/tools/launcher/ArgsFileTest.java is testing the file
expansions, we can add a test case there to have an argument file not have
newline at the end, and check that we get correct arguments.
Cheers,
Henry
> On Nov 1, 2019, at 7:06 AM, Ma
technically - even this minuscule change in CompileJavaModules should be
reviewed by build team.
overall this looks good. I might agree that the variables that can be
overridden in overrides.wxi need to be documented, possibly in a comment
in the default overrides.wxi.
/Andy
On 11/2/2019 1
Looks fine to me. I can push this for you.
Regards,
Sean.
On 04/11/19 10:04, Kiran Ravikumar wrote:
Hi,
Please review this patch to update the joni version to 2.1.16.
JBS: https://bugs.openjdk.java.net/browse/JDK-8232984
License File: https://github.com/jruby/joni/blob/joni-2.1.16/LICENSE
Hi,
Please review this patch to update the joni version to 2.1.16.
JBS: https://bugs.openjdk.java.net/browse/JDK-8232984
License File: https://github.com/jruby/joni/blob/joni-2.1.16/LICENSE
Patch File:
diff -r ab4db38ed085 src/jdk.scripting.nashorn/share/legal/joni.md
--- a/src/jdk.scripting
13 matches
Mail list logo
