Re: Turkish Time Zone name string and translation

2019-11-23 Thread naoto . sato
Looks good. Naoto On 11/22/19 9:55 PM, Yang, Letu wrote: Hi Naoto, Added it in the new webrev https://cr.openjdk.java.net/~xliu/8234288/webrev.03/ . Thanks! Letu On Nov 22, 2019 4:40 PM, naoto.s...@oracle.com wrote: Hi Letu, You might want to add lines for "Turkey" zone as well in Locale

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-23 Thread Johannes Kuhn
On 11/23/2019 10:40 PM, Brian Goetz wrote: Finally, we can benchmark the current approach against the LDC approach on a per-Method basis.  The LDC approach may well be doing more work per Method, so it's a tradeoff to determine whether deferring that work is a win. By this last bit, I mea

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-23 Thread Brian Goetz
Finally, we can benchmark the current approach against the LDC approach on a per-Method basis.  The LDC approach may well be doing more work per Method, so it's a tradeoff to determine whether deferring that work is a win. By this last bit, I mean JMH'ing:     Method m1() {    return

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-23 Thread Brian Goetz
I just finished the first prototype, which can be found at https://gist.github.com/DasBrain/7766bedfbc8b76ba6a0ee66a54ba97ed - it contains a patch, the javap output of a generated proxy class with and without that patch, and the code I used to dump the proxy class. "make run-test-tier1" pass

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-23 Thread Johannes Kuhn
On 11/23/2019 6:09 PM, Brian Goetz wrote: Thanks for the examples. A few comments:   - A reasonable place to consider putting the bootstrap is in Proxy itself.  I am not sure that ConstantBootstraps is the right place (or anywhere in JLI for that matter) unless Method is retrofitted to imple

Re: jpackage ROOTDIR variable in a Windows bat file

2019-11-23 Thread Michael Hall
> On Nov 23, 2019, at 11:22 AM, Kevin Rushforth > wrote: > > I just tried this and it worked fine for me: > > jpackage --java-options '-Djava.security.policy=$APPDIR/all.policy' ... > > (note that there should not be an extra "/app" since $APPDIR points to the > app directory). > > It gen

Re: jpackage ROOTDIR variable in a Windows bat file

2019-11-23 Thread Kevin Rushforth
I just tried this and it worked fine for me: jpackage --java-options '-Djava.security.policy=$APPDIR/all.policy' ... (note that there should not be an extra "/app" since $APPDIR points to the app directory). It generated this in the ApplicationName/app/ApplicationName.cfg file: [JavaOptions]

Re: jpackage ROOTDIR variable in a Windows bat file

2019-11-23 Thread Michael Hall
> > With forward slashes > > Error: Invalid Option: [-Djava.security.policy=$ROOTDIR/app/all.policy] Sorry that should of been APPDIR. manually cutting and pasting with edit since I can’t currently cut and paste directly between Windows VirtualBox and OS X.

Re: jpackage ROOTDIR variable in a Windows bat file

2019-11-23 Thread Michael Hall
> On Nov 23, 2019, at 10:51 AM, Kevin Rushforth > wrote: > > $ROOTDIR is not a supported interface. You should use "$APPDIR" instead. > Having said that, the real problem is likely your use of backslashes. I > recommend using forward slashes and also enclosing it in single quotes, like > t

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-23 Thread Brian Goetz
Thanks for the examples. A few comments: - A reasonable place to consider putting the bootstrap is in Proxy itself. I am not sure that ConstantBootstraps is the right place (or anywhere in JLI for that matter) unless Method is retrofitted to implement Constable, which is problematic given

Re: jpackage ROOTDIR variable in a Windows bat file

2019-11-23 Thread Kevin Rushforth
$ROOTDIR is not a supported interface. You should use "$APPDIR" instead. Having said that, the real problem is likely your use of backslashes. I recommend using forward slashes and also enclosing it in single quotes, like this:     -Djava.security.policy='$APPDIR/all.policy' If you need to us

jpackage ROOTDIR variable in a Windows bat file

2019-11-23 Thread Michael Hall
I am trying to come up with a simple Windows bat file execution of jpackage. I would like to use the builtin ROOTDIR variable. How should this be done? Not very familiar with Windows. This -Djava.security.policy=$ROOTDIR\app\all.policy Gets Error: Invalid Option: [-Djava.security.policy=$ROOTDIR