Re: jpackage ROOTDIR variable in a Windows bat file

2019-11-24 Thread Michael Hall
> On Nov 23, 2019, at 11:45 AM, Michael Hall wrote: > > > >> On Nov 23, 2019, at 11:22 AM, Kevin Rushforth >> wrote: >> >> I just tried this and it worked fine for me: >> >> jpackage --java-options '-Djava.security.policy=$APPDIR/all.policy' ... >> >> (note that there should not be an e

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

2019-11-24 Thread David Holmes
On 25/11/2019 8:45 am, David Holmes wrote: On 25/11/2019 7:49 am, David Holmes wrote: On 25/11/2019 7:33 am, David Holmes wrote: Hi Christoph, On 23/11/2019 12:04 am, Langer, Christoph wrote: Hi, I'd like to push this change. However, running it through jdk-submit shows reproducible erro

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

2019-11-24 Thread David Holmes
On 25/11/2019 7:49 am, David Holmes wrote: On 25/11/2019 7:33 am, David Holmes wrote: Hi Christoph, On 23/11/2019 12:04 am, Langer, Christoph wrote: Hi, I'd like to push this change. However, running it through jdk-submit shows reproducible errors: Job: mach5-one-clanger-JDK-8234185-1-2019

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

2019-11-24 Thread David Holmes
On 25/11/2019 7:33 am, David Holmes wrote: Hi Christoph, On 23/11/2019 12:04 am, Langer, Christoph wrote: Hi, I'd like to push this change. However, running it through jdk-submit shows reproducible errors: Job: mach5-one-clanger-JDK-8234185-1-20191122-0927-6913189 BuildId: 2019-11-22-092637

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

2019-11-24 Thread David Holmes
Hi Christoph, On 23/11/2019 12:04 am, Langer, Christoph wrote: Hi, I'd like to push this change. However, running it through jdk-submit shows reproducible errors: Job: mach5-one-clanger-JDK-8234185-1-20191122-0927-6913189 BuildId: 2019-11-22-0926373.christoph.langer.source No failed tests Tas

Re: Looking for Sponsor: JDK-8229959 Convert proxy class to use constant dynamic

2019-11-24 Thread Brian Goetz
OK, interesting.  Your interpretation seems right; that getting the MH is a big part of the expense of the LDC approach.  Caching simulates using Constant_MethodHandle_info, so that's a fair comparision.  It's not clear whether there's a performance difference getting the MH via lookup (as your