JDK 14 RFR of JDK-8234781: Update description of InvalidClassException to include more conditions

Hello, Noticed in the context of doing some other reviews, the spec for the serialization exception InvalidClassException does not have an exhaustive and up-date-date listing of the conditions where the exception in thrown:     JDK-8234781: Update description of InvalidClassException to

[14] RFR: 8222756: Plural support in CompactNumberFormat

Hello, CompactNumberFormat has been added since JDK 12 to support compact number formatting, such as 10_000 being formatted as "10K." [1] It works fine for English, however, not for other languages that take plural forms in formatted number prefixes/suffixes. In order to fix this, I filed

Re: New candidate JEP: 370: Foreign-Memory Access API

On 25/11/2019 20:04, David Lloyd wrote: On Mon, Nov 25, 2019 at 11:28 AM wrote: https://openjdk.java.net/jeps/370 Looks pretty interesting! Why make the API user deal with VarHandles though, as opposed to (say) putting accessor methods directly onto MemoryAddress? While this could be

Re: New candidate JEP: 370: Foreign-Memory Access API

On Mon, Nov 25, 2019 at 11:28 AM wrote: > > https://openjdk.java.net/jeps/370 Looks pretty interesting! Why make the API user deal with VarHandles though, as opposed to (say) putting accessor methods directly onto MemoryAddress? -- - DML

Re: RFR: JEP 367: Remove the Pack200 Tools and API

On 11/22/19 1:30 PM, Vicente Romero wrote: [1] http://cr.openjdk.java.net/~vromero/8234542/webrev.03/ make/lib/Lib-jdk.pack.gmk should be removed. make/scripts/compare_exceptions.sh.incl     Should ./lib/libunpack.so also be removed? make/scripts/compare.sh     line 535-543 invokes

Re: Turkish Time Zone name string and translation

Fixed in https://cr.openjdk.java.net/~xliu/8234288/webrev.04/ Thanks! From: Martin Buchholz Date: Monday, November 25, 2019 at 10:27 AM To: "Yang, Letu" Cc: "core-libs-dev@openjdk.java.net" , "i18n-...@openjdk.java.net" , "naoto.s...@oracle.com" , Leo Jiang , "Liu, Xin" Subject: Re:

Re: Turkish Time Zone name string and translation

\ No newline at end of file Please fix.

Re: jpackage ROOTDIR variable in a Windows bat file

On 11/25/2019 1:13 PM, Michael Hall wrote: --install-dir ./outputdir Are you sure you want your app to be installed in %ProgramFiles%\outputdir directory? I need to look at your detailed discussion of this. --install-dir parameter specifies directory where your app will be installed.

Re: jpackage ROOTDIR variable in a Windows bat file

>>> --install-dir ./outputdir > Are you sure you want your app to be installed in %ProgramFiles%\outputdir > directory? I need to look at your detailed discussion of this. > >>> >>> --name HalfPipe >>> --runtime-image "c:/Program Files/Java/jdk-14" > --runtime-image and --add-modules

Re: jpackage ROOTDIR variable in a Windows bat file

>> >> > > 1.) - you might learn more by running with --verbose ('jpackage @jpkg.txt > --verbose') if you can sift thry the excess output. > > 2.) in my test app I need to escape the '$' in front of APPDIR because > command is being processed first by shell, for example I have: ( >

Re: jpackage ROOTDIR variable in a Windows bat file

On 11/25/2019 9:00 AM, Andy Herrick wrote: On 11/24/2019 10:41 PM, Michael Hall wrote: On Nov 23, 2019, at 11:45 AM, Michael Hall wrote: On Nov 23, 2019, at 11:22 AM, Kevin Rushforth wrote: I just tried this and it worked fine for me: jpackage --java-options

Re: jpackage ROOTDIR variable in a Windows bat file

On 11/23/2019 12:10 PM, Michael Hall wrote: On Nov 23, 2019, at 10:51 AM, Kevin Rushforth wrote: $ROOTDIR is not a supported interface. You should use "$APPDIR" instead. Having said that, the real problem is likely your use of backslashes. I recommend using forward slashes and also

New candidate JEP: 370: Foreign-Memory Access API

https://openjdk.java.net/jeps/370 - Mark

Re: RFR: 8132359 - JarURLConnection.getJarFile() resource leak when file is not found

I'm afraid so. The option of changing the the JarURLConnection spec to indicate what could happen when the class file is missing was discussed but that will require some further thought. (and it may not necessarily result in a fix for this problem, the assumption being that behaviour changes in

Re: 8179320: File.getUsableSpace() returns a negative number on very large file system

On 15/11/2019 22:40, Brian Burkhalter wrote: On Nov 15, 2019, at 2:59 AM, Alan Bateman > wrote: On 02/11/2019 00:13, Brian Burkhalter wrote: For this issue [1], please review this patch [2] and the corresponding CSR [3]. One thing that isn't clear is how

Re: jpackage ROOTDIR variable in a Windows bat file

On 11/24/2019 10:41 PM, Michael Hall wrote: On Nov 23, 2019, at 11:45 AM, Michael Hall wrote: On Nov 23, 2019, at 11:22 AM, Kevin Rushforth wrote: I just tried this and it worked fine for me: jpackage --java-options '-Djava.security.policy=$APPDIR/all.policy' ... (note that there

Re: RFR: 8132359 - JarURLConnection.getJarFile() resource leak when file is not found

Daniel's summary is useful but changing URLClassPath doesn't feel right. Are you in a hurry to find a solution to this? Just asking as I think I'd prefer to see other options explored that fixed it in the protocol handler instead. -Alan On 25/11/2019 13:31, Rob McKenna wrote: Thanks

RFR: 8132359 - JarURLConnection.getJarFile() resource leak when file is not found

Thanks Daniel, cc'ing core-libs-dev in case there are any objections. -Rob On 25/11/19 10:47, Daniel Fuchs wrote: > Hi Rob, > > That looks good to me. I wonder if that should go to corelibs for > review as well. > > The underlying issue here is that JarURLConnection open both its > jar

Re: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

Hi Christoph, On 25/11/2019 10:38 pm, Langer, Christoph wrote: Hi David, thanks for your investigation. I'll prepare a fix to move back getPrefixed into canonicalize_md.c. However, could you please still fix your internal build in terms that it would have 'jdk_util.h' in the include path?

RE: RFR: 8234185: Cleanup usage of canonicalize function between libjava, hotspot and libinstrument

Hi David, thanks for your investigation. I'll prepare a fix to move back getPrefixed into canonicalize_md.c. However, could you please still fix your internal build in terms that it would have 'jdk_util.h' in the include path? Thanks Christoph > -Original Message- > From: David Holmes