Re: New candidate JEP: 370: Foreign-Memory Access API

2019-11-29 Thread John Rose
On Nov 29, 2019, at 4:24 AM, David Lloyd wrote: > > Makes sense, it's still early. But now the seed is planted. :) (It’s better documented. Most of the points made here were not new.)

Re: [14] RFR (S): 8234923: Missed call_site_target nmethod dependency for non-fully initialized ConstantCallSite instance

2019-11-29 Thread John Rose
Reviewed. > On Nov 29, 2019, at 7:55 AM, Vladimir Ivanov > wrote: > > http://cr.openjdk.java.net/~vlivanov/8234923/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8234923

Re: RFR: JEP 359: Records (Preview) (full code)

2019-11-29 Thread Vicente Romero
Hi Joe, All the tests that have an explicit -source 14 are that way because of, I think to remember, a bug in jtreg that doesn't expand the ${some.property} macro for those tests. I don't remember the details though Thanks, Vicente On 11/29/19 9:59 AM, Joe Darcy wrote: Hi Vicente, Please c

Re: New candidate JEP: 370: Foreign-Memory Access API

2019-11-29 Thread Maurizio Cimadamore
On 29/11/2019 19:32, Florian Weimer wrote: * Maurizio Cimadamore: While this could be done (and it was considered early during the design phase), we decided against it for two reasons: first, the VarHandle API is very expressive and already supports. atomic compareAndSwap operations out of th

Re: New candidate JEP: 370: Foreign-Memory Access API

2019-11-29 Thread Florian Weimer
* Maurizio Cimadamore: > While this could be done (and it was considered early during the design > phase), we decided against it for two reasons: first, the VarHandle API > is very expressive and already supports. atomic compareAndSwap  > operations out of the box, which are _very_ handy when d

Re: RFR: JEP 359: Records (Preview) (full code)

2019-11-29 Thread Jan Lahoda
Hi Vcente, Overall, looks fine I think. A few comments on the javac implementation: -in TypeEnter, I believe this: memberEnter.memberEnter(tree.defs.diff(List.convert(JCTree.class, defsBeforeAddingNewMembers)), env); is unnecessary (and fairly slow). defsBeforeAddingNewMembers is initialized to

[14] RFR (S): 8234923: Missed call_site_target nmethod dependency for non-fully initialized ConstantCallSite instance

2019-11-29 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8234923/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8234923 The fix for 8234401 is incomplete: though it does notify the JVM about call site target update (by calling setTargetNormal [2]), on JVM side JITs skip nmethod dependencies for ConstantCallSi

Re: RFR: JEP 359: Records (Preview) (full code)

2019-11-29 Thread Joe Darcy
Hi Vicente, Please change all uses of     @compile --enable-preview -source 14 in jtreg tags to to     @compile --enable-preview -source ${jdk.version} The former structure will spuriously fail when the JDK 14 -> 15 transition occurs. Also, publishing delta-webrevs between iterations in ad

Re: New candidate JEP: 370: Foreign-Memory Access API

2019-11-29 Thread David Lloyd
On Thu, Nov 28, 2019 at 11:24 AM Vladimir Ivanov wrote: > > > >> Second, what about an API to allocate memory from the stack? This is > >> really useful in GraalVM (granted they have a sort-of-Panama-ish way > >> of calling C functions already, and they're really quite "loose" when > >> it comes

Re: GENTLE REMINDER of RFR CSR JDK-8202555: Double.toString(double) sometimes produces incorrect results

2019-11-29 Thread Raffaello Giulietti
Yet another monthly reminder. The December rampdown is approaching... Greetings Raffaello On 2019-10-29 20:33, Raffaello Giulietti wrote: Since nothing seems to have moved, here's the familiar monthly reminder ;-) Greetings Raffaello On 2019-08-30 10:47, Raffaello Giulietti wrote: Hi, j

RE: RFR: 8234821: remove unused functions from libjli

2019-11-29 Thread Baesken, Matthias
Thanks for the reviews . jdk-submit is fine so there should be no issues . Best regards, Matthias > -Original Message- > From: Alan Bateman > Sent: Donnerstag, 28. November 2019 13:33 > To: Baesken, Matthias ; Langer, Christoph > ; core-libs-dev@openjdk.java.net > Subject: Re: RFR:

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

2019-11-29 Thread Severin Gehwolf
On Fri, 2019-11-15 at 17:51 +0100, Severin Gehwolf wrote: > Hi, > > Could I please get reviews of these core-libs, Linux-only, changes to > the Metrics subsystem? This patch implements cgroupv2 support for > Metrics which are currently cgroupv1-only. Fedora 31 switched to > cgroupv2 by default so